From 673148b567159853acb02c08431f53fcee5c5005 Mon Sep 17 00:00:00 2001 From: thllwg Date: Tue, 7 Jul 2020 22:00:02 +0200 Subject: [PATCH 1/4] Fix: Logger prints epoch instead of epoch_time --- utils/console_logger.py | 2 +- vocoder/utils/console_logger.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/utils/console_logger.py b/utils/console_logger.py index 0b361bb8..39da8b08 100644 --- a/utils/console_logger.py +++ b/utils/console_logger.py @@ -56,7 +56,7 @@ class ConsoleLogger(): def print_train_epoch_end(self, global_step, epoch, epoch_time, print_dict): indent = " | > " - log_text = f"\n{tcolors.BOLD} --> TRAIN PERFORMACE -- EPOCH TIME: {epoch} sec -- GLOBAL_STEP: {global_step}{tcolors.ENDC}\n" + log_text = f"\n{tcolors.BOLD} --> TRAIN PERFORMACE -- EPOCH TIME: {epoch_time} sec -- GLOBAL_STEP: {global_step}{tcolors.ENDC}\n" for key, value in print_dict.items(): log_text += "{}{}: {:.5f}\n".format(indent, key, value) print(log_text, flush=True) diff --git a/vocoder/utils/console_logger.py b/vocoder/utils/console_logger.py index 4f44986c..71181956 100644 --- a/vocoder/utils/console_logger.py +++ b/vocoder/utils/console_logger.py @@ -55,7 +55,7 @@ class ConsoleLogger(): def print_train_epoch_end(self, global_step, epoch, epoch_time, print_dict): indent = " | > " - log_text = f"\n{tcolors.BOLD} --> TRAIN PERFORMACE -- EPOCH TIME: {epoch} sec -- GLOBAL_STEP: {global_step}{tcolors.ENDC}\n" + log_text = f"\n{tcolors.BOLD} --> TRAIN PERFORMACE -- EPOCH TIME: {epoch_time} sec -- GLOBAL_STEP: {global_step}{tcolors.ENDC}\n" for key, value in print_dict.items(): log_text += "{}{}: {:.5f}\n".format(indent, key, value) print(log_text, flush=True) From 07e600547188634594681d54ed34858c5733dc55 Mon Sep 17 00:00:00 2001 From: thllwg Date: Fri, 10 Jul 2020 10:19:55 +0200 Subject: [PATCH 2/4] FIX: misplaced quote sign causes key error in config --- config.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config.json b/config.json index 0b20cd3a..5cf02505 100644 --- a/config.json +++ b/config.json @@ -106,7 +106,7 @@ // TENSORBOARD and LOGGING "print_step": 25, // Number of steps to log training on console. - "tb_plot_step:": 100, // Number of steps to plot TB training figures. + "tb_plot_step": 100, // Number of steps to plot TB training figures. "print_eval": false, // If True, it prints intermediate loss values in evalulation. "save_step": 10000, // Number of training steps expected to save traninpg stats and checkpoints. "checkpoint": true, // If true, it saves checkpoints per "save_step" From 1267e778460e040303d209ed54fcc8e3127d2544 Mon Sep 17 00:00:00 2001 From: thllwg Date: Mon, 13 Jul 2020 18:00:42 +0200 Subject: [PATCH 3/4] FIX: spec_gain should be float as indicated by assert --- config.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config.json b/config.json index 5cf02505..23868a33 100644 --- a/config.json +++ b/config.json @@ -29,7 +29,7 @@ "num_mels": 80, // size of the mel spec frame. "mel_fmin": 0.0, // minimum freq level for mel-spec. ~50 for male and ~95 for female voices. Tune for dataset!! "mel_fmax": 8000.0, // maximum freq level for mel-spec. Tune for dataset!! - "spec_gain": 20, + "spec_gain": 20.0, // Normalization parameters "signal_norm": true, // normalize spec values. Mean-Var normalization if 'stats_path' is defined otherwise range normalization defined by the other params. From b87a7ac356a5a0bf14a16631be5cc047de13a7be Mon Sep 17 00:00:00 2001 From: thllwg Date: Mon, 13 Jul 2020 19:02:17 +0200 Subject: [PATCH 4/4] Round seconds to two decimals --- utils/console_logger.py | 2 +- vocoder/utils/console_logger.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/utils/console_logger.py b/utils/console_logger.py index 39da8b08..85d5b376 100644 --- a/utils/console_logger.py +++ b/utils/console_logger.py @@ -56,7 +56,7 @@ class ConsoleLogger(): def print_train_epoch_end(self, global_step, epoch, epoch_time, print_dict): indent = " | > " - log_text = f"\n{tcolors.BOLD} --> TRAIN PERFORMACE -- EPOCH TIME: {epoch_time} sec -- GLOBAL_STEP: {global_step}{tcolors.ENDC}\n" + log_text = f"\n{tcolors.BOLD} --> TRAIN PERFORMACE -- EPOCH TIME: {epoch_time:.2f} sec -- GLOBAL_STEP: {global_step}{tcolors.ENDC}\n" for key, value in print_dict.items(): log_text += "{}{}: {:.5f}\n".format(indent, key, value) print(log_text, flush=True) diff --git a/vocoder/utils/console_logger.py b/vocoder/utils/console_logger.py index 71181956..6af0b823 100644 --- a/vocoder/utils/console_logger.py +++ b/vocoder/utils/console_logger.py @@ -55,7 +55,7 @@ class ConsoleLogger(): def print_train_epoch_end(self, global_step, epoch, epoch_time, print_dict): indent = " | > " - log_text = f"\n{tcolors.BOLD} --> TRAIN PERFORMACE -- EPOCH TIME: {epoch_time} sec -- GLOBAL_STEP: {global_step}{tcolors.ENDC}\n" + log_text = f"\n{tcolors.BOLD} --> TRAIN PERFORMACE -- EPOCH TIME: {epoch_time:.2f} sec -- GLOBAL_STEP: {global_step}{tcolors.ENDC}\n" for key, value in print_dict.items(): log_text += "{}{}: {:.5f}\n".format(indent, key, value) print(log_text, flush=True)