From e3fed5cf7097d50a2db8041fff27ce0badddc61e Mon Sep 17 00:00:00 2001 From: Enno Hermann Date: Wed, 8 May 2024 09:51:01 +0200 Subject: [PATCH] build: create separate makefile target for development install --- CONTRIBUTING.md | 2 +- Makefile | 7 +++++-- dockerfiles/Dockerfile.dev | 2 +- docs/source/installation.md | 5 +++++ 4 files changed, 12 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d8e8fc61..e93858f2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -60,7 +60,7 @@ The following steps are tested on an Ubuntu system. ```bash $ make system-deps # intended to be used on Ubuntu (Debian). Let us know if you have a different OS. - $ make install + $ make install_dev ``` 4. Create a new branch with an informative name for your goal. diff --git a/Makefile b/Makefile index e3372d30..077b4b23 100644 --- a/Makefile +++ b/Makefile @@ -1,5 +1,5 @@ .DEFAULT_GOAL := help -.PHONY: test system-deps dev-deps style lint install help docs +.PHONY: test system-deps dev-deps style lint install install_dev help docs help: @grep -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}' @@ -65,7 +65,10 @@ dev-deps: ## install development deps build-docs: ## build the docs cd docs && make clean && make build -install: ## install 🐸 TTS for development. +install: ## install 🐸 TTS + pip install -e .[all] + +install_dev: ## install 🐸 TTS for development. pip install -e .[all,dev] pre-commit install diff --git a/dockerfiles/Dockerfile.dev b/dockerfiles/Dockerfile.dev index 8b77a9a2..12242d12 100644 --- a/dockerfiles/Dockerfile.dev +++ b/dockerfiles/Dockerfile.dev @@ -41,4 +41,4 @@ RUN pip install \ COPY . /root # Installing the TTS package itself: -RUN make install +RUN make install_dev diff --git a/docs/source/installation.md b/docs/source/installation.md index f0b2a00f..405c4366 100644 --- a/docs/source/installation.md +++ b/docs/source/installation.md @@ -26,7 +26,12 @@ This is recommended for development and more control over 🐸TTS. git clone https://github.com/idiap/coqui-ai-TTS cd coqui-ai-TTS make system-deps # only on Linux systems. + +# Install package and optional extras make install + +# Same as above + dev dependencies and pre-commit +make install_dev ``` ## On Windows