databricks-cli/.golangci.yaml

linters:
  disable-all: true
  enable:
    - bodyclose
    - errcheck
    - gosimple
    #- govet
    - ineffassign
    - staticcheck
    - unused
    - gofmt
linters-settings:
  gofmt:
    rewrite-rules:
      - pattern: 'a[b:len(a)]'
        replacement: 'a[b:]'
      - pattern: 'interface{}'
        replacement: 'any'
  errcheck:
    exclude-functions:
      - (*github.com/spf13/cobra.Command).RegisterFlagCompletionFunc
      - (*github.com/spf13/cobra.Command).MarkFlagRequired
      - (*github.com/spf13/pflag.FlagSet).MarkDeprecated
      - (*github.com/spf13/pflag.FlagSet).MarkHidden
issues:
  exclude-dirs-use-default: false  # recommended by docs https://golangci-lint.run/usage/false-positives/
Add golangci-lint v1.62.2 (#1953) 2024-12-04 17:40:19 +00:00			`linters:`
			`disable-all: true`
			`enable:`
Enable linter bodyclose (#1968) ## Changes Enable linter '[bodyclose](https://github.com/timakin/bodyclose)' and fix 2 cases in tests. ## Tests Existing tests. 2024-12-05 19:11:49 +00:00			`- bodyclose`
Add error checking in tests and enable errcheck there (#1980) ## Changes Fix all errcheck-found issues in tests and test helpers. Mostly this done by adding require.NoError(t, err), sometimes panic() where t object is not available). Initial change is obtained with aider+claude, then manually reviewed and cleaned up. ## Tests Existing tests. 2024-12-09 12:56:41 +00:00			`- errcheck`
Add golangci-lint v1.62.2 (#1953) 2024-12-04 17:40:19 +00:00			`- gosimple`
			`#- govet`
			`- ineffassign`
			`- staticcheck`
			`- unused`
			`- gofmt`
			`linters-settings:`
			`gofmt:`
			`rewrite-rules:`
			`- pattern: 'a[b:len(a)]'`
			`replacement: 'a[b:]'`
Rewrite 'interface{} -> any' (#1959) ## Changes The `any` alias for `interface{}` has been around since Go 1.18. Now that we're using golangci-lint (#1953), we can lint on it. Existing commits can be updated with: ``` gofmt -w -r 'interface{} -> any' . ``` ## Tests n/a 2024-12-05 15:37:24 +00:00			`- pattern: 'interface{}'`
			`replacement: 'any'`
Enable errcheck everywhere and fix or silent remaining issues (#1987) ## Changes Enable errcheck linter for the whole codebase. Fix remaining complaints: - If we can propagate error to caller, do that - If we writing to stdout, continue ignoring errors (to avoid crashing in "cli \| head" case) - Add exception for cobra non-critical API such as MarkHidden/MarkDeprecated/RegisterFlagCompletionFunc. This keeps current code and behaviour, to be decided later if we want to change this. - Continue ignoring errors where that is desired behaviour (e.g. git.loadConfig). - Continue ignoring errors where panicking seems riskier than ignoring the error. - Annotate cases in libs/dyn with //nolint:errcheck - to be addressed later. Note, this PR is not meant to come up with the best strategy for each case, but to be a relative safe change to enable errcheck linter. ## Tests Existing tests. 2024-12-11 12:26:00 +00:00			`errcheck:`
			`exclude-functions:`
			`- (*github.com/spf13/cobra.Command).RegisterFlagCompletionFunc`
			`- (*github.com/spf13/cobra.Command).MarkFlagRequired`
			`- (*github.com/spf13/pflag.FlagSet).MarkDeprecated`
			`- (*github.com/spf13/pflag.FlagSet).MarkHidden`
Add golangci-lint v1.62.2 (#1953) 2024-12-04 17:40:19 +00:00			`issues:`
			`exclude-dirs-use-default: false # recommended by docs https://golangci-lint.run/usage/false-positives/`