steve/databricks-cli
steve
/
databricks-cli
mirror of https://github.com/databricks/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
databricks-cli/Makefile

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

41 lines
913 B
Makefile
Raw Normal View History

Initial commit
2022-05-13 13:30:22 +00:00
default: build
Speed up best case for "make test" 12x (#2060) On main branch: ‘make test’ takes about 33s On this branch: ‘make test’ takes about 2.7s (all measurements are for hot cache) What’s done (from highest impact to lowest): - Remove -coverprofile= option - this option was disabling "go test"'s built-in cache and also it took extra time to calculate the coverage (extra 21s). - Exclude ./integration/ folder, there are no unit tests there, but having it included adds significant time. "go test"'s caching also does not work there for me, due to TestMain() presence (extra 7.2s). - Remove dependency on "make lint" - nice to have, but slow to re-check the whole repo and should already be done by IDE (extra 2.5s). - Remove dependency on "make vendor" — rarely needed; on CI it is already executed separately (extra 1.1s). The coverage option is still available under "make cover". Use "make showcover" to show it. I’ve also removed separate "make testonly". If you only want tests, run "make test". If you want lint+test run "make lint test" etc. I've also modified the test command, removed unnecessary -short, -v, --raw-command.
2025-01-02 11:06:01 +00:00
PACKAGES=./libs/... ./internal/... ./cmd/... ./bundle/... .
lint:
Make "make" output the commands it runs (#2066) This is useful on CI and locally for debugging and being able to copy-paste command to tweak the options. Removed redundant and imprecise messages like "✓ Running tests ...".
2025-01-02 11:18:38 +00:00
./lint.sh ./...
Make 'make lint' apply --fix (#1995) Add 'make lintcheck' to lint without fixing. Fixing is what you usually want. No changes to github workflow since that does not call our Makefile.
2024-12-11 12:53:57 +00:00
Speed up best case for "make test" 12x (#2060) On main branch: ‘make test’ takes about 33s On this branch: ‘make test’ takes about 2.7s (all measurements are for hot cache) What’s done (from highest impact to lowest): - Remove -coverprofile= option - this option was disabling "go test"'s built-in cache and also it took extra time to calculate the coverage (extra 21s). - Exclude ./integration/ folder, there are no unit tests there, but having it included adds significant time. "go test"'s caching also does not work there for me, due to TestMain() presence (extra 7.2s). - Remove dependency on "make lint" - nice to have, but slow to re-check the whole repo and should already be done by IDE (extra 2.5s). - Remove dependency on "make vendor" — rarely needed; on CI it is already executed separately (extra 1.1s). The coverage option is still available under "make cover". Use "make showcover" to show it. I’ve also removed separate "make testonly". If you only want tests, run "make test". If you want lint+test run "make lint test" etc. I've also modified the test command, removed unnecessary -short, -v, --raw-command.
2025-01-02 11:06:01 +00:00
lintcheck:
Make "make" output the commands it runs (#2066) This is useful on CI and locally for debugging and being able to copy-paste command to tweak the options. Removed redundant and imprecise messages like "✓ Running tests ...".
2025-01-02 11:18:38 +00:00
golangci-lint run ./...
Initial commit
2022-05-13 13:30:22 +00:00
Speed up best case for "make test" 12x (#2060) On main branch: ‘make test’ takes about 33s On this branch: ‘make test’ takes about 2.7s (all measurements are for hot cache) What’s done (from highest impact to lowest): - Remove -coverprofile= option - this option was disabling "go test"'s built-in cache and also it took extra time to calculate the coverage (extra 21s). - Exclude ./integration/ folder, there are no unit tests there, but having it included adds significant time. "go test"'s caching also does not work there for me, due to TestMain() presence (extra 7.2s). - Remove dependency on "make lint" - nice to have, but slow to re-check the whole repo and should already be done by IDE (extra 2.5s). - Remove dependency on "make vendor" — rarely needed; on CI it is already executed separately (extra 1.1s). The coverage option is still available under "make cover". Use "make showcover" to show it. I’ve also removed separate "make testonly". If you only want tests, run "make test". If you want lint+test run "make lint test" etc. I've also modified the test command, removed unnecessary -short, -v, --raw-command.
2025-01-02 11:06:01 +00:00
test:
Make "make" output the commands it runs (#2066) This is useful on CI and locally for debugging and being able to copy-paste command to tweak the options. Removed redundant and imprecise messages like "✓ Running tests ...".
2025-01-02 11:18:38 +00:00
gotestsum --format pkgname-and-test-fails --no-summary=skipped -- ${PACKAGES}
Speed up best case for "make test" 12x (#2060) On main branch: ‘make test’ takes about 33s On this branch: ‘make test’ takes about 2.7s (all measurements are for hot cache) What’s done (from highest impact to lowest): - Remove -coverprofile= option - this option was disabling "go test"'s built-in cache and also it took extra time to calculate the coverage (extra 21s). - Exclude ./integration/ folder, there are no unit tests there, but having it included adds significant time. "go test"'s caching also does not work there for me, due to TestMain() presence (extra 7.2s). - Remove dependency on "make lint" - nice to have, but slow to re-check the whole repo and should already be done by IDE (extra 2.5s). - Remove dependency on "make vendor" — rarely needed; on CI it is already executed separately (extra 1.1s). The coverage option is still available under "make cover". Use "make showcover" to show it. I’ve also removed separate "make testonly". If you only want tests, run "make test". If you want lint+test run "make lint test" etc. I've also modified the test command, removed unnecessary -short, -v, --raw-command.
2025-01-02 11:06:01 +00:00
cover:
Make "make" output the commands it runs (#2066) This is useful on CI and locally for debugging and being able to copy-paste command to tweak the options. Removed redundant and imprecise messages like "✓ Running tests ...".
2025-01-02 11:18:38 +00:00
gotestsum --format pkgname-and-test-fails --no-summary=skipped -- -coverprofile=coverage.txt ${PACKAGES}
Initial commit
2022-05-13 13:30:22 +00:00
Speed up best case for "make test" 12x (#2060) On main branch: ‘make test’ takes about 33s On this branch: ‘make test’ takes about 2.7s (all measurements are for hot cache) What’s done (from highest impact to lowest): - Remove -coverprofile= option - this option was disabling "go test"'s built-in cache and also it took extra time to calculate the coverage (extra 21s). - Exclude ./integration/ folder, there are no unit tests there, but having it included adds significant time. "go test"'s caching also does not work there for me, due to TestMain() presence (extra 7.2s). - Remove dependency on "make lint" - nice to have, but slow to re-check the whole repo and should already be done by IDE (extra 2.5s). - Remove dependency on "make vendor" — rarely needed; on CI it is already executed separately (extra 1.1s). The coverage option is still available under "make cover". Use "make showcover" to show it. I’ve also removed separate "make testonly". If you only want tests, run "make test". If you want lint+test run "make lint test" etc. I've also modified the test command, removed unnecessary -short, -v, --raw-command.
2025-01-02 11:06:01 +00:00
showcover:
Make "make" output the commands it runs (#2066) This is useful on CI and locally for debugging and being able to copy-paste command to tweak the options. Removed redundant and imprecise messages like "✓ Running tests ...".
2025-01-02 11:18:38 +00:00
go tool cover -html=coverage.txt
Initial commit
2022-05-13 13:30:22 +00:00
build: vendor
Make "make" output the commands it runs (#2066) This is useful on CI and locally for debugging and being able to copy-paste command to tweak the options. Removed redundant and imprecise messages like "✓ Running tests ...".
2025-01-02 11:18:38 +00:00
go build -mod vendor
Initial commit
2022-05-13 13:30:22 +00:00
updated dependencies
2022-05-14 17:56:09 +00:00
snapshot:
Make "make" output the commands it runs (#2066) This is useful on CI and locally for debugging and being able to copy-paste command to tweak the options. Removed redundant and imprecise messages like "✓ Running tests ...".
2025-01-02 11:18:38 +00:00
go build -o .databricks/databricks
updated dependencies
2022-05-14 17:56:09 +00:00
Initial commit
2022-05-13 13:30:22 +00:00
vendor:
Make "make" output the commands it runs (#2066) This is useful on CI and locally for debugging and being able to copy-paste command to tweak the options. Removed redundant and imprecise messages like "✓ Running tests ...".
2025-01-02 11:18:38 +00:00
go mod vendor
Custom annotations for bundle-specific JSON schema fields (#1957) ## Changes Adds annotations to json-schema for fields which are not covered by OpenAPI spec. Custom descriptions were copy-pasted from documentation PR which is still WIP so descriptions for some fields are missing Further improvements: * documentation autogen based on json-schema * fix missing descriptions ## Tests This script is not part of CLI package so I didn't test all corner cases. Few high-level tests were added to be sure that schema annotations is in sync with actual config --------- Co-authored-by: Pieter Noordhuis <pieter.noordhuis@databricks.com>
2024-12-18 10:19:14 +00:00
schema:
Make "make" output the commands it runs (#2066) This is useful on CI and locally for debugging and being able to copy-paste command to tweak the options. Removed redundant and imprecise messages like "✓ Running tests ...".
2025-01-02 11:18:38 +00:00
go run ./bundle/internal/schema ./bundle/internal/schema ./bundle/schema/jsonschema.json
Initial commit
2022-05-13 13:30:22 +00:00
Skip job runs during integration testing for PRs (#2024) ## Changes A small subset of tests trigger cluster creation to run jobs. These tests comprise a substantial amount of the total integration test runtime. We can skip them on PRs and only run them on the main branch. ## Tests Confirmed the short runtime is ~20 mins.
2024-12-17 17:16:58 +00:00
INTEGRATION = gotestsum --format github-actions --rerun-fails --jsonfile output.json --packages "./integration/..." -- -parallel 4 -timeout=2h
Add build rule for running integration tests (#1965) ## Changes Make it possible to change what/how we run our integration tests from within this repository. ## Tests Integration tests all pass when run with this command.
2024-12-09 09:52:08 +00:00
integration:
Skip job runs during integration testing for PRs (#2024) ## Changes A small subset of tests trigger cluster creation to run jobs. These tests comprise a substantial amount of the total integration test runtime. We can skip them on PRs and only run them on the main branch. ## Tests Confirmed the short runtime is ~20 mins.
2024-12-17 17:16:58 +00:00
$(INTEGRATION)
integration-short:
$(INTEGRATION) -short
Support Unity Catalog Registered Models in bundles (#846) ## Changes <!-- Summary of your changes that are easy to understand --> Add UC Registered Models support to Databricks Asset Bundles as new resource `registered_model`. Also added UC Permission support via new resource `grant`. ## Tests <!-- How is this tested? --> Tested via unit tests and manual testing with [example PR](https://github.com/databricks/bundle-examples-internal/pull/80) and [custom Terraform provider](https://github.com/databricks/terraform-provider-databricks/pull/2771). <img width="698" alt="Screenshot 2023-10-08 at 4 57 23 PM" src="https://github.com/databricks/cli/assets/87999496/bcf605a9-7894-443b-865a-f7e240037815"> <img width="1109" alt="Screenshot 2023-10-08 at 4 56 47 PM" src="https://github.com/databricks/cli/assets/87999496/e4d6e424-cd70-4809-8843-6939ed2e172f"> <img width="1091" alt="Screenshot 2023-10-08 at 4 56 57 PM" src="https://github.com/databricks/cli/assets/87999496/88ebaabb-67db-4a11-88a5-df087e2e41c0"> --------- Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com> Co-authored-by: Andrew Nester <andrew.nester.dev@gmail.com> Co-authored-by: Pieter Noordhuis <pieter.noordhuis@databricks.com>
2023-10-16 15:32:49 +00:00
Speed up best case for "make test" 12x (#2060) On main branch: ‘make test’ takes about 33s On this branch: ‘make test’ takes about 2.7s (all measurements are for hot cache) What’s done (from highest impact to lowest): - Remove -coverprofile= option - this option was disabling "go test"'s built-in cache and also it took extra time to calculate the coverage (extra 21s). - Exclude ./integration/ folder, there are no unit tests there, but having it included adds significant time. "go test"'s caching also does not work there for me, due to TestMain() presence (extra 7.2s). - Remove dependency on "make lint" - nice to have, but slow to re-check the whole repo and should already be done by IDE (extra 2.5s). - Remove dependency on "make vendor" — rarely needed; on CI it is already executed separately (extra 1.1s). The coverage option is still available under "make cover". Use "make showcover" to show it. I’ve also removed separate "make testonly". If you only want tests, run "make test". If you want lint+test run "make lint test" etc. I've also modified the test command, removed unnecessary -short, -v, --raw-command.
2025-01-02 11:06:01 +00:00
.PHONY: lint lintcheck test cover showcover build snapshot vendor schema integration integration-short