steve/databricks-cli
steve
/
databricks-cli
mirror of https://github.com/databricks/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

remove 503 detection

This commit is contained in:
Shreyas Goenka 2025-03-06 11:04:52 +01:00
parent 7b61d7faef
commit 0ac9a2aa97
No known key found for this signature in database
GPG Key ID: 92A07DF49CCB0622
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libs/telemetry/logger.go
View File

@ -105,11 +105,15 @@ func Upload(ctx context.Context, cfg *config.Config) error {
continue
}
// We retry for all 5xx responses. We explicitly omit 503 in the predicate here
// because it is already automatically retried in the SDK layer.
// ref: https://github.com/databricks/databricks-sdk-go/blob/cdb28002afacb8b762348534a4c4040a9f19c24b/apierr/errors.go#L91
// We retry for all 5xx responses. Note that the SDK only retries for 503 and 429
// (as of 6th March 2025) so we need some additional logic here to retry for other
// 5xx responses.
// SDK ref: https://github.com/databricks/databricks-sdk-go/blob/cdb28002afacb8b762348534a4c4040a9f19c24b/apierr/errors.go#L91
//
// The UI infra team (who owns the /telemetry-ext API) recommends retrying for
// all 5xx responses.
var apiErr *apierr.APIError
if errors.As(err, &apiErr) && apiErr.StatusCode >= 500 && apiErr.StatusCode != 503 {
if errors.As(err, &apiErr) && apiErr.StatusCode >= 500 {
log.Debugf(ctx, "Attempt %d failed due to a server side error. Retrying status code: %d\n", i+1, apiErr.StatusCode)
time.Sleep(200 * time.Millisecond)
continue