steve/databricks-cli
steve
/
databricks-cli
mirror of https://github.com/databricks/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Assert tokens are redacted in origin URL when username is not specified (#1785) 

TSIA
This commit is contained in:
shreyas-goenka 2024-09-23 18:12:30 +05:30 committed by GitHub
parent 56ed9bebf3
commit 0cc35ca056
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 22 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
libs/git/repository_test.go
View File

@ -209,7 +209,26 @@ func TestRepositoryGitConfigWhenNotARepo(t *testing.T) {
} }
func TestRepositoryOriginUrlRemovesUserCreds(t *testing.T) { func TestRepositoryOriginUrlRemovesUserCreds(t *testing.T) {
tcases := []struct {
url string
expected string
}{
{
url: "https://username:token@github.com/databricks/foobar.git",
expected: "https://github.com/databricks/foobar.git",
},
{
// Note: The token is still considered and parsed as a username here.
// However credentials integrations by Git providers like GitHub
// allow for setting a PAT token as a username.
url: "https://token@github.com/databricks/foobar.git",
expected: "https://github.com/databricks/foobar.git",
},
}
for _, tc := range tcases {
repo := newTestRepository(t) repo := newTestRepository(t)
repo.addOriginUrl("https://username:token@github.com/databricks/foobar.git") repo.addOriginUrl(tc.url)
repo.assertOriginUrl("https://github.com/databricks/foobar.git") repo.assertOriginUrl(tc.expected)
}
} }