From 13748f177d605a9698c93228549d6394cbd3cc09 Mon Sep 17 00:00:00 2001 From: Shreyas Goenka Date: Mon, 16 Sep 2024 03:14:30 +0200 Subject: [PATCH] cleanup todos --- bundle/config/resources/volume.go | 3 --- bundle/deploy/terraform/tfdyn/convert_volume.go | 4 ---- 2 files changed, 7 deletions(-) diff --git a/bundle/config/resources/volume.go b/bundle/config/resources/volume.go index 0ee4dce8a..386d2ee37 100644 --- a/bundle/config/resources/volume.go +++ b/bundle/config/resources/volume.go @@ -9,13 +9,10 @@ type Volume struct { // List of grants to apply on this schema. Grants []Grant `json:"grants,omitempty"` - // TODO: Confirm the accuracy of this comment. // Full name of the schema (catalog_name.schema_name.volume_name). This value is read from // the terraform state after deployment succeeds. ID string `json:"id,omitempty" bundle:"readonly"` - // TODO: Are there fields in the edit API or terraform that are not in this struct? - // If so call it out in the PR. *catalog.CreateVolumeRequestContent ModifiedStatus ModifiedStatus `json:"modified_status,omitempty" bundle:"internal"` diff --git a/bundle/deploy/terraform/tfdyn/convert_volume.go b/bundle/deploy/terraform/tfdyn/convert_volume.go index 281cd4326..4211e1f9e 100644 --- a/bundle/deploy/terraform/tfdyn/convert_volume.go +++ b/bundle/deploy/terraform/tfdyn/convert_volume.go @@ -10,10 +10,6 @@ import ( "github.com/databricks/cli/libs/log" ) -// TODO: Articulate the consequences of deleting a UC volume in the prompt message that -// is displayed. -// TODO: What sort of interpolation should be allowed at `artifact_path`? Should it be -// ${volumes.foo.id} or ${volumes.foo.name} or something else? func convertVolumeResource(ctx context.Context, vin dyn.Value) (dyn.Value, error) { // Normalize the output value to the target schema. vout, diags := convert.Normalize(schema.ResourceVolume{}, vin)