steve/databricks-cli
steve
/
databricks-cli
mirror of https://github.com/databricks/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove superfluous helper (#2028) 

## Changes

There was only one helper for AWS and not the other clouds. Found this
when looking through double calls to `acc.WorkspaceTest()` (see
`TestPythonWheelTaskDeployAndRunOnInteractiveCluster`).

## Tests

n/a
This commit is contained in:
Pieter Noordhuis 2024-12-17 18:34:09 +01:00 committed by GitHub
parent 23ddee8023
commit 13fa43e0f5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
integration/bundle/clusters_test.go
View File

@ -12,12 +12,12 @@ import (
) )
func TestDeployBundleWithCluster(t *testing.T) { func TestDeployBundleWithCluster(t *testing.T) {
ctx, wt := acc.WorkspaceTest(t) if testutil.GetCloud(t) == testutil.AWS {
if testutil.IsAWSCloud(wt) {
t.Skip("Skipping test for AWS cloud because it is not permitted to create clusters") t.Skip("Skipping test for AWS cloud because it is not permitted to create clusters")
} }
ctx, wt := acc.WorkspaceTest(t)
nodeTypeId := testutil.GetCloud(t).NodeTypeID() nodeTypeId := testutil.GetCloud(t).NodeTypeID()
uniqueId := uuid.New().String() uniqueId := uuid.New().String()
root := initTestTemplate(t, ctx, "clusters", map[string]any{ root := initTestTemplate(t, ctx, "clusters", map[string]any{

4
integration/bundle/python_wheel_test.go
View File

@ -56,9 +56,7 @@ func TestPythonWheelTaskDeployAndRunWithWrapper(t *testing.T) {
} }
func TestPythonWheelTaskDeployAndRunOnInteractiveCluster(t *testing.T) { func TestPythonWheelTaskDeployAndRunOnInteractiveCluster(t *testing.T) {
_, wt := acc.WorkspaceTest(t) if testutil.GetCloud(t) == testutil.AWS {
if testutil.IsAWSCloud(wt) {
t.Skip("Skipping test for AWS cloud because it is not permitted to create clusters") t.Skip("Skipping test for AWS cloud because it is not permitted to create clusters")
} }

4
internal/testutil/cloud.go
View File

@ -58,7 +58,3 @@ func GetCloud(t TestingT) Cloud {
} }
return -1 return -1
} }
func IsAWSCloud(t TestingT) bool {
return GetCloud(t) == AWS
}