From 1588a14d07f36a2faa1923323dfd503eae42eca1 Mon Sep 17 00:00:00 2001 From: Andrew Nester Date: Thu, 22 Feb 2024 15:52:49 +0100 Subject: [PATCH] Add correct tag value for models in dev mode (#1230) ## Changes Fixes #922 ## Tests Added regression test case --- bundle/config/mutator/process_target_mode.go | 2 +- bundle/config/mutator/process_target_mode_test.go | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/bundle/config/mutator/process_target_mode.go b/bundle/config/mutator/process_target_mode.go index 592e3612..e5750945 100644 --- a/bundle/config/mutator/process_target_mode.go +++ b/bundle/config/mutator/process_target_mode.go @@ -70,7 +70,7 @@ func transformDevelopmentMode(b *bundle.Bundle) error { for i := range r.Models { r.Models[i].Name = prefix + r.Models[i].Name - r.Models[i].Tags = append(r.Models[i].Tags, ml.ModelTag{Key: "dev", Value: ""}) + r.Models[i].Tags = append(r.Models[i].Tags, ml.ModelTag{Key: "dev", Value: tagValue}) } for i := range r.Experiments { diff --git a/bundle/config/mutator/process_target_mode_test.go b/bundle/config/mutator/process_target_mode_test.go index 6d802580..a5f61284 100644 --- a/bundle/config/mutator/process_target_mode_test.go +++ b/bundle/config/mutator/process_target_mode_test.go @@ -138,6 +138,7 @@ func TestProcessTargetModeDevelopment(t *testing.T) { // Model 1 assert.Equal(t, "[dev lennart] model1", b.Config.Resources.Models["model1"].Name) + assert.Contains(t, b.Config.Resources.Models["model1"].Tags, ml.ModelTag{Key: "dev", Value: "lennart"}) // Model serving endpoint 1 assert.Equal(t, "dev_lennart_servingendpoint1", b.Config.Resources.ModelServingEndpoints["servingendpoint1"].Name)