mirror of https://github.com/databricks/cli.git
Bring back `--json` flag for workspace-conf set-status command (#1151)
## Changes --json flag was removed from this command when MustUseJson / CanUseJson generator functions were introduced which did not take requests types of map. This PR bring the flag back. Relies on this Go SDK change: https://github.com/databricks/databricks-sdk-go/pull/786
This commit is contained in:
parent
f269f8015d
commit
1fb15331c5
|
@ -3,8 +3,11 @@
|
|||
package workspace_conf
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
|
||||
"github.com/databricks/cli/cmd/root"
|
||||
"github.com/databricks/cli/libs/cmdio"
|
||||
"github.com/databricks/cli/libs/flags"
|
||||
"github.com/databricks/databricks-sdk-go/service/settings"
|
||||
"github.com/spf13/cobra"
|
||||
)
|
||||
|
@ -106,8 +109,10 @@ func newSetStatus() *cobra.Command {
|
|||
cmd := &cobra.Command{}
|
||||
|
||||
var setStatusReq settings.WorkspaceConf
|
||||
var setStatusJson flags.JsonFlag
|
||||
|
||||
// TODO: short flags
|
||||
cmd.Flags().Var(&setStatusJson, "json", `either inline JSON string or @path/to/file.json with request body`)
|
||||
|
||||
cmd.Use = "set-status"
|
||||
cmd.Short = `Enable/disable features.`
|
||||
|
@ -118,16 +123,20 @@ func newSetStatus() *cobra.Command {
|
|||
|
||||
cmd.Annotations = make(map[string]string)
|
||||
|
||||
cmd.Args = func(cmd *cobra.Command, args []string) error {
|
||||
check := cobra.ExactArgs(0)
|
||||
return check(cmd, args)
|
||||
}
|
||||
|
||||
cmd.PreRunE = root.MustWorkspaceClient
|
||||
cmd.RunE = func(cmd *cobra.Command, args []string) (err error) {
|
||||
ctx := cmd.Context()
|
||||
w := root.WorkspaceClient(ctx)
|
||||
|
||||
if cmd.Flags().Changed("json") {
|
||||
err = setStatusJson.Unmarshal(&setStatusReq)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
} else {
|
||||
return fmt.Errorf("please provide command input in JSON format by specifying the --json flag")
|
||||
}
|
||||
|
||||
err = w.WorkspaceConf.SetStatus(ctx, setStatusReq)
|
||||
if err != nil {
|
||||
return err
|
||||
|
|
Loading…
Reference in New Issue