From 1306e5ec6745b36acd7c17c9b3b4aea1f55d6807 Mon Sep 17 00:00:00 2001 From: Denis Bilenko Date: Mon, 30 Dec 2024 18:41:45 +0100 Subject: [PATCH 1/2] Add CODEOWNERS (#2055) Goal is to have DABs core team automatically added as reviewers so that you don't have to click manually. Based on this example: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#example-of-a-codeowners-file --- .github/CODEOWNERS | 1 + 1 file changed, 1 insertion(+) create mode 100644 .github/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 000000000..76835de7d --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1 @@ +* @pietern @andrewnester @shreyas-goenka @denik From 1ce20a2612031a3d5c7b663203296957671e4f1d Mon Sep 17 00:00:00 2001 From: Denis Bilenko Date: Mon, 30 Dec 2024 19:39:33 +0100 Subject: [PATCH 2/2] lint.sh: read config for formatters; include gofmt (#2056) As suggested here: https://github.com/databricks/cli/pull/2051#discussion_r1899641273 --- lint.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lint.sh b/lint.sh index c93d04c66..13efa9855 100755 --- a/lint.sh +++ b/lint.sh @@ -5,5 +5,5 @@ set -euo pipefail # However, running goimports first alone will actually fix some of the compilation issues. # Fixing formatting is also reasonable thing to do. # For this reason, this script runs golangci-lint in two stages: -golangci-lint run --fix --no-config --disable-all --enable gofumpt,goimports $@ +golangci-lint run --enable-only="gofmt,gofumpt,goimports" --fix $@ exec golangci-lint run --fix $@