From 33645ae6efcd06b876dadaf8ce94edbd7a066fd6 Mon Sep 17 00:00:00 2001 From: Pieter Noordhuis Date: Wed, 5 Apr 2023 15:37:09 +0200 Subject: [PATCH] Revert "Configure log level to info by default (#267)" (#307) ## Changes This reverts commit e7a7e5b95a50f6f3e08d4ee5a6469e5163df3e6a. Job and pipeline runs print progress information now. No need to continue to rely on logging for this. ## Tests --- libs/flags/log_level_flag.go | 4 +--- libs/flags/log_level_flag_test.go | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/libs/flags/log_level_flag.go b/libs/flags/log_level_flag.go index 6618d10b9..35850b315 100644 --- a/libs/flags/log_level_flag.go +++ b/libs/flags/log_level_flag.go @@ -25,9 +25,7 @@ type LogLevelFlag struct { func NewLogLevelFlag() LogLevelFlag { return LogLevelFlag{ - // Note: we log at INFO level by default until - // we implement progress reporting to stdout/stderr. - l: log.LevelInfo, + l: log.LevelDisabled, } } diff --git a/libs/flags/log_level_flag_test.go b/libs/flags/log_level_flag_test.go index 7507fdfbe..ca54d8a9c 100644 --- a/libs/flags/log_level_flag_test.go +++ b/libs/flags/log_level_flag_test.go @@ -10,8 +10,8 @@ import ( func TestLogLevelFlagDefault(t *testing.T) { f := NewLogLevelFlag() - assert.Equal(t, log.LevelInfo, f.Level()) - assert.Equal(t, "info", f.String()) + assert.Equal(t, log.LevelDisabled, f.Level()) + assert.Equal(t, "disabled", f.String()) } func TestLogLevelFlagSetValid(t *testing.T) {