steve/databricks-cli
steve
/
databricks-cli
mirror of https://github.com/databricks/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: Update test to use dynamic values for comparison instead of raw file content

This commit is contained in:
Ilya Kuznetsov 2024-12-17 16:43:27 +01:00
parent 7d8ae48f6b
commit 34d7484b75
No known key found for this signature in database
GPG Key ID: 91F3DDCF5D21CDDF
1 changed files with 23 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
bundle/internal/schema/main_test.go
View File

@ -1,13 +1,19 @@
package main package main
import ( import (
"bytes"
"fmt"
"io" "io"
"os" "os"
"path" "path"
"reflect" "reflect"
"strings"
"testing" "testing"
"github.com/databricks/cli/bundle/config" "github.com/databricks/cli/bundle/config"
"github.com/databricks/cli/libs/dyn"
"github.com/databricks/cli/libs/dyn/merge"
"github.com/databricks/cli/libs/dyn/yamlloader"
"github.com/databricks/cli/libs/jsonschema" "github.com/databricks/cli/libs/jsonschema"
"github.com/ghodss/yaml" "github.com/ghodss/yaml"
"github.com/stretchr/testify/assert" "github.com/stretchr/testify/assert"
@ -55,11 +61,25 @@ func TestRequiredAnnotationsForNewFields(t *testing.T) {
generateSchema(workdir, path.Join(t.TempDir(), "schema.json")) generateSchema(workdir, path.Join(t.TempDir(), "schema.json"))
original, err := os.ReadFile("annotations.yml") originalFile, err := os.ReadFile("annotations.yml")
assert.NoError(t, err) assert.NoError(t, err)
copied, err := os.ReadFile(annotationsPath) currentFile, err := os.ReadFile(annotationsPath)
assert.NoError(t, err) assert.NoError(t, err)
assert.Equal(t, string(original), string(copied), "Missing JSON-schema descriptions for new config fields in bundle/internal/schema/annotations.yml") original, err := yamlloader.LoadYAML("", bytes.NewBuffer(originalFile))
assert.NoError(t, err)
current, err := yamlloader.LoadYAML("", bytes.NewBuffer(currentFile))
assert.NoError(t, err)
// Collect added paths.
var updatedFieldPaths []string
_, err = merge.Override(original, current, merge.OverrideVisitor{
VisitInsert: func(basePath dyn.Path, right dyn.Value) (dyn.Value, error) {
updatedFieldPaths = append(updatedFieldPaths, basePath.String())
return right, nil
},
})
assert.NoError(t, err)
assert.Empty(t, updatedFieldPaths, fmt.Sprintf("Missing JSON-schema descriptions for new config fields in bundle/internal/schema/annotations.yml:\n%s", strings.Join(updatedFieldPaths, "\n")))
} }
// Checks whether types in annotation files are still present in Config type // Checks whether types in annotation files are still present in Config type