From 3959ca1317d15628bc7bcbff563d3ad3ef70dfb3 Mon Sep 17 00:00:00 2001 From: Shreyas Goenka Date: Thu, 29 Jun 2023 18:56:33 +0200 Subject: [PATCH] remove todos --- libs/git/clone.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/libs/git/clone.go b/libs/git/clone.go index d48518be..f3e96897 100644 --- a/libs/git/clone.go +++ b/libs/git/clone.go @@ -52,7 +52,6 @@ func (opts CloneOptions) zipUrl() string { return fmt.Sprintf(`%s/archive/%s.zip`, opts.repoUrl(), opts.Reference) } -// TODO: test this holds true for alternate branches and tags func (opts CloneOptions) destination() string { return filepath.Join(opts.TargetDir, opts.RepositoryName+"-"+opts.Reference) } @@ -88,7 +87,6 @@ func download(ctx context.Context, url string, dest string) error { } func clonePrivate(ctx context.Context, opts CloneOptions) error { - // TODO: test that the branch --branch flag works with tags cmd := exec.CommandContext(ctx, "git", "clone", opts.repoUrl(), opts.destination(), "--branch", opts.Reference) // Redirect exec command output