From 3b07265113061b0827ab639173882f98025edee2 Mon Sep 17 00:00:00 2001 From: Andrew Nester Date: Mon, 3 Mar 2025 15:34:41 +0000 Subject: [PATCH] Restrict same name libraries check for only whl and jar types (#2401) ## Changes Same name libraries check only valid for local libraries. Local libraries are only supported for Whl and Jar types. Hence we can restrict matching pattern only to these libraries. ## Tests Existing acceptance tests pass --- bundle/libraries/same_name_libraries.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/bundle/libraries/same_name_libraries.go b/bundle/libraries/same_name_libraries.go index ab869d3d2..907843193 100644 --- a/bundle/libraries/same_name_libraries.go +++ b/bundle/libraries/same_name_libraries.go @@ -13,8 +13,10 @@ import ( type checkForSameNameLibraries struct{} var patterns = []dyn.Pattern{ - taskLibrariesPattern.Append(dyn.AnyIndex(), dyn.AnyKey()), - forEachTaskLibrariesPattern.Append(dyn.AnyIndex(), dyn.AnyKey()), + taskLibrariesPattern.Append(dyn.AnyIndex(), dyn.Key("whl")), + taskLibrariesPattern.Append(dyn.AnyIndex(), dyn.Key("jar")), + forEachTaskLibrariesPattern.Append(dyn.AnyIndex(), dyn.Key("whl")), + forEachTaskLibrariesPattern.Append(dyn.AnyIndex(), dyn.Key("jar")), envDepsPattern.Append(dyn.AnyIndex()), }