diff --git a/cmd/bundle/generate/generate_test.go b/cmd/bundle/generate/generate_test.go index 943f721c..bfc9611a 100644 --- a/cmd/bundle/generate/generate_test.go +++ b/cmd/bundle/generate/generate_test.go @@ -90,7 +90,7 @@ func TestGeneratePipelineCommand(t *testing.T) { err := cmd.RunE(cmd, []string{}) require.NoError(t, err) - data, err := os.ReadFile(filepath.Join(configDir, "test_pipeline.yml")) + data, err := os.ReadFile(filepath.Join(configDir, "test_pipeline.pipeline.yml")) require.NoError(t, err) require.Equal(t, fmt.Sprintf(`resources: pipelines: @@ -186,7 +186,7 @@ func TestGenerateJobCommand(t *testing.T) { err := cmd.RunE(cmd, []string{}) require.NoError(t, err) - data, err := os.ReadFile(filepath.Join(configDir, "test_job.yml")) + data, err := os.ReadFile(filepath.Join(configDir, "test_job.job.yml")) require.NoError(t, err) require.Equal(t, fmt.Sprintf(`resources: diff --git a/cmd/bundle/generate/job.go b/cmd/bundle/generate/job.go index 99bc6166..ba204c59 100644 --- a/cmd/bundle/generate/job.go +++ b/cmd/bundle/generate/job.go @@ -1,7 +1,9 @@ package generate import ( + "errors" "fmt" + "io/fs" "os" "path/filepath" @@ -83,7 +85,14 @@ func NewGenerateJobCommand() *cobra.Command { return err } - filename := filepath.Join(configDir, fmt.Sprintf("%s.yml", jobKey)) + oldFilename := filepath.Join(configDir, fmt.Sprintf("%s.yml", jobKey)) + filename := filepath.Join(configDir, fmt.Sprintf("%s.job.yml", jobKey)) + + err = os.Rename(oldFilename, filename) + if err != nil && !errors.Is(err, fs.ErrNotExist) { + return fmt.Errorf("failed to rename file %s. DABs uses resource type as sub extension for generated content, please rename to %s, err: %w", oldFilename, filename, err) + } + saver := yamlsaver.NewSaverWithStyle(map[string]yaml.Style{ // Including all JobSettings and nested fields which are map[string]string type "spark_conf": yaml.DoubleQuotedStyle, diff --git a/cmd/bundle/generate/pipeline.go b/cmd/bundle/generate/pipeline.go index bd973fe0..9bce0b55 100644 --- a/cmd/bundle/generate/pipeline.go +++ b/cmd/bundle/generate/pipeline.go @@ -1,7 +1,9 @@ package generate import ( + "errors" "fmt" + "io/fs" "os" "path/filepath" @@ -83,7 +85,14 @@ func NewGeneratePipelineCommand() *cobra.Command { return err } - filename := filepath.Join(configDir, fmt.Sprintf("%s.yml", pipelineKey)) + oldFilename := filepath.Join(configDir, fmt.Sprintf("%s.yml", pipelineKey)) + filename := filepath.Join(configDir, fmt.Sprintf("%s.pipeline.yml", pipelineKey)) + + err = os.Rename(oldFilename, filename) + if err != nil && !errors.Is(err, fs.ErrNotExist) { + return fmt.Errorf("failed to rename file %s. DABs uses resource type as sub extension for generated content, please rename to %s, err: %w", oldFilename, filename, err) + } + saver := yamlsaver.NewSaverWithStyle( // Including all PipelineSpec and nested fields which are map[string]string type map[string]yaml.Style{