From 3d03df88448cf392f57f6aa64ecea1f36b957bcb Mon Sep 17 00:00:00 2001 From: shreyas-goenka <88374338+shreyas-goenka@users.noreply.github.com> Date: Wed, 14 Jun 2023 13:26:56 +0200 Subject: [PATCH] Add mode default as a valid set value for progress-format flag (#472) Manually tested `progress-format` works fine for all three modes --- libs/flags/progress_format.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/libs/flags/progress_format.go b/libs/flags/progress_format.go index 4dc3ed82..4458e99d 100644 --- a/libs/flags/progress_format.go +++ b/libs/flags/progress_format.go @@ -33,6 +33,11 @@ func (p *ProgressLogFormat) Set(s string) error { *p = ProgressLogFormat(ModeInplace.String()) case ModeJson.String(): *p = ProgressLogFormat(ModeJson.String()) + case ModeDefault.String(): + // We include ModeDefault here for symmetry reasons so this flag value + // can be unset after test runs. We should not point this value in error + // messages though since it's internal only + *p = ProgressLogFormat(ModeJson.String()) default: valid := []string{ ModeAppend.String(),