cleanup todos

This commit is contained in:
Shreyas Goenka 2024-08-27 17:45:20 +02:00
parent ad7503a176
commit 40f4d35c4a
No known key found for this signature in database
GPG Key ID: 92A07DF49CCB0622
2 changed files with 2 additions and 3 deletions

View File

@ -27,7 +27,6 @@ func addInterpolationPatterns(typ reflect.Type, s jsonschema.Schema) jsonschema.
return jsonschema.Schema{
AnyOf: []jsonschema.Schema{s, {
Type: jsonschema.StringType,
// TODO: Are multi-level complex variable references supported?
Pattern: interpolationPattern("var"),
}},
}
@ -36,7 +35,6 @@ func addInterpolationPatterns(typ reflect.Type, s jsonschema.Schema) jsonschema.
// or ${workspace.xyz}
return jsonschema.Schema{
AnyOf: []jsonschema.Schema{s,
// TODO: Is it only resource IDs or is it resources in general?
{Type: jsonschema.StringType, Pattern: interpolationPattern("resources")},
{Type: jsonschema.StringType, Pattern: interpolationPattern("bundle")},
{Type: jsonschema.StringType, Pattern: interpolationPattern("workspace")},

View File

@ -13,7 +13,8 @@ import (
// defines schema for a json object
type Schema struct {
// TODO: Comments for this field
// Definitions that can be reused and referenced throughout the schema. The
// syntax for a reference is $ref: #/$defs/<path.to.definition>
Definitions any `json:"$defs,omitempty"`
// Type of the object