steve/databricks-cli
steve
/
databricks-cli
mirror of https://github.com/databricks/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

resolving review comments

This commit is contained in:
hari-selvarajan_data 2025-01-27 17:56:46 +00:00
parent c514cca929
commit 41313db1b2
4 changed files with 27 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
.vscode/settings.json vendored Normal file
View File

@ -0,0 +1,21 @@
{
"[go]": {
"editor.insertSpaces": false,
"editor.formatOnSave": true
},
"go.lintTool": "golangci-lint",
"go.lintFlags": [
"--fast"
],
"go.useLanguageServer": true,
"gopls": {
"formatting.gofumpt": true
},
"files.trimTrailingWhitespace": true,
"files.insertFinalNewline": true,
"files.trimFinalNewlines": true,
"python.envFile": "${workspaceRoot}/.env",
"python.analysis.stubPath": ".vscode",
"jupyter.interactiveWindow.cellMarker.codeRegex": "^# COMMAND ----------|^# Databricks notebook source|^(#\\s*%%|#\\s*\\<codecell\\>|#\\s*In\\[\\d*?\\]|#\\s*In\\[ \\])",
"jupyter.interactiveWindow.cellMarker.default": "# COMMAND ----------"
}

7
cmd/labs/github/releases.go
View File

@ -23,9 +23,10 @@ func NewReleaseCache(org, repo, cacheDir string) *ReleaseCache {
} }
type ReleaseCache struct { type ReleaseCache struct {
Cache localcache.LocalCache[Versions] Cache localcache.LocalCache[Versions]
Org string Org string
Repo string Repo string
Offline bool
} }
func (r *ReleaseCache) Load(ctx context.Context) (Versions, error) { func (r *ReleaseCache) Load(ctx context.Context) (Versions, error) {

2
cmd/labs/install.go
View File

@ -10,7 +10,7 @@ func newInstallCommand() *cobra.Command {
cmd := &cobra.Command{} cmd := &cobra.Command{}
var offlineInstall bool var offlineInstall bool
cmd.Flags().BoolVar(&offlineInstall, "offline-install", offlineInstall, `If installing in offline mode, set this flag to true.`) cmd.Flags().BoolVar(&offlineInstall, "offline", offlineInstall, `If installing in offline mode, set this flag to true.`)
cmd.Use = "install NAME" cmd.Use = "install NAME"
cmd.Args = root.ExactArgs(1) cmd.Args = root.ExactArgs(1)

7
cmd/labs/project/fetcher.go
View File

@ -127,12 +127,7 @@ func (f *fetcher) checkReleasedVersions(cmd *cobra.Command, version string, offl
// `databricks labs isntall X` doesn't know which exact version to fetch, so first // `databricks labs isntall X` doesn't know which exact version to fetch, so first
// we fetch all versions and then pick the latest one dynamically. // we fetch all versions and then pick the latest one dynamically.
var versions github.Versions var versions github.Versions
if offlineInstall { versions, err = github.NewReleaseCache("databrickslabs", f.name, cacheDir, offlineInstall).Load(ctx)
versions, err = github.NewReleaseCache("databrickslabs", f.name, cacheDir).LoadCache(ctx)
} else {
versions, err = github.NewReleaseCache("databrickslabs", f.name, cacheDir).Load(ctx)
}
if err != nil { if err != nil {
return "", fmt.Errorf("versions: %w", err) return "", fmt.Errorf("versions: %w", err)
} }