diff --git a/bundle/schema/schema.go b/bundle/schema/schema.go index e155a421..9368cfb3 100644 --- a/bundle/schema/schema.go +++ b/bundle/schema/schema.go @@ -115,7 +115,7 @@ func safeToProperty(golangType reflect.Type, seenTypes map[reflect.Type]struct{} // Adds the member fields of golangType to the passed slice. Needed because // golangType can contain embedded fields (aka anonymous) -// +// // The function traverses the embedded fields in a breadth first manner // // params: @@ -151,10 +151,10 @@ func addStructFields(fields []reflect.StructField, golangType reflect.Type) []re // params: // golangType: golang type for which json schema properties to generate -// seenTypes : set of golang types already seen in path during recursion. +// seenTypes : set of golang types already seen in path during recursion. // Used to identify cycles. -// debugTrace: linked list of golang types encounted. In case of errors this -// helps log where the error originated from +// debugTrace: linked list of golang types encounted. In case of errors this +// helps log where the error originated from func toProperty(golangType reflect.Type, seenTypes map[reflect.Type]struct{}, debugTrace *list.List) (*Property, error) { // *Struct and Struct generate identical json schemas // TODO: add test case for pointer diff --git a/bundle/schema/schema_test.go b/bundle/schema/schema_test.go index 48e673e5..f03514fe 100644 --- a/bundle/schema/schema_test.go +++ b/bundle/schema/schema_test.go @@ -5,7 +5,6 @@ import ( "reflect" "testing" - "github.com/databricks/bricks/bundle/config" "github.com/stretchr/testify/assert" ) @@ -339,20 +338,20 @@ func TestEmbeddedStructSchema(t *testing.T) { assert.Equal(t, expected, string(jsonSchema)) } -// Only for testing bundle, will be removed -func TestBundleSchema(t *testing.T) { - elem := config.Root{} +// // Only for testing bundle, will be removed +// func TestBundleSchema(t *testing.T) { +// elem := config.Root{} - schema, err := NewSchema(reflect.TypeOf(elem)) - assert.NoError(t, err) +// schema, err := NewSchema(reflect.TypeOf(elem)) +// assert.NoError(t, err) - jsonSchema, err := json.MarshalIndent(schema, " ", " ") - assert.NoError(t, err) +// jsonSchema, err := json.MarshalIndent(schema, " ", " ") +// assert.NoError(t, err) - expected := - `` +// expected := +// `` - t.Log("[DEBUG] actual: ", string(jsonSchema)) - t.Log("[DEBUG] expected: ", expected) - assert.Equal(t, expected, string(jsonSchema)) -} +// t.Log("[DEBUG] actual: ", string(jsonSchema)) +// t.Log("[DEBUG] expected: ", expected) +// assert.Equal(t, expected, string(jsonSchema)) +// }