From 43ce278299a71da4f091a820a7d1a31ad22af967 Mon Sep 17 00:00:00 2001 From: Gleb Kanterov Date: Tue, 8 Oct 2024 10:18:52 +0200 Subject: [PATCH] Rename bundle root path --- .../config/mutator/python/python_mutator.go | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/bundle/config/mutator/python/python_mutator.go b/bundle/config/mutator/python/python_mutator.go index 38e23291..e259f372 100644 --- a/bundle/config/mutator/python/python_mutator.go +++ b/bundle/config/mutator/python/python_mutator.go @@ -111,10 +111,10 @@ func (m *pythonMutator) Apply(ctx context.Context, b *bundle.Bundle) diag.Diagno } rightRoot, diags := m.runPythonMutator(ctx, leftRoot, runPythonMutatorOpts{ - cacheDir: cacheDir, - rootPath: b.BundleRootPath, - pythonPath: pythonPath, - loadLocations: experimental.PyDABs.LoadLocations, + cacheDir: cacheDir, + bundleRootPath: b.BundleRootPath, + pythonPath: pythonPath, + loadLocations: experimental.PyDABs.LoadLocations, }) mutateDiags = diags if diags.HasError() { @@ -160,10 +160,10 @@ func createCacheDir(ctx context.Context) (string, error) { } type runPythonMutatorOpts struct { - cacheDir string - rootPath string - pythonPath string - loadLocations bool + cacheDir string + bundleRootPath string + pythonPath string + loadLocations bool } func (m *pythonMutator) runPythonMutator(ctx context.Context, root dyn.Value, opts runPythonMutatorOpts) (dyn.Value, diag.Diagnostics) { @@ -204,7 +204,7 @@ func (m *pythonMutator) runPythonMutator(ctx context.Context, root dyn.Value, op _, processErr := process.Background( ctx, args, - process.WithDir(opts.rootPath), + process.WithDir(opts.bundleRootPath), process.WithStderrWriter(stderrWriter), process.WithStdoutWriter(stdoutWriter), ) @@ -245,7 +245,7 @@ func (m *pythonMutator) runPythonMutator(ctx context.Context, root dyn.Value, op return dyn.InvalidValue, diag.Errorf("failed to load locations: %s", err) } - output, outputDiags := loadOutputFile(opts.rootPath, outputPath, locations) + output, outputDiags := loadOutputFile(opts.bundleRootPath, outputPath, locations) pythonDiagnostics = pythonDiagnostics.Extend(outputDiags) // we pass through pythonDiagnostic because it contains warnings @@ -317,7 +317,7 @@ func loadOutputFile(rootPath string, outputPath string, locations *pythonLocatio // we need absolute path because later parts of pipeline assume all paths are absolute // and this file will be used as location to resolve relative paths. // - // virtualPath has to stay in rootPath, because locations outside root path are not allowed: + // virtualPath has to stay in bundleRootPath, because locations outside root path are not allowed: // // Error: path /var/folders/.../pydabs/dist/*.whl is not contained in bundle root path //