steve/databricks-cli
steve
/
databricks-cli
mirror of https://github.com/databricks/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

todo

This commit is contained in:
Shreyas Goenka 2024-12-03 00:07:14 +01:00
parent 06af01c8f6
commit 4b484fdcdc
No known key found for this signature in database
GPG Key ID: 92A07DF49CCB0622
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libs/filer/dbfs_client.go
View File

@ -167,6 +167,14 @@ func (w *DbfsClient) uploadUsingDbfsStreamingApi(ctx context.Context, path strin
return err return err
} }
// TODO CONTINUE:
// 1. Write the unit tests that make sure the filer write method works correctly
// in either case.
// 2. Write a intergration test that asserts write continues works for big file
// uploads. Also test the overwrite flag in the integration test.
// We can change MaxDbfsUploadLimitForPutApi in the test to avoid creating
// massive test fixtures.
// MaxUploadLimitForPutApi is the maximum size in bytes of a file that can be uploaded // MaxUploadLimitForPutApi is the maximum size in bytes of a file that can be uploaded
// using the /dbfs/put API. If the file is larger than this limit, the streaming // using the /dbfs/put API. If the file is larger than this limit, the streaming
// API (/dbfs/create and /dbfs/add-block) will be used instead. // API (/dbfs/create and /dbfs/add-block) will be used instead.