moved commands to own packages

cmd/fs/fs.go

@@ -1,6 +1,7 @@
-package cmd
+package fs
 
 import (
+	"github.com/databricks/bricks/cmd/root"
 	"github.com/spf13/cobra"
 )
 
@@ -12,7 +13,7 @@ var fsCmd = &cobra.Command{
 }
 
 func init() {
-	rootCmd.AddCommand(fsCmd)
+	root.RootCmd.AddCommand(fsCmd)
 
 	// Here you will define your flags and configuration settings.
 

cmd/fs/ls.go

@@ -1,4 +1,4 @@
-package cmd
+package fs
 
 import (
 	"fmt"
@@ -16,7 +16,7 @@ var lsCmd = &cobra.Command{
 	Long:  `Lists files`,
 	Args:  cobra.ExactArgs(1),
 	Run: func(cmd *cobra.Command, args []string) {
-		api := storage.NewDbfsAPI(cmd.Context(), project.ClientFromContext(cmd.Context()))
+		api := storage.NewDbfsAPI(cmd.Context(), project.Current.Client())
 		files, err := api.List(args[0], false)
 		if err != nil {
 			panic(err)

cmd/launch/launch.go

@@ -1,10 +1,11 @@
-package cmd
+package launch
 
 import (
 	"fmt"
 	"log"
 	"os"
 
+	"github.com/databricks/bricks/cmd/root"
 	"github.com/databricks/bricks/project"
 	"github.com/spf13/cobra"
 )
@@ -29,5 +30,5 @@ var launchCmd = &cobra.Command{
 }
 
 func init() {
-	rootCmd.AddCommand(launchCmd)
+	root.RootCmd.AddCommand(launchCmd)
 }

cmd/root/root.go

@@ -1,4 +1,4 @@
-package cmd
+package root
 
 import (
 	"context"
@@ -6,15 +6,20 @@ import (
 	"os"
 	"strings"
 
-	"github.com/databricks/bricks/project"
 	"github.com/spf13/cobra"
 )
 
-// rootCmd represents the base command when called without any subcommands
+// RootCmd represents the base command when called without any subcommands
-var rootCmd = &cobra.Command{
+var RootCmd = &cobra.Command{
 	Use:   "bricks",
 	Short: "Databricks project lifecycle management",
 	Long:  `Where's "data"? Secured by the unity catalog. Projects build lifecycle is secured by bricks`,
+	PersistentPreRun: func(cmd *cobra.Command, args []string) {
+		if Verbose {
+			logLevel = append(logLevel, "[DEBUG]")
+		}
+		log.SetOutput(&logLevel)
+	},
 	// Uncomment the following line if your bare application
 	// has an action associated with it:
 }
@@ -23,7 +28,9 @@ var rootCmd = &cobra.Command{
 type levelWriter []string
 
 var logLevel = levelWriter{"[INFO]", "[ERROR]", "[WARN]"}
-var verbose bool
+
+// Verbose means additional debug information, like API logs
+var Verbose bool
 
 func (lw *levelWriter) Write(p []byte) (n int, err error) {
 	a := string(p)
@@ -38,17 +45,14 @@ func (lw *levelWriter) Write(p []byte) (n int, err error) {
 // Execute adds all child commands to the root command and sets flags appropriately.
 // This is called by main.main(). It only needs to happen once to the rootCmd.
 func Execute() {
-	if verbose {
+	// TODO: deferred panic recovery
-		logLevel = append(logLevel, "[DEBUG]")
+	ctx := context.Background()
-	}
+	err := RootCmd.ExecuteContext(ctx)
-	ctx := project.Authenticate(context.Background())
-	err := rootCmd.ExecuteContext(ctx)
 	if err != nil {
 		os.Exit(1)
 	}
 }
 
 func init() {
-	rootCmd.PersistentFlags().BoolVarP(&verbose, "verbose", "v", false, "print debug logs")
+	RootCmd.PersistentFlags().BoolVarP(&Verbose, "verbose", "v", false, "print debug logs")
-	log.SetOutput(&logLevel)
 }

cmd/test/test.go

@@ -1,8 +1,9 @@
-package cmd
+package test
 
 import (
 	"log"
 
+	"github.com/databricks/bricks/cmd/root"
 	"github.com/databricks/bricks/project"
 	"github.com/spf13/cobra"
 )
@@ -22,7 +23,7 @@ var testCmd = &cobra.Command{
 }
 
 func init() {
-	rootCmd.AddCommand(testCmd)
+	root.RootCmd.AddCommand(testCmd)
 
 	// Here you will define your flags and configuration settings.