mirror of https://github.com/databricks/cli.git
Limit comment about integration tests to PRs from forks (#2075)
## Changes The comment block appears on all PRs, even if the integration tests are automatically triggered. This is quite noisy. This change limits those comments to PRs from forks. ## Tests Have to try by merging...
This commit is contained in:
parent
ab6b1f1d77
commit
4f3cf6ac2c
|
@ -17,6 +17,10 @@ jobs:
|
||||||
permissions:
|
permissions:
|
||||||
pull-requests: write
|
pull-requests: write
|
||||||
|
|
||||||
|
# Only run this job for PRs from forks.
|
||||||
|
# Integration tests are not run automatically for PRs from forks.
|
||||||
|
if: "${{ github.event.pull_request.head.repo.fork }}"
|
||||||
|
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v4
|
- uses: actions/checkout@v4
|
||||||
|
|
||||||
|
@ -43,7 +47,7 @@ jobs:
|
||||||
run: |
|
run: |
|
||||||
gh pr comment ${{ github.event.pull_request.number }} --body \
|
gh pr comment ${{ github.event.pull_request.number }} --body \
|
||||||
"<!-- INTEGRATION_TESTS_MANUAL -->
|
"<!-- INTEGRATION_TESTS_MANUAL -->
|
||||||
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:
|
An authorized user can trigger integration tests manually by following the instructions below:
|
||||||
|
|
||||||
Trigger:
|
Trigger:
|
||||||
[go/deco-tests-run/cli](https://go/deco-tests-run/cli)
|
[go/deco-tests-run/cli](https://go/deco-tests-run/cli)
|
||||||
|
|
|
@ -5,36 +5,17 @@ on:
|
||||||
types: [opened, synchronize]
|
types: [opened, synchronize]
|
||||||
|
|
||||||
jobs:
|
jobs:
|
||||||
check-token:
|
|
||||||
runs-on: ubuntu-latest
|
|
||||||
environment: "test-trigger-is"
|
|
||||||
|
|
||||||
outputs:
|
|
||||||
has_token: ${{ steps.set-token-status.outputs.has_token }}
|
|
||||||
|
|
||||||
steps:
|
|
||||||
- name: Check if DECO_WORKFLOW_TRIGGER_APP_ID is set
|
|
||||||
id: set-token-status
|
|
||||||
run: |
|
|
||||||
if [ -z "${{ secrets.DECO_WORKFLOW_TRIGGER_APP_ID }}" ]; then
|
|
||||||
echo "DECO_WORKFLOW_TRIGGER_APP_ID is empty. User has no access to secrets."
|
|
||||||
echo "::set-output name=has_token::false"
|
|
||||||
else
|
|
||||||
echo "DECO_WORKFLOW_TRIGGER_APP_ID is set. User has access to secrets."
|
|
||||||
echo "::set-output name=has_token::true"
|
|
||||||
fi
|
|
||||||
|
|
||||||
# Trigger for pull requests.
|
# Trigger for pull requests.
|
||||||
#
|
#
|
||||||
# This workflow triggers the integration test workflow in a different repository.
|
# This workflow triggers the integration test workflow in a different repository.
|
||||||
# It requires secrets from the "test-trigger-is" environment, which are only available to authorized users.
|
# It requires secrets from the "test-trigger-is" environment, which are only available to authorized users.
|
||||||
# It depends on the "check-token" workflow to confirm access to this environment to avoid failures.
|
|
||||||
trigger:
|
trigger:
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
environment: "test-trigger-is"
|
environment: "test-trigger-is"
|
||||||
|
|
||||||
if: needs.check-token.outputs.has_token == 'true'
|
# Only run this job for PRs from branches on the main repository and not from forks.
|
||||||
needs: check-token
|
# Workflows triggered by PRs from forks don't have access to the "test-trigger-is" environment.
|
||||||
|
if: "${{ !github.event.pull_request.head.repo.fork }}"
|
||||||
|
|
||||||
steps:
|
steps:
|
||||||
- name: Generate GitHub App Token
|
- name: Generate GitHub App Token
|
||||||
|
|
Loading…
Reference in New Issue