steve/databricks-cli
steve
/
databricks-cli
mirror of https://github.com/databricks/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

remove test for DetectExecutable(); add test for LookPath(GetExecutable())

This commit is contained in:
Denis Bilenko 2024-12-19 14:29:24 +01:00
parent 21a4cd1128
commit 56785cf555
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libs/python/pythontest/pythontest.go
View File

@ -12,7 +12,6 @@ import (
"testing" "testing"
"github.com/databricks/cli/internal/testutil" "github.com/databricks/cli/internal/testutil"
"github.com/databricks/cli/libs/python"
"github.com/stretchr/testify/require" "github.com/stretchr/testify/require"
) )
@ -108,8 +107,4 @@ func RequireActivatedPythonEnv(t *testing.T, ctx context.Context, opts *VenvOpts
newPath := fmt.Sprintf("%s%c%s", opts.BinPath, os.PathListSeparator, os.Getenv("PATH")) newPath := fmt.Sprintf("%s%c%s", opts.BinPath, os.PathListSeparator, os.Getenv("PATH"))
t.Setenv("PATH", newPath) t.Setenv("PATH", newPath)
pythonExe, err := python.DetectExecutable(ctx)
require.NoError(t, err)
require.Equal(t, filepath.Dir(pythonExe), filepath.Dir(opts.PythonExe))
} }

8
libs/python/pythontest/pythontest_test.go
View File

@ -2,8 +2,11 @@ package pythontest
import ( import (
"context" "context"
"os/exec"
"path/filepath"
"testing" "testing"
"github.com/databricks/cli/libs/python"
"github.com/stretchr/testify/require" "github.com/stretchr/testify/require"
) )
@ -17,6 +20,11 @@ func TestVenvSuccess(t *testing.T) {
require.DirExists(t, opts.EnvPath) require.DirExists(t, opts.EnvPath)
require.DirExists(t, opts.BinPath) require.DirExists(t, opts.BinPath)
require.FileExists(t, opts.PythonExe) require.FileExists(t, opts.PythonExe)
pythonExe, err := exec.LookPath(python.GetExecutable())
require.NoError(t, err)
require.Equal(t, filepath.Dir(pythonExe), filepath.Dir(opts.PythonExe))
require.FileExists(t, pythonExe)
}) })
} }
} }