Address feedback

bundle/deploy/files/upload.go

@@ -12,7 +12,7 @@ import (
 )
 
 type upload struct {
-	outpuHandler sync.OutputHandler
+	outputHandler sync.OutputHandler
 }
 
 func (m *upload) Name() string {
@@ -26,19 +26,18 @@ func (m *upload) Apply(ctx context.Context, b *bundle.Bundle) diag.Diagnostics {
 		return diag.FromErr(err)
 	}
 
-	opts.OutputHandler = m.outpuHandler
+	opts.OutputHandler = m.outputHandler
 	sync, err := sync.New(ctx, *opts)
 	if err != nil {
 		return diag.FromErr(err)
 	}
+	defer sync.Close()
 
 	b.Files, err = sync.RunOnce(ctx)
 	if err != nil {
 		return diag.FromErr(err)
 	}
 
-	sync.Close()
-
 	log.Infof(ctx, "Uploaded bundle files")
 	return nil
 }

cmd/sync/sync.go

@@ -134,6 +134,7 @@ func New() *cobra.Command {
 		if err != nil {
 			return err
 		}
+		defer s.Close()
 
 		if f.watch {
 			err = s.RunContinuous(ctx)
@@ -141,7 +142,6 @@ func New() *cobra.Command {
 			_, err = s.RunOnce(ctx)
 		}
 
-		s.Close()
 		return err
 	}
 

libs/sync/sync.go

@@ -52,9 +52,12 @@ type Sync struct {
 	filer    filer.Filer
 
 	// Synchronization progress events are sent to this event notifier.
-	notifier        EventNotifier
+	notifier EventNotifier
+	seq      int
+
+	// WaitGroup is automatically created when an output handler is provided in the SyncOptions.
+	// Close call is required to ensure the output handler goroutine handles all events in time.
 	outputWaitGroup *stdsync.WaitGroup
-	seq             int
 }
 
 // New initializes and returns a new [Sync] instance.
@@ -140,12 +143,6 @@ func New(ctx context.Context, opts SyncOptions) (*Sync, error) {
 	}, nil
 }
 
-func (s *Sync) Events() <-chan Event {
-	ch := make(chan Event, MaxRequestsInFlight)
-	s.notifier = &ChannelNotifier{ch}
-	return ch
-}
-
 func (s *Sync) Close() {
 	if s.notifier == nil {
 		return