From 5ee4b41cd5bb2a469dbc409d212fe3625bdc7aed Mon Sep 17 00:00:00 2001
From: Miles Yucht <miles@databricks.com>
Date: Tue, 23 Apr 2024 09:17:14 +0200
Subject: [PATCH] Decouple winget release (#1389)

## Changes
We are starting to sign Windows CLI executables, but this has to be done
from a machine with a Yubikey storing the signing certificate for the
immediate future. As such, we will only trigger Winget publishing once
the signed binaries have been uploaded to Github.

Additionally, as an extra precaution, we will only release the signed
binaries via Winget.

## Tests
<!-- How is this tested? -->
---
 .github/workflows/publish-winget.yml | 16 ++++++++++++++++
 .github/workflows/release.yml        | 12 ------------
 2 files changed, 16 insertions(+), 12 deletions(-)
 create mode 100644 .github/workflows/publish-winget.yml

diff --git a/.github/workflows/publish-winget.yml b/.github/workflows/publish-winget.yml
new file mode 100644
index 00000000..19603e66
--- /dev/null
+++ b/.github/workflows/publish-winget.yml
@@ -0,0 +1,16 @@
+name: publish-winget
+
+on:
+  workflow_dispatch:
+
+jobs:
+  publish-to-winget-pkgs:
+    runs-on: windows-latest
+    environment: release
+    steps:
+      - uses: vedantmgoyal2009/winget-releaser@93fd8b606a1672ec3e5c6c3bb19426be68d1a8b0 # https://github.com/vedantmgoyal2009/winget-releaser/releases/tag/v2
+        with:
+          identifier: Databricks.DatabricksCLI
+          installers-regex: 'windows_.*-signed\.zip$' # Only signed Windows releases
+          token: ${{ secrets.ENG_DEV_ECOSYSTEM_BOT_TOKEN }}
+          fork-user: eng-dev-ecosystem-bot
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index f9b4ec15..e09b500f 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -130,15 +130,3 @@ jobs:
                 version: "${{ env.VERSION }}",
               }
             });
-
-  publish-to-winget-pkgs:
-    needs: goreleaser
-    runs-on: windows-latest
-    environment: release
-    steps:
-      - uses: vedantmgoyal2009/winget-releaser@93fd8b606a1672ec3e5c6c3bb19426be68d1a8b0 # https://github.com/vedantmgoyal2009/winget-releaser/releases/tag/v2
-        with:
-          identifier: Databricks.DatabricksCLI
-          installers-regex: 'windows_.*\.zip$' # Only windows releases
-          token: ${{ secrets.ENG_DEV_ECOSYSTEM_BOT_TOKEN }}
-          fork-user: eng-dev-ecosystem-bot