From 60709e3d48a711b931d341196120f4450ee78499 Mon Sep 17 00:00:00 2001
From: Denis Bilenko <denis.bilenko@databricks.com>
Date: Tue, 28 Jan 2025 11:15:32 +0100
Subject: [PATCH] acc: Restore unexpected output error (#2243)

## Changes
Restore original behaviour of acceptance tests: any unaccounted for
files trigger an error (not just those that start with "out"). This got
changed in
https://github.com/databricks/cli/pull/2146/files#diff-2bb968d823f4afb825e1dcea2879bdbdedf2b7c15d4e77f47905691b14246a04L196
which started only checking files starting with "out*" and skipping
everything else.

## Tests
Existing tests.
---
 acceptance/acceptance_test.go                   | 1 +
 acceptance/bundle/git-permerror/script          | 3 ++-
 acceptance/bundle/syncroot/dotdot-git/script    | 4 +++-
 acceptance/bundle/syncroot/dotdot-git/test.toml | 3 +++
 4 files changed, 9 insertions(+), 2 deletions(-)
 create mode 100644 acceptance/bundle/syncroot/dotdot-git/test.toml

diff --git a/acceptance/acceptance_test.go b/acceptance/acceptance_test.go
index 5eb08f674..2d67fb269 100644
--- a/acceptance/acceptance_test.go
+++ b/acceptance/acceptance_test.go
@@ -245,6 +245,7 @@ func runTest(t *testing.T, dir, coverDir string, repls testdiff.ReplacementsCont
 		if _, ok := outputs[relPath]; ok {
 			continue
 		}
+		t.Errorf("Unexpected output: %s", relPath)
 		if strings.HasPrefix(relPath, "out") {
 			// We have a new file starting with "out"
 			// Show the contents & support overwrite mode for it:
diff --git a/acceptance/bundle/git-permerror/script b/acceptance/bundle/git-permerror/script
index 782cbf5bc..3a9b4db24 100644
--- a/acceptance/bundle/git-permerror/script
+++ b/acceptance/bundle/git-permerror/script
@@ -22,4 +22,5 @@ trace chmod 000 .git/config
 errcode trace $CLI bundle validate -o json | jq .bundle.git
 errcode trace withdir subdir/a/b $CLI bundle validate -o json | jq .bundle.git
 
-rm -fr .git
+cd ..
+rm -fr myrepo
diff --git a/acceptance/bundle/syncroot/dotdot-git/script b/acceptance/bundle/syncroot/dotdot-git/script
index 0706a1d5e..278e77101 100644
--- a/acceptance/bundle/syncroot/dotdot-git/script
+++ b/acceptance/bundle/syncroot/dotdot-git/script
@@ -3,4 +3,6 @@ mkdir myrepo
 cd myrepo
 cp ../databricks.yml .
 git-repo-init
-$CLI bundle validate | sed 's/\\\\/\//g'
+errcode $CLI bundle validate
+cd ..
+rm -fr myrepo
diff --git a/acceptance/bundle/syncroot/dotdot-git/test.toml b/acceptance/bundle/syncroot/dotdot-git/test.toml
new file mode 100644
index 000000000..f57f83ee4
--- /dev/null
+++ b/acceptance/bundle/syncroot/dotdot-git/test.toml
@@ -0,0 +1,3 @@
+[[Repls]]
+Old = '\\\\myrepo'
+New = '/myrepo'