steve/databricks-cli
steve
/
databricks-cli
mirror of https://github.com/databricks/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: Validate wheel metadata version and distribution against filename

This commit is contained in:
Denis Bilenko (aider) 2025-03-03 20:50:46 +01:00
parent 19b330be01
commit 613d38d79d
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
libs/patchwheel/patchwheel.go
View File

@ -234,12 +234,26 @@ func PatchWheel(ctx context.Context, path, outputDir string) (string, error) {
return "", err return "", err
} }
// Verify the metadata version and distribution // Verify the metadata version and distribution match what we extracted from filename
metadataVersion, metadataDistribution, err := parseMetadata(metadataContent) metadataVersion, metadataDistribution, err := parseMetadata(metadataContent)
if err != nil { if err != nil {
return "", err return "", err
} }
// log.Infof(ctx, "path=%s version=%s newVersion=%s distribution=%s", path, version, newVersion, distribution)
// Verify that the distribution name in the metadata matches the one from the filename
if metadataDistribution != wheelInfo.Distribution {
return "", fmt.Errorf("distribution name mismatch: %s (metadata) vs %s (filename)",
metadataDistribution, wheelInfo.Distribution)
}
// Verify that the base version in the metadata matches the one from the filename
metadataBaseVersion := strings.SplitN(metadataVersion, "+", 2)[0]
if metadataBaseVersion != baseVersion {
return "", fmt.Errorf("version mismatch: %s (metadata) vs %s (filename)",
metadataBaseVersion, baseVersion)
}
// log.Infof(ctx, "path=%s version=%s newVersion=%s distribution=%s", path, metadataVersion, newVersion, metadataDistribution)
// Patch the METADATA content. // Patch the METADATA content.
newMetadata, err := patchMetadata(metadataContent, newVersion) newMetadata, err := patchMetadata(metadataContent, newVersion)