Include mutator name in logging context (#271)

This commit is contained in:
Pieter Noordhuis 2023-03-22 15:54:10 +01:00 committed by GitHub
parent bfa20cdec9
commit 6850caf2a2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 24 additions and 6 deletions

View File

@ -2,6 +2,8 @@ package bundle
import ( import (
"context" "context"
"github.com/databricks/bricks/libs/log"
) )
// Mutator is the interface type that mutates a bundle's configuration or internal state. // Mutator is the interface type that mutates a bundle's configuration or internal state.
@ -17,17 +19,33 @@ type Mutator interface {
Apply(context.Context, *Bundle) ([]Mutator, error) Apply(context.Context, *Bundle) ([]Mutator, error)
} }
// applyMutator calls apply on the specified mutator given a bundle.
// Any mutators this call returns are applied recursively.
func applyMutator(ctx context.Context, b *Bundle, m Mutator) error {
ctx = log.NewContext(ctx, log.GetLogger(ctx).With("mutator", m.Name()))
log.Debugf(ctx, "Apply")
ms, err := m.Apply(ctx, b)
if err != nil {
log.Errorf(ctx, "Error: %s", err)
return err
}
// Apply recursively.
err = Apply(ctx, b, ms)
if err != nil {
return err
}
return nil
}
func Apply(ctx context.Context, b *Bundle, ms []Mutator) error { func Apply(ctx context.Context, b *Bundle, ms []Mutator) error {
if len(ms) == 0 { if len(ms) == 0 {
return nil return nil
} }
for _, m := range ms { for _, m := range ms {
ms_, err := m.Apply(ctx, b) err := applyMutator(ctx, b, m)
if err != nil {
return err
}
// Apply recursively.
err = Apply(ctx, b, ms_)
if err != nil { if err != nil {
return err return err
} }