From 7084392a0fd2fef882d7bcf9b1327b069f5fc771 Mon Sep 17 00:00:00 2001 From: Shreyas Goenka Date: Tue, 31 Dec 2024 13:40:10 +0530 Subject: [PATCH] cleanup code --- libs/filer/dbfs_client.go | 8 -------- 1 file changed, 8 deletions(-) diff --git a/libs/filer/dbfs_client.go b/libs/filer/dbfs_client.go index eae04921c..fc8c134e2 100644 --- a/libs/filer/dbfs_client.go +++ b/libs/filer/dbfs_client.go @@ -174,14 +174,6 @@ func (w *DbfsClient) streamFile(ctx context.Context, path string, overwrite bool return err } -// TODO CONTINUE: -// 1. Write the unit tests that make sure the filer write method works correctly -// in either case. -// 2. Write a intergration test that asserts write continues works for big file -// uploads. Also test the overwrite flag in the integration test. -// We can change MaxDbfsUploadLimitForPutApi in the test to avoid creating -// massive test fixtures. - // MaxUploadLimitForPutApi is the maximum size in bytes of a file that can be uploaded // using the /dbfs/put API. If the file is larger than this limit, the streaming // API (/dbfs/create and /dbfs/add-block) will be used instead.