From 7a130a3e6e4302e835a19dc281816a31f37ee0d6 Mon Sep 17 00:00:00 2001
From: Pieter Noordhuis <pieter.noordhuis@databricks.com>
Date: Tue, 5 Sep 2023 11:58:45 +0200
Subject: [PATCH] Group permission related commands (#730)

## Changes

Before:
```
Usage:
  databricks instance-pools [command]

Available Commands:
  create                Create a new instance pool.
  delete                Delete an instance pool.
  edit                  Edit an existing instance pool.
  get                   Get instance pool information.
  get-permission-levels Get instance pool permission levels.
  get-permissions       Get instance pool permissions.
  list                  List instance pool info.
  set-permissions       Set instance pool permissions.
  update-permissions    Update instance pool permissions.
```

After:
```
Usage:
  databricks instance-pools [command]

Available Commands
  create                Create a new instance pool.
  delete                Delete an instance pool.
  edit                  Edit an existing instance pool.
  get                   Get instance pool information.
  list                  List instance pool info.

Permission Commands
  get-permission-levels Get instance pool permission levels.
  get-permissions       Get instance pool permissions.
  set-permissions       Set instance pool permissions.
  update-permissions    Update instance pool permissions.
```

## Tests

Manual.
---
 cmd/cmd.go | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/cmd/cmd.go b/cmd/cmd.go
index 04d7cc80..032fde5c 100644
--- a/cmd/cmd.go
+++ b/cmd/cmd.go
@@ -1,6 +1,8 @@
 package cmd
 
 import (
+	"strings"
+
 	"github.com/databricks/cli/cmd/account"
 	"github.com/databricks/cli/cmd/api"
 	"github.com/databricks/cli/cmd/auth"
@@ -14,6 +16,11 @@ import (
 	"github.com/spf13/cobra"
 )
 
+const (
+	mainGroup        = "main"
+	permissionsGroup = "permissions"
+)
+
 func New() *cobra.Command {
 	cli := root.New()
 
@@ -22,6 +29,31 @@ func New() *cobra.Command {
 
 	// Add workspace subcommands.
 	for _, cmd := range workspace.All() {
+		// Built-in groups for the workspace commands.
+		groups := []cobra.Group{
+			{
+				ID:    mainGroup,
+				Title: "Available Commands",
+			},
+			{
+				ID:    permissionsGroup,
+				Title: "Permission Commands",
+			},
+		}
+		for i := range groups {
+			cmd.AddGroup(&groups[i])
+		}
+
+		// Order the permissions subcommands after the main commands.
+		for _, sub := range cmd.Commands() {
+			switch {
+			case strings.HasSuffix(sub.Name(), "-permissions"), strings.HasSuffix(sub.Name(), "-permission-levels"):
+				sub.GroupID = permissionsGroup
+			default:
+				sub.GroupID = mainGroup
+			}
+		}
+
 		cli.AddCommand(cmd)
 	}