From 88015876ad61af6aecd23ce55e0c5fc8c78bf87b Mon Sep 17 00:00:00 2001 From: Shreyas Goenka Date: Mon, 3 Feb 2025 11:42:17 +0100 Subject: [PATCH] pass test --- acceptance/libs/telemetry/upload/out.requests.txt | 2 +- acceptance/libs/telemetry/upload/test.toml | 5 +++++ libs/telemetry/context.go | 4 ++-- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/acceptance/libs/telemetry/upload/out.requests.txt b/acceptance/libs/telemetry/upload/out.requests.txt index cc94a1f31..d6e4aec59 100644 --- a/acceptance/libs/telemetry/upload/out.requests.txt +++ b/acceptance/libs/telemetry/upload/out.requests.txt @@ -1 +1 @@ -{"method":"POST","path":"/telemetry-ext","body":{"uploadTime":1738560432192,"items":[],"protoLogs":["{\"frontend_log_event_id\":\"[UUID]\",\"entry\":{\"databricks_cli_log\":{\"cli_test_event\":{\"name\":\"VALUE1\"}}}}","{\"frontend_log_event_id\":\"[UUID]\",\"entry\":{\"databricks_cli_log\":{\"cli_test_event\":{\"name\":\"VALUE2\"}}}}"]}} +{"method":"POST","path":"/telemetry-ext","body":{"uploadTime":"UNIX_TIME_MILLIS","items":[],"protoLogs":["{\"frontend_log_event_id\":\"[UUID]\",\"entry\":{\"databricks_cli_log\":{\"cli_test_event\":{\"name\":\"VALUE1\"}}}}","{\"frontend_log_event_id\":\"[UUID]\",\"entry\":{\"databricks_cli_log\":{\"cli_test_event\":{\"name\":\"VALUE2\"}}}}"]}} diff --git a/acceptance/libs/telemetry/upload/test.toml b/acceptance/libs/telemetry/upload/test.toml index 2ab4d34a7..6178f2492 100644 --- a/acceptance/libs/telemetry/upload/test.toml +++ b/acceptance/libs/telemetry/upload/test.toml @@ -7,3 +7,8 @@ Response.Body = ''' "numProtoSuccess": 2 } ''' + + +[[Repls]] +Old = '17\d{11}' +New = '"UNIX_TIME_MILLIS"' diff --git a/libs/telemetry/context.go b/libs/telemetry/context.go index 529ad9f6e..e556e462c 100644 --- a/libs/telemetry/context.go +++ b/libs/telemetry/context.go @@ -2,7 +2,7 @@ package telemetry import ( "context" - "fmt" + "errors" ) // Private type to store the telemetry logger in the context @@ -18,7 +18,7 @@ func WithNewLogger(ctx context.Context) context.Context { func fromContext(ctx context.Context) *logger { v := ctx.Value(telemetryLoggerKey) if v == nil { - panic(fmt.Errorf("telemetry logger not found in the context")) + panic(errors.New("telemetry logger not found in the context")) } return v.(*logger)