add tests for the fail case

.github/workflows/push.yml

@@ -114,6 +114,11 @@ jobs:
       - name: Validate bundle schema
         run: |
           go run main.go bundle schema > schema.json
+
           for file in ./bundle/tests/schema/pass/*.yml; do
-            ajv -s schema.json -d $file
+            ajv test -s schema.json -d $file --valid
+          done
+          
+          for file in ./bundle/tests/schema/fail/*.yml; do
+            ajv test -s schema.json -d $file --invalid
           done

bundle/tests/schema/fail/basic.yml

@@ -0,0 +1,3 @@
+bundle:
+  # expected type is 'string'
+  name: 1234

bundle/tests/schema/fail/invalid_enum_value_in_job.yml

@@ -0,0 +1,4 @@
+resources:
+  jobs:
+    myjob:
+      format: INVALID_VALUE

bundle/tests/schema/fail/invalid_enum_value_in_model.yml

@@ -0,0 +1,6 @@
+resources:
+  models:
+    mymodel:
+      latest_versions:
+        - creation_timestamp: 123
+          status: INVALID_VALUE

bundle/tests/schema/fail/invalid_reference_in_job.yml

@@ -0,0 +1,8 @@
+resources:
+  jobs:
+    outer:
+      name: outer job
+      tasks:
+        - task_key: run job task 1
+          run_job_task:
+            job_id: ${invalid.reference}

bundle/tests/schema/fail/invalid_reference_in_model.yml

@@ -0,0 +1,5 @@
+resources:
+  models:
+    mymodel:
+      latest_versions:
+        - creation_timestamp: ${invalid.reference}

bundle/tests/schema/fail/required_field_missing_in_job.yml

@@ -0,0 +1,9 @@
+resources:
+  jobs:
+    foo:
+      name: my job
+      tasks:
+        # All tasks need to have a task_key.
+        - notebook_task:
+            notebook_path: /Users/abc/notebooks/inner
+          existing_cluster_id: abcd

bundle/tests/schema/fail/unknown_field_in_job.yml

@@ -0,0 +1,5 @@
+resources:
+  jobs:
+    myjob:
+      # unknwon fields should cause schema failure.
+      unknown_field: "value"

bundle/tests/schema/fail/unknown_field_in_model.yml

@@ -0,0 +1,6 @@
+resources:
+  models:
+    mymodel:
+      creation_timestamp: 123
+      description: "my model"
+      unknown: "value"

bundle/tests/schema/fail/unknown_top_level_field.yml

@@ -0,0 +1 @@
+unknown: value

bundle/tests/schema/pass/job.yml

@@ -25,12 +25,7 @@ variables:
 
 # TODO: Include enums for fields that are a part of the bundle config in the generate
 # JSON schema.
-# TODO: Are all references allowed for "resources" or just ids?
-# TODO: Ideas for fails:
-# - missing required fields
-# - values of the wrong type
-# - enums with the wrong value
-# - invalid variable references, like not the right format.
+# TODO: No need for pattern overrides for string fields
 
 run_as:
   service_principal_name: myserviceprincipal

bundle/tests/schema/pass/ml.yml

@@ -39,7 +39,7 @@ resources:
   experiments:
     myexperiment:
       artifact_location: /dbfs/myexperiment
-      last_update_time: 123
+      last_update_time: ${var.complexvar.key2}
       lifecycle_stage: ${var.simplevar}
       permissions:
         - service_principal_name: myserviceprincipal