From 97109ec438ab9fd5f25f091e991a8b181d0c5a6b Mon Sep 17 00:00:00 2001 From: "Denis Bilenko (aider)" Date: Mon, 3 Mar 2025 20:58:28 +0100 Subject: [PATCH] test: Modify writeProjectFiles to handle errors internally in tests --- libs/patchwheel/patchwheel_test.go | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/libs/patchwheel/patchwheel_test.go b/libs/patchwheel/patchwheel_test.go index fb483222f..c8bc8f137 100644 --- a/libs/patchwheel/patchwheel_test.go +++ b/libs/patchwheel/patchwheel_test.go @@ -51,17 +51,16 @@ def print_version(): } } -func writeProjectFiles(baseDir string, files map[string]string) error { +func writeProjectFiles(t *testing.T, baseDir string, files map[string]string) { for path, content := range files { fullPath := filepath.Join(baseDir, path) if err := os.MkdirAll(filepath.Dir(fullPath), 0o755); err != nil { - return err + t.Fatalf("Failed to create directory %s: %v", filepath.Dir(fullPath), err) } if err := os.WriteFile(fullPath, []byte(content), 0o644); err != nil { - return err + t.Fatalf("Failed to write file %s: %v", fullPath, err) } } - return nil } func runCmd(t *testing.T, dir, name string, args ...string) { @@ -174,10 +173,7 @@ func TestPatchWheel(t *testing.T) { tempDir := t.TempDir() projFiles := minimalPythonProject() - // AI TODO: modify writeProjectFiles to accept t as first parameter and fail test on errors in internally - if err := writeProjectFiles(tempDir, projFiles); err != nil { - t.Fatal(err) - } + writeProjectFiles(t, tempDir, projFiles) runCmd(t, tempDir, "uv", "venv", "-q", "--python", py)