From 984c38e03ec0b3915ac4d05ff08272ada74f9f6b Mon Sep 17 00:00:00 2001 From: shreyas-goenka <88374338+shreyas-goenka@users.noreply.github.com> Date: Wed, 20 Nov 2024 22:00:10 +0530 Subject: [PATCH] Add unique ID to `root_path` for bundle integration test fixtures (#1917) ## Changes Integration tests using these fixtures could have been flaky when run in parallel using the same user's identity. They would also possibly have piggybacked state from previous runs. This PR adds a UUID to the root_path to force independent bundle deployments for every test run. I have checked that all bundles in `internal/bundle/bundles` have `root_path` namespaced to a UUID. ## Tests Self testing. --- internal/bundle/bundles/empty_bundle/databricks.yml | 2 -- .../bundles/recreate_pipeline/template/databricks.yml.tmpl | 5 ++++- .../bundle/bundles/uc_schema/template/databricks.yml.tmpl | 5 ++++- 3 files changed, 8 insertions(+), 4 deletions(-) delete mode 100644 internal/bundle/bundles/empty_bundle/databricks.yml diff --git a/internal/bundle/bundles/empty_bundle/databricks.yml b/internal/bundle/bundles/empty_bundle/databricks.yml deleted file mode 100644 index efc62782..00000000 --- a/internal/bundle/bundles/empty_bundle/databricks.yml +++ /dev/null @@ -1,2 +0,0 @@ -bundle: - name: abc diff --git a/internal/bundle/bundles/recreate_pipeline/template/databricks.yml.tmpl b/internal/bundle/bundles/recreate_pipeline/template/databricks.yml.tmpl index 10350f13..4ebeb265 100644 --- a/internal/bundle/bundles/recreate_pipeline/template/databricks.yml.tmpl +++ b/internal/bundle/bundles/recreate_pipeline/template/databricks.yml.tmpl @@ -1,5 +1,8 @@ bundle: - name: "bundle-playground" + name: recreate-pipeline + +workspace: + root_path: "~/.bundle/{{.unique_id}}" variables: catalog: diff --git a/internal/bundle/bundles/uc_schema/template/databricks.yml.tmpl b/internal/bundle/bundles/uc_schema/template/databricks.yml.tmpl index 961af25e..15076ac8 100644 --- a/internal/bundle/bundles/uc_schema/template/databricks.yml.tmpl +++ b/internal/bundle/bundles/uc_schema/template/databricks.yml.tmpl @@ -1,5 +1,8 @@ bundle: - name: "bundle-playground" + name: uc-schema + +workspace: + root_path: "~/.bundle/{{.unique_id}}" resources: pipelines: