steve/databricks-cli
steve
/
databricks-cli
mirror of https://github.com/databricks/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make bundle and sync fields optional (#757) 

## Changes
This PR:
1. Makes the bundle and sync properties optional in the generated
schema.
2. Fixes schema generation that was broken due to a rogue "description"
field in the bundle docs.

## Tests
Tested manually. The generated schema no longer has "bundle" and "sync"
marked as required.
This commit is contained in:
shreyas-goenka 2023-09-11 10:16:22 +02:00 committed by GitHub
parent 9e56bed593
commit 9a51f72f0b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bundle/config/root.go
View File

@ -52,7 +52,7 @@ type Root struct {
// Bundle contains details about this bundle, such as its name, // Bundle contains details about this bundle, such as its name,
// version of the spec (TODO), default cluster, default warehouse, etc. // version of the spec (TODO), default cluster, default warehouse, etc.
Bundle Bundle `json:"bundle"` Bundle Bundle `json:"bundle,omitempty"`
// Include specifies a list of patterns of file names to load and // Include specifies a list of patterns of file names to load and
// merge into the this configuration. Only includes defined in the root // merge into the this configuration. Only includes defined in the root
@ -80,7 +80,7 @@ type Root struct {
Environments map[string]*Target `json:"environments,omitempty"` Environments map[string]*Target `json:"environments,omitempty"`
// Sync section specifies options for files synchronization // Sync section specifies options for files synchronization
Sync Sync `json:"sync"` Sync Sync `json:"sync,omitempty"`
// RunAs section allows to define an execution identity for jobs and pipelines runs // RunAs section allows to define an execution identity for jobs and pipelines runs
RunAs *jobs.JobRunAs `json:"run_as,omitempty"` RunAs *jobs.JobRunAs `json:"run_as,omitempty"`

1
bundle/schema/docs/bundle_descriptions.json
View File

@ -1472,7 +1472,6 @@
"config": { "config": {
"description": "The model serving endpoint configuration.", "description": "The model serving endpoint configuration.",
"properties": { "properties": {
"description": "",
"properties": { "properties": {
"served_models": { "served_models": {
"description": "Each block represents a served model for the endpoint to serve. A model serving endpoint can have up to 10 served models.", "description": "Each block represents a served model for the endpoint to serve. A model serving endpoint can have up to 10 served models.",