From a0e6f8f635be24aae2d439368c1f03717dc2c76f Mon Sep 17 00:00:00 2001
From: Shreyas Goenka <shreyas.goenka@databricks.com>
Date: Mon, 24 Feb 2025 15:56:05 +0100
Subject: [PATCH] pull latest

---
 acceptance/telemetry/upload-skipped/out.requests.txt | 0
 acceptance/telemetry/upload-timeout/out.requests.txt | 0
 acceptance/telemetry/upload-timeout/script           | 4 ++--
 cmd/root/root.go                                     | 1 -
 cmd/selftest/selftest.go                             | 1 -
 5 files changed, 2 insertions(+), 4 deletions(-)
 delete mode 100644 acceptance/telemetry/upload-skipped/out.requests.txt
 delete mode 100644 acceptance/telemetry/upload-timeout/out.requests.txt

diff --git a/acceptance/telemetry/upload-skipped/out.requests.txt b/acceptance/telemetry/upload-skipped/out.requests.txt
deleted file mode 100644
index e69de29bb..000000000
diff --git a/acceptance/telemetry/upload-timeout/out.requests.txt b/acceptance/telemetry/upload-timeout/out.requests.txt
deleted file mode 100644
index e69de29bb..000000000
diff --git a/acceptance/telemetry/upload-timeout/script b/acceptance/telemetry/upload-timeout/script
index d81eba279..cef6d5301 100644
--- a/acceptance/telemetry/upload-timeout/script
+++ b/acceptance/telemetry/upload-timeout/script
@@ -1,8 +1,8 @@
 export DATABRICKS_CLI_TELEMETRY_PID_FILE=./telemetry.pid
 export DATABRICKS_CLI_TELEMETRY_UPLOAD_LOGS_FILE=./out.upload_process.txt
 
-# Configure a timeout of 0 seconds. This ensures that the timeout is respected and the
-# telemetry process does not try to upload logs.
+# Configure a timeout of 0 seconds. This test validates that the timeout is respected
+# and the telemetry process does not try to upload logs.
 export DATABRICKS_CLI_TELEMETRY_UPLOAD_TIMEOUT="0s"
 
 trace $CLI selftest send-telemetry
diff --git a/cmd/root/root.go b/cmd/root/root.go
index de92bda98..b366d7dee 100644
--- a/cmd/root/root.go
+++ b/cmd/root/root.go
@@ -176,7 +176,6 @@ func inheritEnvVars() []string {
 	return out
 }
 
-// TODO: Add tests validating the auth resolution in the telemetry worker.
 func uploadTelemetry(ctx context.Context, cmdStr string, start, end time.Time, exitCode int) {
 	// Nothing to upload.
 	if !telemetry.HasLogs(ctx) {
diff --git a/cmd/selftest/selftest.go b/cmd/selftest/selftest.go
index 902ac04a1..64cc562d5 100644
--- a/cmd/selftest/selftest.go
+++ b/cmd/selftest/selftest.go
@@ -11,7 +11,6 @@ func New() *cobra.Command {
 		Hidden: true,
 	}
 
-	// TODO: Run the acceptance tests as integration tests?
 	cmd.AddCommand(newSendTelemetry())
 	return cmd
 }