steve/databricks-cli
steve
/
databricks-cli
mirror of https://github.com/databricks/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

address comments

This commit is contained in:
Shreyas Goenka 2025-01-09 16:34:06 +05:30
parent 2a0dbdec3e
commit a2a3ae7154
No known key found for this signature in database
GPG Key ID: 92A07DF49CCB0622
2 changed files with 42 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libs/template/reader_test.go
View File

@ -23,6 +23,7 @@ func TestBuiltInReader(t *testing.T) {
} }
for _, name := range exists { for _, name := range exists {
t.Run(name, func(t *testing.T) {
r := &builtinReader{name: name} r := &builtinReader{name: name}
fs, err := r.FS(context.Background()) fs, err := r.FS(context.Background())
assert.NoError(t, err) assert.NoError(t, err)
@ -36,14 +37,17 @@ func TestBuiltInReader(t *testing.T) {
require.NoError(t, err) require.NoError(t, err)
assert.Contains(t, string(b), "welcome_message") assert.Contains(t, string(b), "welcome_message")
assert.NoError(t, fd.Close()) assert.NoError(t, fd.Close())
})
} }
t.Run("doesnotexist", func(t *testing.T) {
r := &builtinReader{name: "doesnotexist"} r := &builtinReader{name: "doesnotexist"}
_, err := r.FS(context.Background()) _, err := r.FS(context.Background())
assert.EqualError(t, err, "builtin template doesnotexist not found") assert.EqualError(t, err, "builtin template doesnotexist not found")
// Close should not error. // Close should not error.
assert.NoError(t, r.Close()) assert.NoError(t, r.Close())
})
} }
func TestGitUrlReader(t *testing.T) { func TestGitUrlReader(t *testing.T) {
@ -56,7 +60,7 @@ func TestGitUrlReader(t *testing.T) {
cloneFunc := func(ctx context.Context, url, reference, targetPath string) error { cloneFunc := func(ctx context.Context, url, reference, targetPath string) error {
numCalls++ numCalls++
args = []string{url, reference, targetPath} args = []string{url, reference, targetPath}
err := os.MkdirAll(filepath.Join(targetPath, "a/b/c"), 0o755) err := os.MkdirAll(filepath.Join(targetPath, "a", "b", "c"), 0o755)
require.NoError(t, err) require.NoError(t, err)
testutil.WriteFile(t, filepath.Join(targetPath, "a", "b", "c", "somefile"), "somecontent") testutil.WriteFile(t, filepath.Join(targetPath, "a", "b", "c", "somefile"), "somecontent")
return nil return nil

4
libs/template/resolver_test.go
View File

@ -42,6 +42,7 @@ func TestTemplateResolverForDefaultTemplates(t *testing.T) {
"default-sql", "default-sql",
"dbt-sql", "dbt-sql",
} { } {
t.Run(name, func(t *testing.T) {
r := Resolver{ r := Resolver{
TemplatePathOrUrl: name, TemplatePathOrUrl: name,
} }
@ -51,8 +52,10 @@ func TestTemplateResolverForDefaultTemplates(t *testing.T) {
assert.Equal(t, &builtinReader{name: name}, tmpl.Reader) assert.Equal(t, &builtinReader{name: name}, tmpl.Reader)
assert.IsType(t, &writerWithFullTelemetry{}, tmpl.Writer) assert.IsType(t, &writerWithFullTelemetry{}, tmpl.Writer)
})
} }
t.Run("mlops-stacks", func(t *testing.T) {
r := Resolver{ r := Resolver{
TemplatePathOrUrl: "mlops-stacks", TemplatePathOrUrl: "mlops-stacks",
ConfigFile: "/config/file", ConfigFile: "/config/file",
@ -64,6 +67,7 @@ func TestTemplateResolverForDefaultTemplates(t *testing.T) {
// Assert reader and writer configuration // Assert reader and writer configuration
assert.Equal(t, "https://github.com/databricks/mlops-stacks", tmpl.Reader.(*gitReader).gitUrl) assert.Equal(t, "https://github.com/databricks/mlops-stacks", tmpl.Reader.(*gitReader).gitUrl)
assert.Equal(t, "/config/file", tmpl.Writer.(*writerWithFullTelemetry).configPath) assert.Equal(t, "/config/file", tmpl.Writer.(*writerWithFullTelemetry).configPath)
})
} }
func TestTemplateResolverForCustomUrl(t *testing.T) { func TestTemplateResolverForCustomUrl(t *testing.T) {