This commit is contained in:
Shreyas Goenka 2025-02-17 19:48:58 +01:00
parent 2c7126991b
commit a9ccc3285b
No known key found for this signature in database
GPG Key ID: 92A07DF49CCB0622
2 changed files with 2 additions and 17 deletions

View File

@ -12,22 +12,6 @@ import (
"github.com/spf13/cobra"
)
// TODO CONTINUE:
//
// Ensure that a robust timeout mechanism exists for the telemetry process. We
// do not want the daemons to hang indefinitely. Can this also be tested?
//
// TODO: One set of tests will be asserting that the tests have the right
// properties. A thread on my personal slack account will help with that.
// The other set of tests will assert on the functional behaviour, that the
// parent and child process are indeed indpenedent, and that the child process
// does not block the parent process.
//
// TODO: Make sure to acknowledge the risk of failing when people try to delete
// the binary in windows.
//
// TODO: Ensure that child stdout / stderr are not sent to the parent process.
func newChildCommand() *cobra.Command {
return &cobra.Command{
Use: "child",

3
go.mod
View File

@ -37,6 +37,8 @@ require (
gopkg.in/yaml.v3 v3.0.1
)
require golang.org/x/sys v0.30.0
require (
cloud.google.com/go/auth v0.4.2 // indirect
cloud.google.com/go/auth/oauth2adapt v0.2.2 // indirect
@ -72,7 +74,6 @@ require (
go.opentelemetry.io/otel/trace v1.24.0 // indirect
golang.org/x/crypto v0.31.0 // indirect
golang.org/x/net v0.33.0 // indirect
golang.org/x/sys v0.30.0 // indirect
golang.org/x/time v0.5.0 // indirect
google.golang.org/api v0.182.0 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20240521202816-d264139d666e // indirect