steve/databricks-cli
steve
/
databricks-cli
mirror of https://github.com/databricks/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use -update instead of TESTS_OUTPUT=OVERWRITE (#2097) 

It's easier to remember and type and also validated and part of help:

```
  % go test ./acceptance -updat 2>&1 | grep updat
  flag provided but not defined: -updat
    -update
```
This commit is contained in:
Denis Bilenko 2025-01-09 10:00:05 +01:00 committed by GitHub
parent df17e4b4ea
commit b0706ccdc1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
acceptance/README.md
View File

@ -9,7 +9,7 @@ To author a test,
The test runner will run script and capture output and compare it with `output.txt` file in the same directory. The test runner will run script and capture output and compare it with `output.txt` file in the same directory.
In order to write `output.txt` for the first time or overwrite it with the current output, set `TESTS_OUTPUT=OVERWRITE` env var. In order to write `output.txt` for the first time or overwrite it with the current output pass -update flag to go test.
The scripts are run with `bash -e` so any errors will be propagated. They are captured in `output.txt` by appending `Exit code: N` line at the end. The scripts are run with `bash -e` so any errors will be propagated. They are captured in `output.txt` by appending `Exit code: N` line at the end.

7
libs/testdiff/golden.go
View File

@ -2,6 +2,7 @@ package testdiff
import ( import (
"context" "context"
"flag"
"fmt" "fmt"
"os" "os"
"regexp" "regexp"
@ -16,7 +17,11 @@ import (
"github.com/stretchr/testify/assert" "github.com/stretchr/testify/assert"
) )
var OverwriteMode = os.Getenv("TESTS_OUTPUT") == "OVERWRITE" var OverwriteMode = false
func init() {
flag.BoolVar(&OverwriteMode, "update", false, "Overwrite golden files")
}
func ReadFile(t testutil.TestingT, ctx context.Context, filename string) string { func ReadFile(t testutil.TestingT, ctx context.Context, filename string) string {
t.Helper() t.Helper()