From b64e11304c30cedd1910be7eb3f58f26cbbfc36d Mon Sep 17 00:00:00 2001 From: Pieter Noordhuis Date: Wed, 7 Feb 2024 11:53:50 +0100 Subject: [PATCH] Fix integration test with invalid configuration (#1182) ## Changes The indentation mistake on the `path` field under `notebook` meant the pipeline had a single entry with a `nil` notebook field. This was allowed but incorrect. While working on the `dyn.Value` approach, this yielded a non-nil but zeroed `notebook` field and a failure to translate an empty path. ## Tests Correcting the indentation made the test fail because the file is not a notebook. I changed it to a `file` reference and the test now passes. --- .../deploy_then_remove_resources/template/resources.yml.tmpl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/bundle/bundles/deploy_then_remove_resources/template/resources.yml.tmpl b/internal/bundle/bundles/deploy_then_remove_resources/template/resources.yml.tmpl index b74344e4..e3a67677 100644 --- a/internal/bundle/bundles/deploy_then_remove_resources/template/resources.yml.tmpl +++ b/internal/bundle/bundles/deploy_then_remove_resources/template/resources.yml.tmpl @@ -3,5 +3,5 @@ resources: bar: name: test-bundle-pipeline-{{.unique_id}} libraries: - - notebook: - path: "./foo.py" + - file: + path: "./foo.py"