steve/databricks-cli
steve
/
databricks-cli
mirror of https://github.com/databricks/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Do not fail snapshot destroy if snapshot does not exist (#328) 

## Changes
`bricks bundle destroy` would fail if the sync snapshot did not exist

## Tests
Manually

After:
```
shreyas.goenka@THW32HFW6T bundle-destroy % bricks bundle destroy --auto-approve
No resources to destroy!

Remote directory /Users/shreyas.goenka@databricks.com/.bundle/destroy/default will be deleted
Successfully deleted files!
```

Before:
```
shreyas.goenka@THW32HFW6T bundle-destroy % bricks bundle destroy --auto-approve
No resources to destroy!

Remote directory /Users/shreyas.goenka@databricks.com/.bundle/destroy/default will be deleted
Error: failed to destroy sync snapshot file: remove /Users/shreyas.goenka/projects/bundle-destroy/.databricks/bundle/default/sync-snapshots/a5bd1966cb8980a9.json: no such file or directory
```
This commit is contained in:
shreyas-goenka 2023-04-12 21:37:01 +02:00 committed by GitHub
parent b388f4a0dc
commit bd11da88eb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libs/sync/snapshot.go
View File

@ -128,7 +128,7 @@ func (s *Snapshot) Save(ctx context.Context) error {
func (s *Snapshot) Destroy(ctx context.Context) error { func (s *Snapshot) Destroy(ctx context.Context) error {
err := os.Remove(s.SnapshotPath) err := os.Remove(s.SnapshotPath)
if err != nil { if err != nil && !os.IsNotExist(err) {
return fmt.Errorf("failed to destroy sync snapshot file: %s", err) return fmt.Errorf("failed to destroy sync snapshot file: %s", err)
} }
return nil return nil