address comments

libs/telemetry/api.go

@@ -2,6 +2,7 @@ package telemetry
 
 // RequestBody is the request body type bindings for the /telemetry-ext API endpoint.
 type RequestBody struct {
+	// Timestamp in millis for when the log was uploaded.
 	UploadTime int64 `json:"uploadTime"`
 
 	// DO NOT USE. This is the legacy field for logging in usage logs (not lumberjack).

libs/telemetry/protos/bundle_deploy.go

@@ -21,10 +21,10 @@ type BundleDeployEvent struct {
 	// IDs of resources managed by the bundle. Some resources like volumes or schemas
 	// do not expose a numerical or UUID identifier and are tracked by name. Those
 	// resources are not tracked here since the names are PII.
-	ResourceJobIds       []string `json:"resource_job_ids,omitempty"`
-	ResourcePipelineIds  []string `json:"resource_pipeline_ids,omitempty"`
-	ResourceClusterIds   []string `json:"resource_cluster_ids,omitempty"`
-	ResourceDashboardIds []string `json:"resource_dashboard_ids,omitempty"`
+	ResourceJobIDs       []string `json:"resource_job_ids,omitempty"`
+	ResourcePipelineIDs  []string `json:"resource_pipeline_ids,omitempty"`
+	ResourceClusterIDs   []string `json:"resource_cluster_ids,omitempty"`
+	ResourceDashboardIDs []string `json:"resource_dashboard_ids,omitempty"`
 
 	Experimental *BundleDeployExperimental `json:"experimental,omitempty"`
 }

libs/telemetry/protos/databricks_cli_log.go

@@ -4,7 +4,7 @@ type ExecutionContext struct {
 	// UUID generated by the CLI for every CLI command run. This is also set in the HTTP user
 	// agent under the key "cmd-exec-id" and can be used to correlate frontend_log table
 	// with the http_access_log table.
-	CmdExecId string `json:"cmd_exec_id,omitempty"`
+	CmdExecID string `json:"cmd_exec_id,omitempty"`
 
 	// Version of the Databricks CLI used.
 	Version string `json:"version,omitempty"`

libs/telemetry/protos/frontend_log.go

@@ -3,7 +3,7 @@ package protos
 // This corresponds to the FrontendLog lumberjack proto in universe.
 // FrontendLog is the top-level struct for any client-side logs at Databricks.
 type FrontendLog struct {
-	// A unique identifier for the log event generated from the CLI.
+	// A UUID for the log event generated from the CLI.
 	FrontendLogEventID string `json:"frontend_log_event_id,omitempty"`
 
 	Entry FrontendLogEntry `json:"entry,omitempty"`