address comments

This commit is contained in:
Shreyas Goenka 2025-01-29 12:26:52 +01:00
parent 6423fbb4aa
commit d08cff4842
No known key found for this signature in database
GPG Key ID: 92A07DF49CCB0622
4 changed files with 7 additions and 6 deletions

View File

@ -2,6 +2,7 @@ package telemetry
// RequestBody is the request body type bindings for the /telemetry-ext API endpoint. // RequestBody is the request body type bindings for the /telemetry-ext API endpoint.
type RequestBody struct { type RequestBody struct {
// Timestamp in millis for when the log was uploaded.
UploadTime int64 `json:"uploadTime"` UploadTime int64 `json:"uploadTime"`
// DO NOT USE. This is the legacy field for logging in usage logs (not lumberjack). // DO NOT USE. This is the legacy field for logging in usage logs (not lumberjack).

View File

@ -21,10 +21,10 @@ type BundleDeployEvent struct {
// IDs of resources managed by the bundle. Some resources like volumes or schemas // IDs of resources managed by the bundle. Some resources like volumes or schemas
// do not expose a numerical or UUID identifier and are tracked by name. Those // do not expose a numerical or UUID identifier and are tracked by name. Those
// resources are not tracked here since the names are PII. // resources are not tracked here since the names are PII.
ResourceJobIds []string `json:"resource_job_ids,omitempty"` ResourceJobIDs []string `json:"resource_job_ids,omitempty"`
ResourcePipelineIds []string `json:"resource_pipeline_ids,omitempty"` ResourcePipelineIDs []string `json:"resource_pipeline_ids,omitempty"`
ResourceClusterIds []string `json:"resource_cluster_ids,omitempty"` ResourceClusterIDs []string `json:"resource_cluster_ids,omitempty"`
ResourceDashboardIds []string `json:"resource_dashboard_ids,omitempty"` ResourceDashboardIDs []string `json:"resource_dashboard_ids,omitempty"`
Experimental *BundleDeployExperimental `json:"experimental,omitempty"` Experimental *BundleDeployExperimental `json:"experimental,omitempty"`
} }

View File

@ -4,7 +4,7 @@ type ExecutionContext struct {
// UUID generated by the CLI for every CLI command run. This is also set in the HTTP user // UUID generated by the CLI for every CLI command run. This is also set in the HTTP user
// agent under the key "cmd-exec-id" and can be used to correlate frontend_log table // agent under the key "cmd-exec-id" and can be used to correlate frontend_log table
// with the http_access_log table. // with the http_access_log table.
CmdExecId string `json:"cmd_exec_id,omitempty"` CmdExecID string `json:"cmd_exec_id,omitempty"`
// Version of the Databricks CLI used. // Version of the Databricks CLI used.
Version string `json:"version,omitempty"` Version string `json:"version,omitempty"`

View File

@ -3,7 +3,7 @@ package protos
// This corresponds to the FrontendLog lumberjack proto in universe. // This corresponds to the FrontendLog lumberjack proto in universe.
// FrontendLog is the top-level struct for any client-side logs at Databricks. // FrontendLog is the top-level struct for any client-side logs at Databricks.
type FrontendLog struct { type FrontendLog struct {
// A unique identifier for the log event generated from the CLI. // A UUID for the log event generated from the CLI.
FrontendLogEventID string `json:"frontend_log_event_id,omitempty"` FrontendLogEventID string `json:"frontend_log_event_id,omitempty"`
Entry FrontendLogEntry `json:"entry,omitempty"` Entry FrontendLogEntry `json:"entry,omitempty"`