steve/databricks-cli
steve
/
databricks-cli
mirror of https://github.com/databricks/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add spinner when downloading templates for bundle init (#1188) 

## Changes
Templates can take a long time to download. This PR adds a spinner to
give feedback to users.

## Tests
<!-- How is this tested? -->
Manually


https://github.com/databricks/cli/assets/88374338/b453982c-3233-40f4-8d6f-f31606ff0195
This commit is contained in:
shreyas-goenka 2024-02-08 18:22:53 +05:30 committed by GitHub
parent a835a3e564
commit d638262665
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
cmd/bundle/init.go
View File

@ -191,12 +191,19 @@ See https://docs.databricks.com/en/dev-tools/bundles/templates.html for more inf
if err != nil { if err != nil {
return err return err
} }
// start the spinner
promptSpinner := cmdio.Spinner(ctx)
promptSpinner <- "Downloading the template\n"
// TODO: Add automated test that the downloaded git repo is cleaned up. // TODO: Add automated test that the downloaded git repo is cleaned up.
// Clone the repository in the temporary directory // Clone the repository in the temporary directory
err = git.Clone(ctx, templatePath, ref, repoDir) err = git.Clone(ctx, templatePath, ref, repoDir)
close(promptSpinner)
if err != nil { if err != nil {
return err return err
} }
// Clean up downloaded repository once the template is materialized. // Clean up downloaded repository once the template is materialized.
defer os.RemoveAll(repoDir) defer os.RemoveAll(repoDir)
return template.Materialize(ctx, configFile, filepath.Join(repoDir, templateDir), outputDir) return template.Materialize(ctx, configFile, filepath.Join(repoDir, templateDir), outputDir)