From e24725d230a21baec8a5db4cb088df0e797bdb6a Mon Sep 17 00:00:00 2001
From: Shreyas Goenka <shreyas.goenka@databricks.com>
Date: Tue, 20 Aug 2024 21:06:42 +0200
Subject: [PATCH] added nested tests

---
 libs/jsonschema/from_type.go      |   2 +-
 libs/jsonschema/from_type_test.go | 114 ++++++++++++++++++++++++++++--
 2 files changed, 108 insertions(+), 8 deletions(-)

diff --git a/libs/jsonschema/from_type.go b/libs/jsonschema/from_type.go
index d0e4e2ac..ee29684b 100644
--- a/libs/jsonschema/from_type.go
+++ b/libs/jsonschema/from_type.go
@@ -115,7 +115,7 @@ func (c *constructor) walk(typ reflect.Type) (string, error) {
 
 	// Return value directly if it's already been processed.
 	if _, ok := c.definitions[typPath]; ok {
-		return "", nil
+		return typPath, nil
 	}
 
 	var s Schema
diff --git a/libs/jsonschema/from_type_test.go b/libs/jsonschema/from_type_test.go
index 9ba06ba9..e70e75c4 100644
--- a/libs/jsonschema/from_type_test.go
+++ b/libs/jsonschema/from_type_test.go
@@ -1,7 +1,6 @@
 package jsonschema
 
 import (
-	"encoding/json"
 	"reflect"
 	"testing"
 
@@ -130,14 +129,14 @@ func TestFromTypeBasic(t *testing.T) {
 			assert.NoError(t, err)
 			assert.Equal(t, tc.expected, s)
 
-			jsonSchema, err := json.MarshalIndent(s, "		", "	")
-			assert.NoError(t, err)
+			// jsonSchema, err := json.MarshalIndent(s, "		", "	")
+			// assert.NoError(t, err)
 
-			expectedJson, err := json.MarshalIndent(tc.expected, "		", "	")
-			assert.NoError(t, err)
+			// expectedJson, err := json.MarshalIndent(tc.expected, "		", "	")
+			// assert.NoError(t, err)
 
-			t.Log("[DEBUG] actual: ", string(jsonSchema))
-			t.Log("[DEBUG] expected: ", string(expectedJson))
+			// t.Log("[DEBUG] actual: ", string(jsonSchema))
+			// t.Log("[DEBUG] expected: ", string(expectedJson))
 		})
 	}
 }
@@ -159,3 +158,104 @@ func TestGetStructFields(t *testing.T) {
 	assert.Equal(t, "I", fields[1].Name)
 	assert.Equal(t, "B", fields[2].Name)
 }
+
+func TestFromTypeNested(t *testing.T) {
+	type Inner struct {
+		S string `json:"s"`
+	}
+
+	type Outer struct {
+		I     string `json:"i"`
+		Inner Inner  `json:"inner"`
+	}
+
+	innerRef := "#/$defs/github.com/databricks/cli/libs/jsonschema.Inner"
+	strRef := "#/$defs/string"
+
+	expectedDefinitions := map[string]any{
+		"github.com": map[string]any{
+			"databricks": map[string]any{
+				"cli": map[string]any{
+					"libs": map[string]any{
+						"jsonschema.Inner": Schema{
+							Type: "object",
+							Properties: map[string]*Schema{
+								"s": {
+									Reference: &strRef,
+								},
+							},
+							AdditionalProperties: false,
+							Required:             []string{"s"},
+						},
+					},
+				},
+			},
+		},
+		"string": Schema{
+			Type: "string",
+		},
+	}
+
+	tcases := []struct {
+		name     string
+		typ      reflect.Type
+		expected Schema
+	}{
+		{
+			name: "struct in struct",
+			typ:  reflect.TypeOf(Outer{}),
+			expected: Schema{
+				Type:        "object",
+				Definitions: expectedDefinitions,
+				Properties: map[string]*Schema{
+					"i": {
+						Reference: &strRef,
+					},
+					"inner": {
+						Reference: &innerRef,
+					},
+				},
+				AdditionalProperties: false,
+				Required:             []string{"i", "inner"},
+			},
+		},
+		{
+			name: "struct as a map value",
+			typ:  reflect.TypeOf(map[string]Inner{}),
+			expected: Schema{
+				Type:        "object",
+				Definitions: expectedDefinitions,
+				AdditionalProperties: &Schema{
+					Reference: &innerRef,
+				},
+			},
+		},
+		{
+			name: "struct as a slice element",
+			typ:  reflect.TypeOf([]Inner{}),
+			expected: Schema{
+				Type:        "array",
+				Definitions: expectedDefinitions,
+				Items: &Schema{
+					Reference: &innerRef,
+				},
+			},
+		},
+	}
+	for _, tc := range tcases {
+		t.Run(tc.name, func(t *testing.T) {
+			s, err := FromType(tc.typ, nil)
+			assert.NoError(t, err)
+			assert.Equal(t, tc.expected, s)
+
+			// jsonSchema, err := json.MarshalIndent(s, "		", "	")
+			// assert.NoError(t, err)
+
+			// expectedJson, err := json.MarshalIndent(tc.expected, "		", "	")
+			// assert.NoError(t, err)
+
+			// t.Log("[DEBUG] actual: ", string(jsonSchema))
+			// t.Log("[DEBUG] expected: ", string(expectedJson))
+		})
+	}
+}