mirror of https://github.com/databricks/cli.git
Remove bundle.{Seq,If,Defer,newPhase,logString}, switch to regular functions (#2390)
## Changes - Instead of constructing chains of mutators and then executing them, execute them directly. - Remove functionality related to chain-building: Seq, If, Defer, newPhase, logString. - Phases become functions that apply the changes directly rather than construct mutator chains that will be called later. - Add a helper ApplySeq to call multiple mutators, use it where Apply+Seq were used before. This is intended to be a refactoring without functional changes, but there are a few behaviour changes: - Since defer() is used to call unlock instead of bundle.Defer() unlocking will now happen even in case of panics. - In --debug, the phase names are are still logged once before start of the phase but each entry no longer has 'seq' or phase name in it. - The message "Deployment complete!" was printed even if terraform.Apply() mutator had an error. It no longer does that. ## Motivation The use of the chains was necessary when mutators were returning a list of other mutators instead of calling them directly. But that has since been removed, so now the chain machinery have no purpose anymore. Use of direct functions simplifies the logic and makes bugs more apparent and easy to fix. Other improvements that this unlocks: - Simpler stacktraces/debugging (breakpoints). - Use of functions with narrowly scoped API: instead of mutators that receive full bundle config, we can use focused functions that only deal with sections they care about prepareGitSettings(currentGitSection) -> updatedGitSection. This makes the data flow more apparent. - Parallel computations across mutators (within phase): launch goroutines fetching data from APIs at the beggining, process them once they are ready. ## Tests Existing tests.
This commit is contained in:
Denis Bilenko
GitHub
parent
767c0a9ddb
commit
e2db0cd0e2
|
|
@ -1,81 +1,76 @@
|
|||
10:07:59 Info: start pid=12345 version=[DEV_VERSION] args="[CLI], bundle, validate, --debug"
|
||||
10:07:59 Debug: Found bundle root at [TMPDIR] (file [TMPDIR]/databricks.yml) pid=12345
|
||||
10:07:59 Debug: Apply pid=12345 mutator=load
|
||||
10:07:59 Info: Phase: load pid=12345 mutator=load
|
||||
10:07:59 Debug: Apply pid=12345 mutator=load mutator=seq
|
||||
10:07:59 Debug: Apply pid=12345 mutator=load mutator=seq mutator=EntryPoint
|
||||
10:07:59 Debug: Apply pid=12345 mutator=load mutator=seq mutator=scripts.preinit
|
||||
10:07:59 Debug: No script defined for preinit, skipping pid=12345 mutator=load mutator=seq mutator=scripts.preinit
|
||||
10:07:59 Debug: Apply pid=12345 mutator=load mutator=seq mutator=ProcessRootIncludes
|
||||
10:07:59 Debug: Apply pid=12345 mutator=load mutator=seq mutator=ProcessRootIncludes mutator=seq
|
||||
10:07:59 Debug: Apply pid=12345 mutator=load mutator=seq mutator=VerifyCliVersion
|
||||
10:07:59 Debug: Apply pid=12345 mutator=load mutator=seq mutator=EnvironmentsToTargets
|
||||
10:07:59 Debug: Apply pid=12345 mutator=load mutator=seq mutator=ComputeIdToClusterId
|
||||
10:07:59 Debug: Apply pid=12345 mutator=load mutator=seq mutator=InitializeVariables
|
||||
10:07:59 Debug: Apply pid=12345 mutator=load mutator=seq mutator=DefineDefaultTarget(default)
|
||||
10:07:59 Debug: Apply pid=12345 mutator=load mutator=seq mutator=PythonMutator(load)
|
||||
10:07:59 Debug: Apply pid=12345 mutator=load mutator=seq mutator=validate:unique_resource_keys
|
||||
10:07:59 Debug: Apply pid=12345 mutator=load mutator=seq mutator=SelectDefaultTarget
|
||||
10:07:59 Debug: Apply pid=12345 mutator=load mutator=seq mutator=SelectDefaultTarget mutator=SelectTarget(default)
|
||||
10:07:59 Info: Phase: load pid=12345
|
||||
10:07:59 Debug: Apply pid=12345 mutator=EntryPoint
|
||||
10:07:59 Debug: Apply pid=12345 mutator=scripts.preinit
|
||||
10:07:59 Debug: No script defined for preinit, skipping pid=12345 mutator=scripts.preinit
|
||||
10:07:59 Debug: Apply pid=12345 mutator=ProcessRootIncludes
|
||||
10:07:59 Debug: Apply pid=12345 mutator=VerifyCliVersion
|
||||
10:07:59 Debug: Apply pid=12345 mutator=EnvironmentsToTargets
|
||||
10:07:59 Debug: Apply pid=12345 mutator=ComputeIdToClusterId
|
||||
10:07:59 Debug: Apply pid=12345 mutator=InitializeVariables
|
||||
10:07:59 Debug: Apply pid=12345 mutator=DefineDefaultTarget(default)
|
||||
10:07:59 Debug: Apply pid=12345 mutator=PythonMutator(load)
|
||||
10:07:59 Debug: Apply pid=12345 mutator=validate:unique_resource_keys
|
||||
10:07:59 Debug: Apply pid=12345 mutator=SelectDefaultTarget
|
||||
10:07:59 Debug: Apply pid=12345 mutator=SelectDefaultTarget mutator=SelectTarget(default)
|
||||
10:07:59 Debug: Apply pid=12345 mutator=<func>
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize
|
||||
10:07:59 Info: Phase: initialize pid=12345 mutator=initialize
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=validate:AllResourcesHaveValues
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=RewriteSyncPaths
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=SyncDefaultPath
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=SyncInferRoot
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=PopulateCurrentUser
|
||||
10:07:59 Info: Phase: initialize pid=12345
|
||||
10:07:59 Debug: Apply pid=12345 mutator=validate:AllResourcesHaveValues
|
||||
10:07:59 Debug: Apply pid=12345 mutator=RewriteSyncPaths
|
||||
10:07:59 Debug: Apply pid=12345 mutator=SyncDefaultPath
|
||||
10:07:59 Debug: Apply pid=12345 mutator=SyncInferRoot
|
||||
10:07:59 Debug: Apply pid=12345 mutator=PopulateCurrentUser
|
||||
10:07:59 Debug: GET /api/2.0/preview/scim/v2/Me
|
||||
< HTTP/1.1 200 OK
|
||||
< {
|
||||
< "id": "[USERID]",
|
||||
< "userName": "[USERNAME]"
|
||||
< } pid=12345 mutator=initialize mutator=seq mutator=PopulateCurrentUser sdk=true
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=LoadGitDetails
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=ApplySourceLinkedDeploymentPreset
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=DefineDefaultWorkspaceRoot
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=ExpandWorkspaceRoot
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=DefaultWorkspacePaths
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=PrependWorkspacePrefix
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=RewriteWorkspacePrefix
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=SetVariables
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=PythonMutator(init)
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=PythonMutator(load_resources)
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=PythonMutator(apply_mutators)
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=ResolveVariableReferences
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=ResolveResourceReferences
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=ResolveVariableReferences
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=MergeJobClusters
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=MergeJobParameters
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=MergeJobTasks
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=MergePipelineClusters
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=MergeApps
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=CaptureSchemaDependency
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=CheckPermissions
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=SetRunAs
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=OverrideCompute
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=ConfigureDashboardDefaults
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=ConfigureVolumeDefaults
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=ProcessTargetMode
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=ApplyPresets
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=DefaultQueueing
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=ExpandPipelineGlobPaths
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=ConfigureWSFS
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=TranslatePaths
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=PythonWrapperWarning
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=apps.Validate
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=ValidateSharedRootPermissions
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=ApplyBundlePermissions
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=FilterCurrentUserFromPermissions
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=metadata.AnnotateJobs
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=metadata.AnnotatePipelines
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=terraform.Initialize
|
||||
10:07:59 Debug: Using Terraform from DATABRICKS_TF_EXEC_PATH at [TERRAFORM] pid=12345 mutator=initialize mutator=seq mutator=terraform.Initialize
|
||||
10:07:59 Debug: Using Terraform CLI config from DATABRICKS_TF_CLI_CONFIG_FILE at [DATABRICKS_TF_CLI_CONFIG_FILE] pid=12345 mutator=initialize mutator=seq mutator=terraform.Initialize
|
||||
10:07:59 Debug: Environment variables for Terraform: ...redacted... pid=12345 mutator=initialize mutator=seq mutator=terraform.Initialize
|
||||
10:07:59 Debug: Apply pid=12345 mutator=initialize mutator=seq mutator=scripts.postinit
|
||||
10:07:59 Debug: No script defined for postinit, skipping pid=12345 mutator=initialize mutator=seq mutator=scripts.postinit
|
||||
< } pid=12345 mutator=PopulateCurrentUser sdk=true
|
||||
10:07:59 Debug: Apply pid=12345 mutator=LoadGitDetails
|
||||
10:07:59 Debug: Apply pid=12345 mutator=ApplySourceLinkedDeploymentPreset
|
||||
10:07:59 Debug: Apply pid=12345 mutator=DefineDefaultWorkspaceRoot
|
||||
10:07:59 Debug: Apply pid=12345 mutator=ExpandWorkspaceRoot
|
||||
10:07:59 Debug: Apply pid=12345 mutator=DefaultWorkspacePaths
|
||||
10:07:59 Debug: Apply pid=12345 mutator=PrependWorkspacePrefix
|
||||
10:07:59 Debug: Apply pid=12345 mutator=RewriteWorkspacePrefix
|
||||
10:07:59 Debug: Apply pid=12345 mutator=SetVariables
|
||||
10:07:59 Debug: Apply pid=12345 mutator=PythonMutator(init)
|
||||
10:07:59 Debug: Apply pid=12345 mutator=PythonMutator(load_resources)
|
||||
10:07:59 Debug: Apply pid=12345 mutator=PythonMutator(apply_mutators)
|
||||
10:07:59 Debug: Apply pid=12345 mutator=ResolveVariableReferences
|
||||
10:07:59 Debug: Apply pid=12345 mutator=ResolveResourceReferences
|
||||
10:07:59 Debug: Apply pid=12345 mutator=ResolveVariableReferences
|
||||
10:07:59 Debug: Apply pid=12345 mutator=MergeJobClusters
|
||||
10:07:59 Debug: Apply pid=12345 mutator=MergeJobParameters
|
||||
10:07:59 Debug: Apply pid=12345 mutator=MergeJobTasks
|
||||
10:07:59 Debug: Apply pid=12345 mutator=MergePipelineClusters
|
||||
10:07:59 Debug: Apply pid=12345 mutator=MergeApps
|
||||
10:07:59 Debug: Apply pid=12345 mutator=CaptureSchemaDependency
|
||||
10:07:59 Debug: Apply pid=12345 mutator=CheckPermissions
|
||||
10:07:59 Debug: Apply pid=12345 mutator=SetRunAs
|
||||
10:07:59 Debug: Apply pid=12345 mutator=OverrideCompute
|
||||
10:07:59 Debug: Apply pid=12345 mutator=ConfigureDashboardDefaults
|
||||
10:07:59 Debug: Apply pid=12345 mutator=ConfigureVolumeDefaults
|
||||
10:07:59 Debug: Apply pid=12345 mutator=ProcessTargetMode
|
||||
10:07:59 Debug: Apply pid=12345 mutator=ApplyPresets
|
||||
10:07:59 Debug: Apply pid=12345 mutator=DefaultQueueing
|
||||
10:07:59 Debug: Apply pid=12345 mutator=ExpandPipelineGlobPaths
|
||||
10:07:59 Debug: Apply pid=12345 mutator=ConfigureWSFS
|
||||
10:07:59 Debug: Apply pid=12345 mutator=TranslatePaths
|
||||
10:07:59 Debug: Apply pid=12345 mutator=PythonWrapperWarning
|
||||
10:07:59 Debug: Apply pid=12345 mutator=apps.Validate
|
||||
10:07:59 Debug: Apply pid=12345 mutator=ValidateSharedRootPermissions
|
||||
10:07:59 Debug: Apply pid=12345 mutator=ApplyBundlePermissions
|
||||
10:07:59 Debug: Apply pid=12345 mutator=FilterCurrentUserFromPermissions
|
||||
10:07:59 Debug: Apply pid=12345 mutator=metadata.AnnotateJobs
|
||||
10:07:59 Debug: Apply pid=12345 mutator=metadata.AnnotatePipelines
|
||||
10:07:59 Debug: Apply pid=12345 mutator=terraform.Initialize
|
||||
10:07:59 Debug: Using Terraform from DATABRICKS_TF_EXEC_PATH at [TERRAFORM] pid=12345 mutator=terraform.Initialize
|
||||
10:07:59 Debug: Using Terraform CLI config from DATABRICKS_TF_CLI_CONFIG_FILE at [DATABRICKS_TF_CLI_CONFIG_FILE] pid=12345 mutator=terraform.Initialize
|
||||
10:07:59 Debug: Environment variables for Terraform: ...redacted... pid=12345 mutator=terraform.Initialize
|
||||
10:07:59 Debug: Apply pid=12345 mutator=scripts.postinit
|
||||
10:07:59 Debug: No script defined for postinit, skipping pid=12345 mutator=scripts.postinit
|
||||
10:07:59 Debug: Apply pid=12345 mutator=validate
|
||||
10:07:59 Debug: GET /api/2.0/workspace/get-status?path=/Workspace/Users/[USERNAME]/.bundle/debug/default/files
|
||||
< HTTP/1.1 404 Not Found
|
||||
|
|
|
|||
|
|
@ -70,6 +70,6 @@ env:
|
|||
|
||||
bundletest.SetLocation(b, ".", []dyn.Location{{File: filepath.Join(root, "databricks.yml")}})
|
||||
|
||||
diags := bundle.Apply(context.Background(), b, bundle.Seq(mutator.TranslatePaths(), &u))
|
||||
diags := bundle.ApplySeq(context.Background(), b, mutator.TranslatePaths(), &u)
|
||||
require.NoError(t, diags.Error())
|
||||
}
|
||||
|
|
|
|||
|
|
@ -51,7 +51,7 @@ func TestAppsValidate(t *testing.T) {
|
|||
|
||||
bundletest.SetLocation(b, ".", []dyn.Location{{File: filepath.Join(tmpDir, "databricks.yml")}})
|
||||
|
||||
diags := bundle.Apply(context.Background(), b, bundle.Seq(mutator.TranslatePaths(), Validate()))
|
||||
diags := bundle.ApplySeq(context.Background(), b, mutator.TranslatePaths(), Validate())
|
||||
require.Len(t, diags, 1)
|
||||
require.Equal(t, "app.yml detected", diags[0].Summary)
|
||||
require.Contains(t, diags[0].Detail, "app.yml and use 'config' property for app resource")
|
||||
|
|
@ -90,7 +90,7 @@ func TestAppsValidateSameSourcePath(t *testing.T) {
|
|||
|
||||
bundletest.SetLocation(b, ".", []dyn.Location{{File: filepath.Join(tmpDir, "databricks.yml")}})
|
||||
|
||||
diags := bundle.Apply(context.Background(), b, bundle.Seq(mutator.TranslatePaths(), Validate()))
|
||||
diags := bundle.ApplySeq(context.Background(), b, mutator.TranslatePaths(), Validate())
|
||||
require.Len(t, diags, 1)
|
||||
require.Equal(t, "Duplicate app source code path", diags[0].Summary)
|
||||
require.Contains(t, diags[0].Detail, "has the same source code path as app resource")
|
||||
|
|
|
|||
|
|
@ -38,5 +38,5 @@ func (m *all) Apply(ctx context.Context, b *bundle.Bundle) diag.Diagnostics {
|
|||
}
|
||||
}
|
||||
|
||||
return bundle.Apply(ctx, b, bundle.Seq(out...))
|
||||
return bundle.ApplySeq(ctx, b, out...)
|
||||
}
|
||||
|
|
|
|||
|
|
@ -53,5 +53,5 @@ func (m *build) Apply(ctx context.Context, b *bundle.Bundle) diag.Diagnostics {
|
|||
// if we do it before, any files that are generated by build command will
|
||||
// not be included into artifact.Files and thus will not be uploaded.
|
||||
mutators = append(mutators, &expandGlobs{name: m.name})
|
||||
return bundle.Apply(ctx, b, bundle.Seq(mutators...))
|
||||
return bundle.ApplySeq(ctx, b, mutators...)
|
||||
}
|
||||
|
|
|
|||
|
|
@ -39,11 +39,11 @@ func TestExpandGlobs_Nominal(t *testing.T) {
|
|||
bundletest.SetLocation(b, "artifacts", []dyn.Location{{File: filepath.Join(tmpDir, "databricks.yml")}})
|
||||
|
||||
ctx := context.Background()
|
||||
diags := bundle.Apply(ctx, b, bundle.Seq(
|
||||
diags := bundle.ApplySeq(ctx, b,
|
||||
// Run prepare first to make paths absolute.
|
||||
&prepare{"test"},
|
||||
&expandGlobs{"test"},
|
||||
))
|
||||
)
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
// Assert that the expanded paths are correct.
|
||||
|
|
@ -80,11 +80,11 @@ func TestExpandGlobs_InvalidPattern(t *testing.T) {
|
|||
bundletest.SetLocation(b, "artifacts", []dyn.Location{{File: filepath.Join(tmpDir, "databricks.yml")}})
|
||||
|
||||
ctx := context.Background()
|
||||
diags := bundle.Apply(ctx, b, bundle.Seq(
|
||||
diags := bundle.ApplySeq(ctx, b,
|
||||
// Run prepare first to make paths absolute.
|
||||
&prepare{"test"},
|
||||
&expandGlobs{"test"},
|
||||
))
|
||||
)
|
||||
|
||||
assert.Len(t, diags, 4)
|
||||
assert.Equal(t, filepath.Clean("a[.txt")+": syntax error in pattern", diags[0].Summary)
|
||||
|
|
@ -128,11 +128,11 @@ func TestExpandGlobs_NoMatches(t *testing.T) {
|
|||
bundletest.SetLocation(b, "artifacts", []dyn.Location{{File: filepath.Join(tmpDir, "databricks.yml")}})
|
||||
|
||||
ctx := context.Background()
|
||||
diags := bundle.Apply(ctx, b, bundle.Seq(
|
||||
diags := bundle.ApplySeq(ctx, b,
|
||||
// Run prepare first to make paths absolute.
|
||||
&prepare{"test"},
|
||||
&expandGlobs{"test"},
|
||||
))
|
||||
)
|
||||
|
||||
assert.Len(t, diags, 2)
|
||||
assert.Equal(t, "c*.txt: no matching files", diags[0].Summary)
|
||||
|
|
|
|||
|
|
@ -98,5 +98,5 @@ func (m *processRootIncludes) Apply(ctx context.Context, b *bundle.Bundle) diag.
|
|||
// Swap out the original includes list with the expanded globs.
|
||||
b.Config.Include = files
|
||||
|
||||
return bundle.Apply(ctx, b, bundle.Seq(out...))
|
||||
return bundle.ApplySeq(ctx, b, out...)
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1,16 +1,19 @@
|
|||
package mutator
|
||||
|
||||
import (
|
||||
"context"
|
||||
|
||||
"github.com/databricks/cli/bundle"
|
||||
"github.com/databricks/cli/bundle/config"
|
||||
"github.com/databricks/cli/bundle/config/loader"
|
||||
pythonmutator "github.com/databricks/cli/bundle/config/mutator/python"
|
||||
"github.com/databricks/cli/bundle/config/validate"
|
||||
"github.com/databricks/cli/bundle/scripts"
|
||||
"github.com/databricks/cli/libs/diag"
|
||||
)
|
||||
|
||||
func DefaultMutators() []bundle.Mutator {
|
||||
return []bundle.Mutator{
|
||||
func DefaultMutators(ctx context.Context, b *bundle.Bundle) diag.Diagnostics {
|
||||
return bundle.ApplySeq(ctx, b,
|
||||
loader.EntryPoint(),
|
||||
|
||||
// Execute preinit script before processing includes.
|
||||
|
|
@ -31,5 +34,5 @@ func DefaultMutators() []bundle.Mutator {
|
|||
// Note: This mutator must run before the target overrides are merged.
|
||||
// See the mutator for more details.
|
||||
validate.UniqueResourceKeys(),
|
||||
}
|
||||
)
|
||||
}
|
||||
|
|
|
|||
|
|
@ -80,7 +80,7 @@ func TestPrependWorkspaceForDefaultConfig(t *testing.T) {
|
|||
},
|
||||
},
|
||||
}
|
||||
diags := bundle.Apply(context.Background(), b, bundle.Seq(DefineDefaultWorkspaceRoot(), ExpandWorkspaceRoot(), DefineDefaultWorkspacePaths(), PrependWorkspacePrefix()))
|
||||
diags := bundle.ApplySeq(context.Background(), b, DefineDefaultWorkspaceRoot(), ExpandWorkspaceRoot(), DefineDefaultWorkspacePaths(), PrependWorkspacePrefix())
|
||||
require.Empty(t, diags)
|
||||
require.Equal(t, "/Workspace/Users/jane@doe.com/.bundle/test/dev", b.Config.Workspace.RootPath)
|
||||
require.Equal(t, "/Workspace/Users/jane@doe.com/.bundle/test/dev/artifacts", b.Config.Workspace.ArtifactPath)
|
||||
|
|
|
|||
|
|
@ -163,8 +163,7 @@ func mockBundle(mode config.Mode) *bundle.Bundle {
|
|||
func TestProcessTargetModeDevelopment(t *testing.T) {
|
||||
b := mockBundle(config.Development)
|
||||
|
||||
m := bundle.Seq(ProcessTargetMode(), ApplyPresets())
|
||||
diags := bundle.Apply(context.Background(), b, m)
|
||||
diags := bundle.ApplySeq(context.Background(), b, ProcessTargetMode(), ApplyPresets())
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
// Job 1
|
||||
|
|
@ -224,8 +223,7 @@ func TestProcessTargetModeDevelopmentTagNormalizationForAws(t *testing.T) {
|
|||
})
|
||||
|
||||
b.Config.Workspace.CurrentUser.ShortName = "Héllö wörld?!"
|
||||
m := bundle.Seq(ProcessTargetMode(), ApplyPresets())
|
||||
diags := bundle.Apply(context.Background(), b, m)
|
||||
diags := bundle.ApplySeq(context.Background(), b, ProcessTargetMode(), ApplyPresets())
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
// Assert that tag normalization took place.
|
||||
|
|
@ -239,8 +237,7 @@ func TestProcessTargetModeDevelopmentTagNormalizationForAzure(t *testing.T) {
|
|||
})
|
||||
|
||||
b.Config.Workspace.CurrentUser.ShortName = "Héllö wörld?!"
|
||||
m := bundle.Seq(ProcessTargetMode(), ApplyPresets())
|
||||
diags := bundle.Apply(context.Background(), b, m)
|
||||
diags := bundle.ApplySeq(context.Background(), b, ProcessTargetMode(), ApplyPresets())
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
// Assert that tag normalization took place (Azure allows more characters than AWS).
|
||||
|
|
@ -254,8 +251,7 @@ func TestProcessTargetModeDevelopmentTagNormalizationForGcp(t *testing.T) {
|
|||
})
|
||||
|
||||
b.Config.Workspace.CurrentUser.ShortName = "Héllö wörld?!"
|
||||
m := bundle.Seq(ProcessTargetMode(), ApplyPresets())
|
||||
diags := bundle.Apply(context.Background(), b, m)
|
||||
diags := bundle.ApplySeq(context.Background(), b, ProcessTargetMode(), ApplyPresets())
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
// Assert that tag normalization took place.
|
||||
|
|
@ -311,8 +307,7 @@ func TestValidateDevelopmentMode(t *testing.T) {
|
|||
func TestProcessTargetModeDefault(t *testing.T) {
|
||||
b := mockBundle("")
|
||||
|
||||
m := bundle.Seq(ProcessTargetMode(), ApplyPresets())
|
||||
diags := bundle.Apply(context.Background(), b, m)
|
||||
diags := bundle.ApplySeq(context.Background(), b, ProcessTargetMode(), ApplyPresets())
|
||||
require.NoError(t, diags.Error())
|
||||
assert.Equal(t, "job1", b.Config.Resources.Jobs["job1"].Name)
|
||||
assert.Equal(t, "pipeline1", b.Config.Resources.Pipelines["pipeline1"].Name)
|
||||
|
|
@ -429,8 +424,7 @@ func TestAllNonUcResourcesAreRenamed(t *testing.T) {
|
|||
reflect.TypeOf(&resources.Volume{}),
|
||||
}
|
||||
|
||||
m := bundle.Seq(ProcessTargetMode(), ApplyPresets())
|
||||
diags := bundle.Apply(context.Background(), b, m)
|
||||
diags := bundle.ApplySeq(context.Background(), b, ProcessTargetMode(), ApplyPresets())
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
resources := reflect.ValueOf(b.Config.Resources)
|
||||
|
|
@ -484,8 +478,7 @@ func TestPrefixAlreadySet(t *testing.T) {
|
|||
b := mockBundle(config.Development)
|
||||
b.Config.Presets.NamePrefix = "custom_lennart_deploy_"
|
||||
|
||||
m := bundle.Seq(ProcessTargetMode(), ApplyPresets())
|
||||
diags := bundle.Apply(context.Background(), b, m)
|
||||
diags := bundle.ApplySeq(context.Background(), b, ProcessTargetMode(), ApplyPresets())
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
assert.Equal(t, "custom_lennart_deploy_job1", b.Config.Resources.Jobs["job1"].Name)
|
||||
|
|
@ -498,8 +491,7 @@ func TestTagsAlreadySet(t *testing.T) {
|
|||
"dev": "foo",
|
||||
}
|
||||
|
||||
m := bundle.Seq(ProcessTargetMode(), ApplyPresets())
|
||||
diags := bundle.Apply(context.Background(), b, m)
|
||||
diags := bundle.ApplySeq(context.Background(), b, ProcessTargetMode(), ApplyPresets())
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
assert.Equal(t, "tag", b.Config.Resources.Jobs["job1"].Tags["custom"])
|
||||
|
|
@ -510,8 +502,7 @@ func TestTagsNil(t *testing.T) {
|
|||
b := mockBundle(config.Development)
|
||||
b.Config.Presets.Tags = nil
|
||||
|
||||
m := bundle.Seq(ProcessTargetMode(), ApplyPresets())
|
||||
diags := bundle.Apply(context.Background(), b, m)
|
||||
diags := bundle.ApplySeq(context.Background(), b, ProcessTargetMode(), ApplyPresets())
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
assert.Equal(t, "lennart", b.Config.Resources.Jobs["job2"].Tags["dev"])
|
||||
|
|
@ -521,8 +512,7 @@ func TestTagsEmptySet(t *testing.T) {
|
|||
b := mockBundle(config.Development)
|
||||
b.Config.Presets.Tags = map[string]string{}
|
||||
|
||||
m := bundle.Seq(ProcessTargetMode(), ApplyPresets())
|
||||
diags := bundle.Apply(context.Background(), b, m)
|
||||
diags := bundle.ApplySeq(context.Background(), b, ProcessTargetMode(), ApplyPresets())
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
assert.Equal(t, "lennart", b.Config.Resources.Jobs["job2"].Tags["dev"])
|
||||
|
|
@ -532,8 +522,7 @@ func TestJobsMaxConcurrentRunsAlreadySet(t *testing.T) {
|
|||
b := mockBundle(config.Development)
|
||||
b.Config.Presets.JobsMaxConcurrentRuns = 10
|
||||
|
||||
m := bundle.Seq(ProcessTargetMode(), ApplyPresets())
|
||||
diags := bundle.Apply(context.Background(), b, m)
|
||||
diags := bundle.ApplySeq(context.Background(), b, ProcessTargetMode(), ApplyPresets())
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
assert.Equal(t, 10, b.Config.Resources.Jobs["job1"].MaxConcurrentRuns)
|
||||
|
|
@ -543,8 +532,7 @@ func TestJobsMaxConcurrentRunsDisabled(t *testing.T) {
|
|||
b := mockBundle(config.Development)
|
||||
b.Config.Presets.JobsMaxConcurrentRuns = 1
|
||||
|
||||
m := bundle.Seq(ProcessTargetMode(), ApplyPresets())
|
||||
diags := bundle.Apply(context.Background(), b, m)
|
||||
diags := bundle.ApplySeq(context.Background(), b, ProcessTargetMode(), ApplyPresets())
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
assert.Equal(t, 1, b.Config.Resources.Jobs["job1"].MaxConcurrentRuns)
|
||||
|
|
@ -554,8 +542,7 @@ func TestTriggerPauseStatusWhenUnpaused(t *testing.T) {
|
|||
b := mockBundle(config.Development)
|
||||
b.Config.Presets.TriggerPauseStatus = config.Unpaused
|
||||
|
||||
m := bundle.Seq(ProcessTargetMode(), ApplyPresets())
|
||||
diags := bundle.Apply(context.Background(), b, m)
|
||||
diags := bundle.ApplySeq(context.Background(), b, ProcessTargetMode(), ApplyPresets())
|
||||
require.ErrorContains(t, diags.Error(), "target with 'mode: development' cannot set trigger pause status to UNPAUSED by default")
|
||||
}
|
||||
|
||||
|
|
@ -564,8 +551,7 @@ func TestPipelinesDevelopmentDisabled(t *testing.T) {
|
|||
notEnabled := false
|
||||
b.Config.Presets.PipelinesDevelopment = ¬Enabled
|
||||
|
||||
m := bundle.Seq(ProcessTargetMode(), ApplyPresets())
|
||||
diags := bundle.Apply(context.Background(), b, m)
|
||||
diags := bundle.ApplySeq(context.Background(), b, ProcessTargetMode(), ApplyPresets())
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
assert.False(t, b.Config.Resources.Pipelines["pipeline1"].CreatePipeline.Development)
|
||||
|
|
|
|||
|
|
@ -176,7 +176,7 @@ func TestResolveVariableReferencesInVariableLookups(t *testing.T) {
|
|||
{ClusterId: "9876-5432-xywz", ClusterName: "some other cluster"},
|
||||
}, nil)
|
||||
|
||||
diags := bundle.Apply(context.Background(), b, bundle.Seq(ResolveVariableReferencesInLookup(), ResolveResourceReferences()))
|
||||
diags := bundle.ApplySeq(context.Background(), b, ResolveVariableReferencesInLookup(), ResolveResourceReferences())
|
||||
require.NoError(t, diags.Error())
|
||||
require.Equal(t, "cluster-bar-dev", b.Config.Variables["lookup"].Lookup.Cluster)
|
||||
require.Equal(t, "1234-5678-abcd", b.Config.Variables["lookup"].Value)
|
||||
|
|
@ -203,7 +203,7 @@ func TestResolveLookupVariableReferencesInVariableLookups(t *testing.T) {
|
|||
m := mocks.NewMockWorkspaceClient(t)
|
||||
b.SetWorkpaceClient(m.WorkspaceClient)
|
||||
|
||||
diags := bundle.Apply(context.Background(), b, bundle.Seq(ResolveVariableReferencesInLookup(), ResolveResourceReferences()))
|
||||
diags := bundle.ApplySeq(context.Background(), b, ResolveVariableReferencesInLookup(), ResolveResourceReferences())
|
||||
require.ErrorContains(t, diags.Error(), "lookup variables cannot contain references to another lookup variables")
|
||||
}
|
||||
|
||||
|
|
@ -229,7 +229,7 @@ func TestNoResolveLookupIfVariableSetWithEnvVariable(t *testing.T) {
|
|||
ctx := context.Background()
|
||||
ctx = env.Set(ctx, "BUNDLE_VAR_lookup", "1234-5678-abcd")
|
||||
|
||||
diags := bundle.Apply(ctx, b, bundle.Seq(SetVariables(), ResolveVariableReferencesInLookup(), ResolveResourceReferences()))
|
||||
diags := bundle.ApplySeq(ctx, b, SetVariables(), ResolveVariableReferencesInLookup(), ResolveResourceReferences())
|
||||
require.NoError(t, diags.Error())
|
||||
require.Equal(t, "1234-5678-abcd", b.Config.Variables["lookup"].Value)
|
||||
}
|
||||
|
|
|
|||
|
|
@ -828,12 +828,10 @@ func TestTranslatePathWithComplexVariables(t *testing.T) {
|
|||
})
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
diags = bundle.Apply(ctx, b,
|
||||
bundle.Seq(
|
||||
diags = bundle.ApplySeq(ctx, b,
|
||||
mutator.SetVariables(),
|
||||
mutator.ResolveVariableReferences("variables"),
|
||||
mutator.TranslatePaths(),
|
||||
))
|
||||
mutator.TranslatePaths())
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
assert.Equal(
|
||||
|
|
|
|||
|
|
@ -1,30 +0,0 @@
|
|||
package bundle
|
||||
|
||||
import (
|
||||
"context"
|
||||
|
||||
"github.com/databricks/cli/libs/diag"
|
||||
)
|
||||
|
||||
type DeferredMutator struct {
|
||||
mutator Mutator
|
||||
finally Mutator
|
||||
}
|
||||
|
||||
func (d *DeferredMutator) Name() string {
|
||||
return "deferred"
|
||||
}
|
||||
|
||||
func Defer(mutator, finally Mutator) Mutator {
|
||||
return &DeferredMutator{
|
||||
mutator: mutator,
|
||||
finally: finally,
|
||||
}
|
||||
}
|
||||
|
||||
func (d *DeferredMutator) Apply(ctx context.Context, b *Bundle) diag.Diagnostics {
|
||||
var diags diag.Diagnostics
|
||||
diags = diags.Extend(Apply(ctx, b, d.mutator))
|
||||
diags = diags.Extend(Apply(ctx, b, d.finally))
|
||||
return diags
|
||||
}
|
||||
|
|
@ -1,114 +0,0 @@
|
|||
package bundle
|
||||
|
||||
import (
|
||||
"context"
|
||||
"testing"
|
||||
|
||||
"github.com/databricks/cli/libs/diag"
|
||||
"github.com/stretchr/testify/assert"
|
||||
)
|
||||
|
||||
type mutatorWithError struct {
|
||||
applyCalled int
|
||||
errorMsg string
|
||||
}
|
||||
|
||||
func (t *mutatorWithError) Name() string {
|
||||
return "mutatorWithError"
|
||||
}
|
||||
|
||||
func (t *mutatorWithError) Apply(_ context.Context, b *Bundle) diag.Diagnostics {
|
||||
t.applyCalled++
|
||||
return diag.Errorf(t.errorMsg) // nolint:govet
|
||||
}
|
||||
|
||||
func TestDeferredMutatorWhenAllMutatorsSucceed(t *testing.T) {
|
||||
m1 := &testMutator{}
|
||||
m2 := &testMutator{}
|
||||
m3 := &testMutator{}
|
||||
cleanup := &testMutator{}
|
||||
deferredMutator := Defer(Seq(m1, m2, m3), cleanup)
|
||||
|
||||
b := &Bundle{}
|
||||
diags := Apply(context.Background(), b, deferredMutator)
|
||||
assert.NoError(t, diags.Error())
|
||||
|
||||
assert.Equal(t, 1, m1.applyCalled)
|
||||
assert.Equal(t, 1, m2.applyCalled)
|
||||
assert.Equal(t, 1, m3.applyCalled)
|
||||
assert.Equal(t, 1, cleanup.applyCalled)
|
||||
}
|
||||
|
||||
func TestDeferredMutatorWhenFirstFails(t *testing.T) {
|
||||
m1 := &testMutator{}
|
||||
m2 := &testMutator{}
|
||||
mErr := &mutatorWithError{errorMsg: "mutator error occurred"}
|
||||
cleanup := &testMutator{}
|
||||
deferredMutator := Defer(Seq(mErr, m1, m2), cleanup)
|
||||
|
||||
b := &Bundle{}
|
||||
diags := Apply(context.Background(), b, deferredMutator)
|
||||
assert.ErrorContains(t, diags.Error(), "mutator error occurred")
|
||||
|
||||
assert.Equal(t, 1, mErr.applyCalled)
|
||||
assert.Equal(t, 0, m1.applyCalled)
|
||||
assert.Equal(t, 0, m2.applyCalled)
|
||||
assert.Equal(t, 1, cleanup.applyCalled)
|
||||
}
|
||||
|
||||
func TestDeferredMutatorWhenMiddleOneFails(t *testing.T) {
|
||||
m1 := &testMutator{}
|
||||
m2 := &testMutator{}
|
||||
mErr := &mutatorWithError{errorMsg: "mutator error occurred"}
|
||||
cleanup := &testMutator{}
|
||||
deferredMutator := Defer(Seq(m1, mErr, m2), cleanup)
|
||||
|
||||
b := &Bundle{}
|
||||
diags := Apply(context.Background(), b, deferredMutator)
|
||||
assert.ErrorContains(t, diags.Error(), "mutator error occurred")
|
||||
|
||||
assert.Equal(t, 1, m1.applyCalled)
|
||||
assert.Equal(t, 1, mErr.applyCalled)
|
||||
assert.Equal(t, 0, m2.applyCalled)
|
||||
assert.Equal(t, 1, cleanup.applyCalled)
|
||||
}
|
||||
|
||||
func TestDeferredMutatorWhenLastOneFails(t *testing.T) {
|
||||
m1 := &testMutator{}
|
||||
m2 := &testMutator{}
|
||||
mErr := &mutatorWithError{errorMsg: "mutator error occurred"}
|
||||
cleanup := &testMutator{}
|
||||
deferredMutator := Defer(Seq(m1, m2, mErr), cleanup)
|
||||
|
||||
b := &Bundle{}
|
||||
diags := Apply(context.Background(), b, deferredMutator)
|
||||
assert.ErrorContains(t, diags.Error(), "mutator error occurred")
|
||||
|
||||
assert.Equal(t, 1, m1.applyCalled)
|
||||
assert.Equal(t, 1, m2.applyCalled)
|
||||
assert.Equal(t, 1, mErr.applyCalled)
|
||||
assert.Equal(t, 1, cleanup.applyCalled)
|
||||
}
|
||||
|
||||
func TestDeferredMutatorCombinesErrorMessages(t *testing.T) {
|
||||
m1 := &testMutator{}
|
||||
m2 := &testMutator{}
|
||||
mErr := &mutatorWithError{errorMsg: "mutator error occurred"}
|
||||
cleanupErr := &mutatorWithError{errorMsg: "cleanup error occurred"}
|
||||
deferredMutator := Defer(Seq(m1, m2, mErr), cleanupErr)
|
||||
|
||||
b := &Bundle{}
|
||||
diags := Apply(context.Background(), b, deferredMutator)
|
||||
|
||||
var errs []string
|
||||
for _, d := range diags {
|
||||
errs = append(errs, d.Summary)
|
||||
}
|
||||
assert.Contains(t, errs, "mutator error occurred")
|
||||
assert.Contains(t, errs, "cleanup error occurred")
|
||||
|
||||
assert.Equal(t, 1, m1.applyCalled)
|
||||
assert.Equal(t, 1, m2.applyCalled)
|
||||
assert.Equal(t, 1, mErr.applyCalled)
|
||||
assert.Equal(t, 1, cleanupErr.applyCalled)
|
||||
}
|
||||
|
|
@ -32,10 +32,10 @@ func TestLoadWithNoState(t *testing.T) {
|
|||
t.Setenv("DATABRICKS_TOKEN", "foobar")
|
||||
b.WorkspaceClient()
|
||||
|
||||
diags := bundle.Apply(context.Background(), b, bundle.Seq(
|
||||
diags := bundle.ApplySeq(context.Background(), b,
|
||||
Initialize(),
|
||||
Load(ErrorOnEmptyState),
|
||||
))
|
||||
)
|
||||
|
||||
require.ErrorContains(t, diags.Error(), "Did you forget to run 'databricks bundle deploy'")
|
||||
}
|
||||
|
|
|
|||
40
bundle/if.go
40
bundle/if.go
|
|
@ -1,40 +0,0 @@
|
|||
package bundle
|
||||
|
||||
import (
|
||||
"context"
|
||||
|
||||
"github.com/databricks/cli/libs/diag"
|
||||
)
|
||||
|
||||
type ifMutator struct {
|
||||
condition func(context.Context, *Bundle) (bool, error)
|
||||
onTrueMutator Mutator
|
||||
onFalseMutator Mutator
|
||||
}
|
||||
|
||||
func If(
|
||||
condition func(context.Context, *Bundle) (bool, error),
|
||||
onTrueMutator Mutator,
|
||||
onFalseMutator Mutator,
|
||||
) Mutator {
|
||||
return &ifMutator{
|
||||
condition, onTrueMutator, onFalseMutator,
|
||||
}
|
||||
}
|
||||
|
||||
func (m *ifMutator) Apply(ctx context.Context, b *Bundle) diag.Diagnostics {
|
||||
v, err := m.condition(ctx, b)
|
||||
if err != nil {
|
||||
return diag.FromErr(err)
|
||||
}
|
||||
|
||||
if v {
|
||||
return Apply(ctx, b, m.onTrueMutator)
|
||||
} else {
|
||||
return Apply(ctx, b, m.onFalseMutator)
|
||||
}
|
||||
}
|
||||
|
||||
func (m *ifMutator) Name() string {
|
||||
return "If"
|
||||
}
|
||||
|
|
@ -1,53 +0,0 @@
|
|||
package bundle
|
||||
|
||||
import (
|
||||
"context"
|
||||
"testing"
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
)
|
||||
|
||||
func TestIfMutatorTrue(t *testing.T) {
|
||||
m1 := &testMutator{}
|
||||
m2 := &testMutator{}
|
||||
ifMutator := If(func(context.Context, *Bundle) (bool, error) {
|
||||
return true, nil
|
||||
}, m1, m2)
|
||||
|
||||
b := &Bundle{}
|
||||
diags := Apply(context.Background(), b, ifMutator)
|
||||
assert.NoError(t, diags.Error())
|
||||
|
||||
assert.Equal(t, 1, m1.applyCalled)
|
||||
assert.Equal(t, 0, m2.applyCalled)
|
||||
}
|
||||
|
||||
func TestIfMutatorFalse(t *testing.T) {
|
||||
m1 := &testMutator{}
|
||||
m2 := &testMutator{}
|
||||
ifMutator := If(func(context.Context, *Bundle) (bool, error) {
|
||||
return false, nil
|
||||
}, m1, m2)
|
||||
|
||||
b := &Bundle{}
|
||||
diags := Apply(context.Background(), b, ifMutator)
|
||||
assert.NoError(t, diags.Error())
|
||||
|
||||
assert.Equal(t, 0, m1.applyCalled)
|
||||
assert.Equal(t, 1, m2.applyCalled)
|
||||
}
|
||||
|
||||
func TestIfMutatorError(t *testing.T) {
|
||||
m1 := &testMutator{}
|
||||
m2 := &testMutator{}
|
||||
ifMutator := If(func(context.Context, *Bundle) (bool, error) {
|
||||
return true, assert.AnError
|
||||
}, m1, m2)
|
||||
|
||||
b := &Bundle{}
|
||||
diags := Apply(context.Background(), b, ifMutator)
|
||||
assert.Error(t, diags.Error())
|
||||
|
||||
assert.Equal(t, 0, m1.applyCalled)
|
||||
assert.Equal(t, 0, m2.applyCalled)
|
||||
}
|
||||
|
|
@ -93,7 +93,7 @@ func TestArtifactUploadForWorkspace(t *testing.T) {
|
|||
filer.CreateParentDirectories,
|
||||
).Return(nil)
|
||||
|
||||
diags := bundle.Apply(context.Background(), b, bundle.Seq(ExpandGlobReferences(), UploadWithClient(mockFiler)))
|
||||
diags := bundle.ApplySeq(context.Background(), b, ExpandGlobReferences(), UploadWithClient(mockFiler))
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
// Test that libraries path is updated
|
||||
|
|
@ -181,7 +181,7 @@ func TestArtifactUploadForVolumes(t *testing.T) {
|
|||
filer.CreateParentDirectories,
|
||||
).Return(nil)
|
||||
|
||||
diags := bundle.Apply(context.Background(), b, bundle.Seq(ExpandGlobReferences(), UploadWithClient(mockFiler)))
|
||||
diags := bundle.ApplySeq(context.Background(), b, ExpandGlobReferences(), UploadWithClient(mockFiler))
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
// Test that libraries path is updated
|
||||
|
|
@ -225,7 +225,7 @@ func TestArtifactUploadWithNoLibraryReference(t *testing.T) {
|
|||
filer.CreateParentDirectories,
|
||||
).Return(nil)
|
||||
|
||||
diags := bundle.Apply(context.Background(), b, bundle.Seq(ExpandGlobReferences(), UploadWithClient(mockFiler)))
|
||||
diags := bundle.ApplySeq(context.Background(), b, ExpandGlobReferences(), UploadWithClient(mockFiler))
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
require.Equal(t, "/Workspace/foo/bar/artifacts/.internal/source.whl", b.Config.Artifacts["whl"].Files[0].RemotePath)
|
||||
|
|
@ -311,7 +311,7 @@ func TestUploadMultipleLibraries(t *testing.T) {
|
|||
filer.CreateParentDirectories,
|
||||
).Return(nil).Once()
|
||||
|
||||
diags := bundle.Apply(context.Background(), b, bundle.Seq(ExpandGlobReferences(), UploadWithClient(mockFiler)))
|
||||
diags := bundle.ApplySeq(context.Background(), b, ExpandGlobReferences(), UploadWithClient(mockFiler))
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
// Test that libraries path is updated
|
||||
|
|
|
|||
|
|
@ -1,28 +0,0 @@
|
|||
package bundle
|
||||
|
||||
import (
|
||||
"context"
|
||||
|
||||
"github.com/databricks/cli/libs/cmdio"
|
||||
"github.com/databricks/cli/libs/diag"
|
||||
)
|
||||
|
||||
type LogStringMutator struct {
|
||||
message string
|
||||
}
|
||||
|
||||
func (d *LogStringMutator) Name() string {
|
||||
return "log_string"
|
||||
}
|
||||
|
||||
func LogString(message string) Mutator {
|
||||
return &LogStringMutator{
|
||||
message: message,
|
||||
}
|
||||
}
|
||||
|
||||
func (m *LogStringMutator) Apply(ctx context.Context, b *Bundle) diag.Diagnostics {
|
||||
cmdio.LogString(ctx, m.message)
|
||||
|
||||
return nil
|
||||
}
|
||||
|
|
@ -48,6 +48,17 @@ func Apply(ctx context.Context, b *Bundle, m Mutator) diag.Diagnostics {
|
|||
return diags
|
||||
}
|
||||
|
||||
func ApplySeq(ctx context.Context, b *Bundle, mutators ...Mutator) diag.Diagnostics {
|
||||
diags := diag.Diagnostics{}
|
||||
for _, m := range mutators {
|
||||
diags = diags.Extend(Apply(ctx, b, m))
|
||||
if diags.HasError() {
|
||||
return diags
|
||||
}
|
||||
}
|
||||
return diags
|
||||
}
|
||||
|
||||
type funcMutator struct {
|
||||
fn func(context.Context, *Bundle) diag.Diagnostics
|
||||
}
|
||||
|
|
|
|||
|
|
@ -19,7 +19,7 @@ func (t *testMutator) Name() string {
|
|||
|
||||
func (t *testMutator) Apply(ctx context.Context, b *Bundle) diag.Diagnostics {
|
||||
t.applyCalled++
|
||||
return Apply(ctx, b, Seq(t.nestedMutators...))
|
||||
return ApplySeq(ctx, b, t.nestedMutators...)
|
||||
}
|
||||
|
||||
func TestMutator(t *testing.T) {
|
||||
|
|
|
|||
|
|
@ -34,7 +34,7 @@ func TestValidateSharedRootPermissionsForShared(t *testing.T) {
|
|||
m := mocks.NewMockWorkspaceClient(t)
|
||||
b.SetWorkpaceClient(m.WorkspaceClient)
|
||||
|
||||
diags := bundle.Apply(context.Background(), b, bundle.Seq(ValidateSharedRootPermissions()))
|
||||
diags := bundle.Apply(context.Background(), b, ValidateSharedRootPermissions())
|
||||
require.Empty(t, diags)
|
||||
}
|
||||
|
||||
|
|
@ -59,7 +59,7 @@ func TestValidateSharedRootPermissionsForSharedError(t *testing.T) {
|
|||
m := mocks.NewMockWorkspaceClient(t)
|
||||
b.SetWorkpaceClient(m.WorkspaceClient)
|
||||
|
||||
diags := bundle.Apply(context.Background(), b, bundle.Seq(ValidateSharedRootPermissions()))
|
||||
diags := bundle.Apply(context.Background(), b, ValidateSharedRootPermissions())
|
||||
require.Len(t, diags, 1)
|
||||
require.Equal(t, "the bundle root path /Workspace/Shared/foo/bar is writable by all workspace users", diags[0].Summary)
|
||||
require.Equal(t, diag.Warning, diags[0].Severity)
|
||||
|
|
|
|||
|
|
@ -73,7 +73,7 @@ func TestApplyWorkspaceRootPermissions(t *testing.T) {
|
|||
WorkspaceObjectType: "directories",
|
||||
}).Return(nil, nil)
|
||||
|
||||
diags := bundle.Apply(context.Background(), b, bundle.Seq(ValidateSharedRootPermissions(), ApplyWorkspaceRootPermissions()))
|
||||
diags := bundle.ApplySeq(context.Background(), b, ValidateSharedRootPermissions(), ApplyWorkspaceRootPermissions())
|
||||
require.Empty(t, diags)
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -1,45 +1,57 @@
|
|||
package phases
|
||||
|
||||
import (
|
||||
"context"
|
||||
|
||||
"github.com/databricks/cli/bundle"
|
||||
"github.com/databricks/cli/bundle/deploy/lock"
|
||||
"github.com/databricks/cli/bundle/deploy/terraform"
|
||||
"github.com/databricks/cli/libs/diag"
|
||||
"github.com/databricks/cli/libs/log"
|
||||
)
|
||||
|
||||
func Bind(opts *terraform.BindOptions) bundle.Mutator {
|
||||
return newPhase(
|
||||
"bind",
|
||||
[]bundle.Mutator{
|
||||
lock.Acquire(),
|
||||
bundle.Defer(
|
||||
bundle.Seq(
|
||||
func Bind(ctx context.Context, b *bundle.Bundle, opts *terraform.BindOptions) (diags diag.Diagnostics) {
|
||||
log.Info(ctx, "Phase: bind")
|
||||
|
||||
diags = bundle.Apply(ctx, b, lock.Acquire())
|
||||
if diags.HasError() {
|
||||
return diags
|
||||
}
|
||||
|
||||
defer func() {
|
||||
diags = diags.Extend(bundle.Apply(ctx, b, lock.Release(lock.GoalBind)))
|
||||
}()
|
||||
|
||||
diags = diags.Extend(bundle.ApplySeq(ctx, b,
|
||||
terraform.StatePull(),
|
||||
terraform.Interpolate(),
|
||||
terraform.Write(),
|
||||
terraform.Import(opts),
|
||||
terraform.StatePush(),
|
||||
),
|
||||
lock.Release(lock.GoalBind),
|
||||
),
|
||||
},
|
||||
)
|
||||
))
|
||||
|
||||
return diags
|
||||
}
|
||||
|
||||
func Unbind(resourceType, resourceKey string) bundle.Mutator {
|
||||
return newPhase(
|
||||
"unbind",
|
||||
[]bundle.Mutator{
|
||||
lock.Acquire(),
|
||||
bundle.Defer(
|
||||
bundle.Seq(
|
||||
func Unbind(ctx context.Context, b *bundle.Bundle, resourceType, resourceKey string) (diags diag.Diagnostics) {
|
||||
log.Info(ctx, "Phase: unbind")
|
||||
|
||||
diags = bundle.Apply(ctx, b, lock.Acquire())
|
||||
if diags.HasError() {
|
||||
return diags
|
||||
}
|
||||
|
||||
defer func() {
|
||||
diags = diags.Extend(bundle.Apply(ctx, b, lock.Release(lock.GoalUnbind)))
|
||||
}()
|
||||
|
||||
diags = diags.Extend(bundle.ApplySeq(ctx, b,
|
||||
terraform.StatePull(),
|
||||
terraform.Interpolate(),
|
||||
terraform.Write(),
|
||||
terraform.Unbind(resourceType, resourceKey),
|
||||
terraform.StatePush(),
|
||||
),
|
||||
lock.Release(lock.GoalUnbind),
|
||||
),
|
||||
},
|
||||
)
|
||||
))
|
||||
|
||||
return diags
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1,19 +1,23 @@
|
|||
package phases
|
||||
|
||||
import (
|
||||
"context"
|
||||
|
||||
"github.com/databricks/cli/bundle"
|
||||
"github.com/databricks/cli/bundle/artifacts"
|
||||
"github.com/databricks/cli/bundle/artifacts/whl"
|
||||
"github.com/databricks/cli/bundle/config"
|
||||
"github.com/databricks/cli/bundle/config/mutator"
|
||||
"github.com/databricks/cli/bundle/scripts"
|
||||
"github.com/databricks/cli/libs/diag"
|
||||
"github.com/databricks/cli/libs/log"
|
||||
)
|
||||
|
||||
// The build phase builds artifacts.
|
||||
func Build() bundle.Mutator {
|
||||
return newPhase(
|
||||
"build",
|
||||
[]bundle.Mutator{
|
||||
func Build(ctx context.Context, b *bundle.Bundle) diag.Diagnostics {
|
||||
log.Info(ctx, "Phase: build")
|
||||
|
||||
return bundle.ApplySeq(ctx, b,
|
||||
scripts.Execute(config.ScriptPreBuild),
|
||||
whl.DetectPackage(),
|
||||
artifacts.InferMissingProperties(),
|
||||
|
|
@ -23,6 +27,5 @@ func Build() bundle.Mutator {
|
|||
mutator.ResolveVariableReferences(
|
||||
"artifacts",
|
||||
),
|
||||
},
|
||||
)
|
||||
}
|
||||
|
|
|
|||
|
|
@ -19,6 +19,8 @@ import (
|
|||
"github.com/databricks/cli/bundle/scripts"
|
||||
"github.com/databricks/cli/bundle/trampoline"
|
||||
"github.com/databricks/cli/libs/cmdio"
|
||||
"github.com/databricks/cli/libs/diag"
|
||||
"github.com/databricks/cli/libs/log"
|
||||
"github.com/databricks/cli/libs/sync"
|
||||
terraformlib "github.com/databricks/cli/libs/terraform"
|
||||
tfjson "github.com/hashicorp/terraform-json"
|
||||
|
|
@ -124,31 +126,52 @@ is removed from the catalog, but the underlying files are not deleted:`
|
|||
return approved, nil
|
||||
}
|
||||
|
||||
// The deploy phase deploys artifacts and resources.
|
||||
func Deploy(outputHandler sync.OutputHandler) bundle.Mutator {
|
||||
func deployCore(ctx context.Context, b *bundle.Bundle) diag.Diagnostics {
|
||||
// Core mutators that CRUD resources and modify deployment state. These
|
||||
// mutators need informed consent if they are potentially destructive.
|
||||
deployCore := bundle.Defer(
|
||||
bundle.Seq(
|
||||
bundle.LogString("Deploying resources..."),
|
||||
terraform.Apply(),
|
||||
),
|
||||
bundle.Seq(
|
||||
cmdio.LogString(ctx, "Deploying resources...")
|
||||
diags := bundle.Apply(ctx, b, terraform.Apply())
|
||||
|
||||
// following original logic, continuing with sequence below even if terraform had errors
|
||||
|
||||
diags = diags.Extend(bundle.ApplySeq(ctx, b,
|
||||
terraform.StatePush(),
|
||||
terraform.Load(),
|
||||
apps.InterpolateVariables(),
|
||||
apps.UploadConfig(),
|
||||
metadata.Compute(),
|
||||
metadata.Upload(),
|
||||
bundle.LogString("Deployment complete!"),
|
||||
),
|
||||
)
|
||||
))
|
||||
|
||||
deployMutator := bundle.Seq(
|
||||
if !diags.HasError() {
|
||||
cmdio.LogString(ctx, "Deployment complete!")
|
||||
}
|
||||
|
||||
return diags
|
||||
}
|
||||
|
||||
// The deploy phase deploys artifacts and resources.
|
||||
func Deploy(ctx context.Context, b *bundle.Bundle, outputHandler sync.OutputHandler) (diags diag.Diagnostics) {
|
||||
log.Info(ctx, "Phase: deploy")
|
||||
|
||||
// Core mutators that CRUD resources and modify deployment state. These
|
||||
// mutators need informed consent if they are potentially destructive.
|
||||
diags = bundle.ApplySeq(ctx, b,
|
||||
scripts.Execute(config.ScriptPreDeploy),
|
||||
lock.Acquire(),
|
||||
bundle.Defer(
|
||||
bundle.Seq(
|
||||
)
|
||||
|
||||
if diags.HasError() {
|
||||
// lock is not acquired here
|
||||
return diags
|
||||
}
|
||||
|
||||
// lock is acquired here
|
||||
defer func() {
|
||||
diags = diags.Extend(bundle.Apply(ctx, b, lock.Release(lock.GoalDeploy)))
|
||||
}()
|
||||
|
||||
diags = bundle.ApplySeq(ctx, b,
|
||||
terraform.StatePull(),
|
||||
terraform.CheckDashboardsModifiedRemotely(),
|
||||
deploy.StatePull(),
|
||||
|
|
@ -165,19 +188,27 @@ func Deploy(outputHandler sync.OutputHandler) bundle.Mutator {
|
|||
terraform.Write(),
|
||||
terraform.CheckRunningResource(),
|
||||
terraform.Plan(terraform.PlanGoal("deploy")),
|
||||
bundle.If(
|
||||
approvalForDeploy,
|
||||
deployCore,
|
||||
bundle.LogString("Deployment cancelled!"),
|
||||
),
|
||||
),
|
||||
lock.Release(lock.GoalDeploy),
|
||||
),
|
||||
scripts.Execute(config.ScriptPostDeploy),
|
||||
)
|
||||
|
||||
return newPhase(
|
||||
"deploy",
|
||||
[]bundle.Mutator{deployMutator},
|
||||
)
|
||||
if diags.HasError() {
|
||||
return diags
|
||||
}
|
||||
|
||||
haveApproval, err := approvalForDeploy(ctx, b)
|
||||
if err != nil {
|
||||
diags = diags.Extend(diag.FromErr(err))
|
||||
return diags
|
||||
}
|
||||
|
||||
if haveApproval {
|
||||
diags = diags.Extend(deployCore(ctx, b))
|
||||
} else {
|
||||
cmdio.LogString(ctx, "Deployment cancelled!")
|
||||
}
|
||||
|
||||
if diags.HasError() {
|
||||
return diags
|
||||
}
|
||||
|
||||
return diags.Extend(bundle.Apply(ctx, b, scripts.Execute(config.ScriptPostDeploy)))
|
||||
}
|
||||
|
|
|
|||
|
|
@ -11,6 +11,7 @@ import (
|
|||
"github.com/databricks/cli/bundle/deploy/terraform"
|
||||
|
||||
"github.com/databricks/cli/libs/cmdio"
|
||||
"github.com/databricks/cli/libs/diag"
|
||||
|
||||
"github.com/databricks/cli/libs/log"
|
||||
terraformlib "github.com/databricks/cli/libs/terraform"
|
||||
|
|
@ -77,42 +78,65 @@ func approvalForDestroy(ctx context.Context, b *bundle.Bundle) (bool, error) {
|
|||
return approved, nil
|
||||
}
|
||||
|
||||
// The destroy phase deletes artifacts and resources.
|
||||
func Destroy() bundle.Mutator {
|
||||
func destroyCore(ctx context.Context, b *bundle.Bundle) diag.Diagnostics {
|
||||
// Core destructive mutators for destroy. These require informed user consent.
|
||||
destroyCore := bundle.Seq(
|
||||
diags := bundle.ApplySeq(ctx, b,
|
||||
terraform.Apply(),
|
||||
files.Delete(),
|
||||
bundle.LogString("Destroy complete!"),
|
||||
)
|
||||
|
||||
destroyMutator := bundle.Seq(
|
||||
lock.Acquire(),
|
||||
bundle.Defer(
|
||||
bundle.Seq(
|
||||
if !diags.HasError() {
|
||||
cmdio.LogString(ctx, "Destroy complete!")
|
||||
}
|
||||
|
||||
return diags
|
||||
}
|
||||
|
||||
// The destroy phase deletes artifacts and resources.
|
||||
func Destroy(ctx context.Context, b *bundle.Bundle) (diags diag.Diagnostics) {
|
||||
log.Info(ctx, "Phase: destroy")
|
||||
|
||||
ok, err := assertRootPathExists(ctx, b)
|
||||
if err != nil {
|
||||
return diag.FromErr(err)
|
||||
}
|
||||
|
||||
if !ok {
|
||||
cmdio.LogString(ctx, "No active deployment found to destroy!")
|
||||
return diags
|
||||
}
|
||||
|
||||
diags = diags.Extend(bundle.Apply(ctx, b, lock.Acquire()))
|
||||
if diags.HasError() {
|
||||
return diags
|
||||
}
|
||||
|
||||
defer func() {
|
||||
diags = diags.Extend(bundle.Apply(ctx, b, lock.Release(lock.GoalDestroy)))
|
||||
}()
|
||||
|
||||
diags = diags.Extend(bundle.ApplySeq(ctx, b,
|
||||
terraform.StatePull(),
|
||||
terraform.Interpolate(),
|
||||
terraform.Write(),
|
||||
terraform.Plan(terraform.PlanGoal("destroy")),
|
||||
bundle.If(
|
||||
approvalForDestroy,
|
||||
destroyCore,
|
||||
bundle.LogString("Destroy cancelled!"),
|
||||
),
|
||||
),
|
||||
lock.Release(lock.GoalDestroy),
|
||||
),
|
||||
)
|
||||
))
|
||||
|
||||
return newPhase(
|
||||
"destroy",
|
||||
[]bundle.Mutator{
|
||||
// Only run deploy mutator if root path exists.
|
||||
bundle.If(
|
||||
assertRootPathExists,
|
||||
destroyMutator,
|
||||
bundle.LogString("No active deployment found to destroy!"),
|
||||
),
|
||||
},
|
||||
)
|
||||
if diags.HasError() {
|
||||
return diags
|
||||
}
|
||||
|
||||
hasApproval, err := approvalForDestroy(ctx, b)
|
||||
if err != nil {
|
||||
diags = diags.Extend(diag.FromErr(err))
|
||||
return diags
|
||||
}
|
||||
|
||||
if hasApproval {
|
||||
diags = diags.Extend(destroyCore(ctx, b))
|
||||
} else {
|
||||
cmdio.LogString(ctx, "Destroy cancelled!")
|
||||
}
|
||||
|
||||
return diags
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1,6 +1,8 @@
|
|||
package phases
|
||||
|
||||
import (
|
||||
"context"
|
||||
|
||||
"github.com/databricks/cli/bundle"
|
||||
"github.com/databricks/cli/bundle/apps"
|
||||
"github.com/databricks/cli/bundle/config"
|
||||
|
|
@ -12,15 +14,17 @@ import (
|
|||
"github.com/databricks/cli/bundle/permissions"
|
||||
"github.com/databricks/cli/bundle/scripts"
|
||||
"github.com/databricks/cli/bundle/trampoline"
|
||||
"github.com/databricks/cli/libs/diag"
|
||||
"github.com/databricks/cli/libs/log"
|
||||
)
|
||||
|
||||
// The initialize phase fills in defaults and connects to the workspace.
|
||||
// Interpolation of fields referring to the "bundle" and "workspace" keys
|
||||
// happens upon completion of this phase.
|
||||
func Initialize() bundle.Mutator {
|
||||
return newPhase(
|
||||
"initialize",
|
||||
[]bundle.Mutator{
|
||||
func Initialize(ctx context.Context, b *bundle.Bundle) diag.Diagnostics {
|
||||
log.Info(ctx, "Phase: initialize")
|
||||
|
||||
return bundle.ApplySeq(ctx, b,
|
||||
validate.AllResourcesHaveValues(),
|
||||
|
||||
// Update all path fields in the sync block to be relative to the bundle root path.
|
||||
|
|
@ -101,6 +105,5 @@ func Initialize() bundle.Mutator {
|
|||
metadata.AnnotatePipelines(),
|
||||
terraform.Initialize(),
|
||||
scripts.Execute(config.ScriptPostInit),
|
||||
},
|
||||
)
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1,29 +1,40 @@
|
|||
package phases
|
||||
|
||||
import (
|
||||
"context"
|
||||
|
||||
"github.com/databricks/cli/bundle"
|
||||
"github.com/databricks/cli/bundle/config/mutator"
|
||||
"github.com/databricks/cli/libs/diag"
|
||||
"github.com/databricks/cli/libs/log"
|
||||
)
|
||||
|
||||
// The load phase loads configuration from disk and performs
|
||||
// lightweight preprocessing (anything that can be done without network I/O).
|
||||
func Load() bundle.Mutator {
|
||||
return newPhase(
|
||||
"load",
|
||||
mutator.DefaultMutators(),
|
||||
)
|
||||
func Load(ctx context.Context, b *bundle.Bundle) diag.Diagnostics {
|
||||
log.Info(ctx, "Phase: load")
|
||||
|
||||
return mutator.DefaultMutators(ctx, b)
|
||||
}
|
||||
|
||||
func LoadDefaultTarget() bundle.Mutator {
|
||||
return newPhase(
|
||||
"load",
|
||||
append(mutator.DefaultMutators(), mutator.SelectDefaultTarget()),
|
||||
)
|
||||
func LoadDefaultTarget(ctx context.Context, b *bundle.Bundle) diag.Diagnostics {
|
||||
log.Info(ctx, "Phase: load")
|
||||
|
||||
diags := mutator.DefaultMutators(ctx, b)
|
||||
if diags.HasError() {
|
||||
return diags
|
||||
}
|
||||
|
||||
return diags.Extend(bundle.Apply(ctx, b, mutator.SelectDefaultTarget()))
|
||||
}
|
||||
|
||||
func LoadNamedTarget(target string) bundle.Mutator {
|
||||
return newPhase(
|
||||
"load",
|
||||
append(mutator.DefaultMutators(), mutator.SelectTarget(target)),
|
||||
)
|
||||
func LoadNamedTarget(ctx context.Context, b *bundle.Bundle, target string) diag.Diagnostics {
|
||||
log.Info(ctx, "Phase: load")
|
||||
|
||||
diags := mutator.DefaultMutators(ctx, b)
|
||||
if diags.HasError() {
|
||||
return diags
|
||||
}
|
||||
|
||||
return diags.Extend(bundle.Apply(ctx, b, mutator.SelectTarget(target)))
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1,33 +0,0 @@
|
|||
// Package phases defines build phases as logical groups of [bundle.Mutator] instances.
|
||||
package phases
|
||||
|
||||
import (
|
||||
"context"
|
||||
|
||||
"github.com/databricks/cli/bundle"
|
||||
"github.com/databricks/cli/libs/diag"
|
||||
"github.com/databricks/cli/libs/log"
|
||||
)
|
||||
|
||||
// This phase type groups mutators that belong to a lifecycle phase.
|
||||
// It expands into the specific mutators when applied.
|
||||
type phase struct {
|
||||
name string
|
||||
mutators []bundle.Mutator
|
||||
}
|
||||
|
||||
func newPhase(name string, mutators []bundle.Mutator) bundle.Mutator {
|
||||
return &phase{
|
||||
name: name,
|
||||
mutators: mutators,
|
||||
}
|
||||
}
|
||||
|
||||
func (p *phase) Name() string {
|
||||
return p.name
|
||||
}
|
||||
|
||||
func (p *phase) Apply(ctx context.Context, b *bundle.Bundle) diag.Diagnostics {
|
||||
log.Infof(ctx, "Phase: %s", p.Name())
|
||||
return bundle.Apply(ctx, b, bundle.Seq(p.mutators...))
|
||||
}
|
||||
|
|
@ -76,10 +76,10 @@ func setupBundle(t *testing.T) (context.Context, *bundle.Bundle, *mocks.MockWork
|
|||
|
||||
ctx := cmdio.MockDiscard(context.Background())
|
||||
|
||||
diags := bundle.Apply(ctx, b, bundle.Seq(
|
||||
diags := bundle.ApplySeq(ctx, b,
|
||||
mutator.DefineDefaultWorkspacePaths(),
|
||||
mutator.TranslatePaths(),
|
||||
))
|
||||
)
|
||||
require.Empty(t, diags)
|
||||
|
||||
return ctx, b, mwc
|
||||
|
|
|
|||
|
|
@ -1,30 +0,0 @@
|
|||
package bundle
|
||||
|
||||
import (
|
||||
"context"
|
||||
|
||||
"github.com/databricks/cli/libs/diag"
|
||||
)
|
||||
|
||||
type seqMutator struct {
|
||||
mutators []Mutator
|
||||
}
|
||||
|
||||
func (s *seqMutator) Name() string {
|
||||
return "seq"
|
||||
}
|
||||
|
||||
func (s *seqMutator) Apply(ctx context.Context, b *Bundle) diag.Diagnostics {
|
||||
var diags diag.Diagnostics
|
||||
for _, m := range s.mutators {
|
||||
diags = diags.Extend(Apply(ctx, b, m))
|
||||
if diags.HasError() {
|
||||
break
|
||||
}
|
||||
}
|
||||
return diags
|
||||
}
|
||||
|
||||
func Seq(ms ...Mutator) Mutator {
|
||||
return &seqMutator{mutators: ms}
|
||||
}
|
||||
|
|
@ -1,91 +0,0 @@
|
|||
package bundle
|
||||
|
||||
import (
|
||||
"context"
|
||||
"testing"
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
)
|
||||
|
||||
func TestSeqMutator(t *testing.T) {
|
||||
m1 := &testMutator{}
|
||||
m2 := &testMutator{}
|
||||
m3 := &testMutator{}
|
||||
seqMutator := Seq(m1, m2, m3)
|
||||
|
||||
b := &Bundle{}
|
||||
diags := Apply(context.Background(), b, seqMutator)
|
||||
assert.NoError(t, diags.Error())
|
||||
|
||||
assert.Equal(t, 1, m1.applyCalled)
|
||||
assert.Equal(t, 1, m2.applyCalled)
|
||||
assert.Equal(t, 1, m3.applyCalled)
|
||||
}
|
||||
|
||||
func TestSeqWithDeferredMutator(t *testing.T) {
|
||||
m1 := &testMutator{}
|
||||
m2 := &testMutator{}
|
||||
m3 := &testMutator{}
|
||||
m4 := &testMutator{}
|
||||
seqMutator := Seq(m1, Defer(m2, m3), m4)
|
||||
|
||||
b := &Bundle{}
|
||||
diags := Apply(context.Background(), b, seqMutator)
|
||||
assert.NoError(t, diags.Error())
|
||||
|
||||
assert.Equal(t, 1, m1.applyCalled)
|
||||
assert.Equal(t, 1, m2.applyCalled)
|
||||
assert.Equal(t, 1, m3.applyCalled)
|
||||
assert.Equal(t, 1, m4.applyCalled)
|
||||
}
|
||||
|
||||
func TestSeqWithErrorAndDeferredMutator(t *testing.T) {
|
||||
errorMut := &mutatorWithError{errorMsg: "error msg"}
|
||||
m1 := &testMutator{}
|
||||
m2 := &testMutator{}
|
||||
m3 := &testMutator{}
|
||||
seqMutator := Seq(errorMut, Defer(m1, m2), m3)
|
||||
|
||||
b := &Bundle{}
|
||||
diags := Apply(context.Background(), b, seqMutator)
|
||||
assert.Error(t, diags.Error())
|
||||
|
||||
assert.Equal(t, 1, errorMut.applyCalled)
|
||||
assert.Equal(t, 0, m1.applyCalled)
|
||||
assert.Equal(t, 0, m2.applyCalled)
|
||||
assert.Equal(t, 0, m3.applyCalled)
|
||||
}
|
||||
|
||||
func TestSeqWithErrorInsideDeferredMutator(t *testing.T) {
|
||||
errorMut := &mutatorWithError{errorMsg: "error msg"}
|
||||
m1 := &testMutator{}
|
||||
m2 := &testMutator{}
|
||||
m3 := &testMutator{}
|
||||
seqMutator := Seq(m1, Defer(errorMut, m2), m3)
|
||||
|
||||
b := &Bundle{}
|
||||
diags := Apply(context.Background(), b, seqMutator)
|
||||
assert.Error(t, diags.Error())
|
||||
|
||||
assert.Equal(t, 1, m1.applyCalled)
|
||||
assert.Equal(t, 1, errorMut.applyCalled)
|
||||
assert.Equal(t, 1, m2.applyCalled)
|
||||
assert.Equal(t, 0, m3.applyCalled)
|
||||
}
|
||||
|
||||
func TestSeqWithErrorInsideFinallyStage(t *testing.T) {
|
||||
errorMut := &mutatorWithError{errorMsg: "error msg"}
|
||||
m1 := &testMutator{}
|
||||
m2 := &testMutator{}
|
||||
m3 := &testMutator{}
|
||||
seqMutator := Seq(m1, Defer(m2, errorMut), m3)
|
||||
|
||||
b := &Bundle{}
|
||||
diags := Apply(context.Background(), b, seqMutator)
|
||||
assert.Error(t, diags.Error())
|
||||
|
||||
assert.Equal(t, 1, m1.applyCalled)
|
||||
assert.Equal(t, 1, m2.applyCalled)
|
||||
assert.Equal(t, 1, errorMut.applyCalled)
|
||||
assert.Equal(t, 0, m3.applyCalled)
|
||||
}
|
||||
|
|
@ -13,11 +13,10 @@ func TestApps(t *testing.T) {
|
|||
b := load(t, "./apps")
|
||||
assert.Equal(t, "apps", b.Config.Bundle.Name)
|
||||
|
||||
diags := bundle.Apply(context.Background(), b,
|
||||
bundle.Seq(
|
||||
diags := bundle.ApplySeq(context.Background(), b,
|
||||
mutator.SetVariables(),
|
||||
mutator.ResolveVariableReferences("variables"),
|
||||
))
|
||||
)
|
||||
assert.Empty(t, diags)
|
||||
|
||||
app := b.Config.Resources.Apps["my_app"]
|
||||
|
|
@ -37,11 +36,10 @@ func TestAppsOverride(t *testing.T) {
|
|||
b := loadTarget(t, "./apps", "development")
|
||||
assert.Equal(t, "apps", b.Config.Bundle.Name)
|
||||
|
||||
diags := bundle.Apply(context.Background(), b,
|
||||
bundle.Seq(
|
||||
diags := bundle.ApplySeq(context.Background(), b,
|
||||
mutator.SetVariables(),
|
||||
mutator.ResolveVariableReferences("variables"),
|
||||
))
|
||||
)
|
||||
assert.Empty(t, diags)
|
||||
app := b.Config.Resources.Apps["my_app"]
|
||||
assert.Equal(t, "my-app", app.Name)
|
||||
|
|
|
|||
|
|
@ -17,7 +17,7 @@ func TestIncludeInvalid(t *testing.T) {
|
|||
ctx := context.Background()
|
||||
b, err := bundle.Load(ctx, "./include_invalid")
|
||||
require.NoError(t, err)
|
||||
diags := bundle.Apply(ctx, b, phases.Load())
|
||||
diags := phases.Load(ctx, b)
|
||||
require.Error(t, diags.Error())
|
||||
assert.ErrorContains(t, diags.Error(), "notexists.yml defined in 'include' section does not match any files")
|
||||
}
|
||||
|
|
|
|||
|
|
@ -20,7 +20,7 @@ func load(t *testing.T, path string) *bundle.Bundle {
|
|||
ctx := context.Background()
|
||||
b, err := bundle.Load(ctx, path)
|
||||
require.NoError(t, err)
|
||||
diags := bundle.Apply(ctx, b, phases.Load())
|
||||
diags := phases.Load(ctx, b)
|
||||
require.NoError(t, diags.Error())
|
||||
return b
|
||||
}
|
||||
|
|
@ -38,8 +38,9 @@ func loadTargetWithDiags(path, env string) (*bundle.Bundle, diag.Diagnostics) {
|
|||
return nil, diag.FromErr(err)
|
||||
}
|
||||
|
||||
diags := bundle.Apply(ctx, b, bundle.Seq(
|
||||
phases.LoadNamedTarget(env),
|
||||
diags := phases.LoadNamedTarget(ctx, b, env)
|
||||
|
||||
diags = diags.Extend(bundle.ApplySeq(ctx, b,
|
||||
mutator.RewriteSyncPaths(),
|
||||
mutator.SyncDefaultPath(),
|
||||
mutator.SyncInferRoot(),
|
||||
|
|
@ -69,10 +70,8 @@ func initializeTarget(t *testing.T, path, env string) (*bundle.Bundle, diag.Diag
|
|||
configureMock(t, b)
|
||||
|
||||
ctx := dbr.MockRuntime(context.Background(), false)
|
||||
diags := bundle.Apply(ctx, b, bundle.Seq(
|
||||
mutator.SelectTarget(env),
|
||||
phases.Initialize(),
|
||||
))
|
||||
diags := bundle.Apply(ctx, b, mutator.SelectTarget(env))
|
||||
diags = diags.Extend(phases.Initialize(ctx, b))
|
||||
|
||||
return b, diags
|
||||
}
|
||||
|
|
|
|||
|
|
@ -18,7 +18,7 @@ func TestPythonWheelBuild(t *testing.T) {
|
|||
b := loadTarget(t, "./python_wheel/python_wheel", "default")
|
||||
|
||||
ctx := context.Background()
|
||||
diags := bundle.Apply(ctx, b, phases.Build())
|
||||
diags := phases.Build(ctx, b)
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
matches, err := filepath.Glob("./python_wheel/python_wheel/my_test_code/dist/my_test_code-*.whl")
|
||||
|
|
@ -34,7 +34,7 @@ func TestPythonWheelBuildAutoDetect(t *testing.T) {
|
|||
b := loadTarget(t, "./python_wheel/python_wheel_no_artifact", "default")
|
||||
|
||||
ctx := context.Background()
|
||||
diags := bundle.Apply(ctx, b, phases.Build())
|
||||
diags := phases.Build(ctx, b)
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
matches, err := filepath.Glob("./python_wheel/python_wheel_no_artifact/dist/my_test_code-*.whl")
|
||||
|
|
@ -50,7 +50,7 @@ func TestPythonWheelBuildAutoDetectWithNotebookTask(t *testing.T) {
|
|||
b := loadTarget(t, "./python_wheel/python_wheel_no_artifact_notebook", "default")
|
||||
|
||||
ctx := context.Background()
|
||||
diags := bundle.Apply(ctx, b, phases.Build())
|
||||
diags := phases.Build(ctx, b)
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
matches, err := filepath.Glob("./python_wheel/python_wheel_no_artifact_notebook/dist/my_test_code-*.whl")
|
||||
|
|
@ -66,7 +66,7 @@ func TestPythonWheelWithDBFSLib(t *testing.T) {
|
|||
b := loadTarget(t, "./python_wheel/python_wheel_dbfs_lib", "default")
|
||||
|
||||
ctx := context.Background()
|
||||
diags := bundle.Apply(ctx, b, phases.Build())
|
||||
diags := phases.Build(ctx, b)
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
match := libraries.ExpandGlobReferences()
|
||||
|
|
@ -78,7 +78,7 @@ func TestPythonWheelBuildNoBuildJustUpload(t *testing.T) {
|
|||
b := loadTarget(t, "./python_wheel/python_wheel_no_artifact_no_setup", "default")
|
||||
|
||||
ctx := context.Background()
|
||||
diags := bundle.Apply(ctx, b, phases.Build())
|
||||
diags := phases.Build(ctx, b)
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
mockFiler := mockfiler.NewMockFiler(t)
|
||||
|
|
@ -90,10 +90,10 @@ func TestPythonWheelBuildNoBuildJustUpload(t *testing.T) {
|
|||
filer.CreateParentDirectories,
|
||||
).Return(nil)
|
||||
|
||||
diags = bundle.Apply(ctx, b, bundle.Seq(
|
||||
diags = bundle.ApplySeq(ctx, b,
|
||||
libraries.ExpandGlobReferences(),
|
||||
libraries.UploadWithClient(mockFiler),
|
||||
))
|
||||
)
|
||||
require.NoError(t, diags.Error())
|
||||
require.Empty(t, diags)
|
||||
require.Equal(t, "/Workspace/foo/bar/.internal/my_test_code-0.0.1-py3-none-any.whl", b.Config.Resources.Jobs["test_job"].JobSettings.Tasks[0].Libraries[0].Whl)
|
||||
|
|
@ -103,7 +103,7 @@ func TestPythonWheelBuildWithEnvironmentKey(t *testing.T) {
|
|||
b := loadTarget(t, "./python_wheel/environment_key", "default")
|
||||
|
||||
ctx := context.Background()
|
||||
diags := bundle.Apply(ctx, b, phases.Build())
|
||||
diags := phases.Build(ctx, b)
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
matches, err := filepath.Glob("./python_wheel/environment_key/my_test_code/dist/my_test_code-*.whl")
|
||||
|
|
@ -119,7 +119,7 @@ func TestPythonWheelBuildMultiple(t *testing.T) {
|
|||
b := loadTarget(t, "./python_wheel/python_wheel_multiple", "default")
|
||||
|
||||
ctx := context.Background()
|
||||
diags := bundle.Apply(ctx, b, phases.Build())
|
||||
diags := phases.Build(ctx, b)
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
matches, err := filepath.Glob("./python_wheel/python_wheel_multiple/my_test_code/dist/my_test_code*.whl")
|
||||
|
|
@ -135,7 +135,7 @@ func TestPythonWheelNoBuild(t *testing.T) {
|
|||
b := loadTarget(t, "./python_wheel/python_wheel_no_build", "default")
|
||||
|
||||
ctx := context.Background()
|
||||
diags := bundle.Apply(ctx, b, phases.Build())
|
||||
diags := phases.Build(ctx, b)
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
match := libraries.ExpandGlobReferences()
|
||||
|
|
|
|||
|
|
@ -132,7 +132,7 @@ func TestValidateUniqueResourceIdentifiers(t *testing.T) {
|
|||
require.NoError(t, err)
|
||||
|
||||
// The UniqueResourceKeys mutator is run as part of the Load phase.
|
||||
diags := bundle.Apply(ctx, b, phases.Load())
|
||||
diags := phases.Load(ctx, b)
|
||||
assert.Equal(t, tc.diagnostics, diags)
|
||||
})
|
||||
}
|
||||
|
|
|
|||
|
|
@ -8,8 +8,8 @@ import (
|
|||
"strings"
|
||||
|
||||
"github.com/databricks/cli/bundle"
|
||||
"github.com/databricks/cli/bundle/config/mutator"
|
||||
"github.com/databricks/cli/bundle/libraries"
|
||||
"github.com/databricks/cli/libs/diag"
|
||||
"github.com/databricks/databricks-sdk-go/service/compute"
|
||||
"github.com/databricks/databricks-sdk-go/service/jobs"
|
||||
)
|
||||
|
|
@ -61,22 +61,30 @@ s = f.getvalue()
|
|||
dbutils.notebook.exit(s)
|
||||
`
|
||||
|
||||
type transformWheelTask struct{}
|
||||
|
||||
func (transformWheelTask) Name() string {
|
||||
return "TransformWheelTask"
|
||||
}
|
||||
|
||||
// This mutator takes the wheel task and transforms it into notebook
|
||||
// which installs uploaded wheels using %pip and then calling corresponding
|
||||
// entry point.
|
||||
func TransformWheelTask() bundle.Mutator {
|
||||
return bundle.If(
|
||||
func(_ context.Context, b *bundle.Bundle) (bool, error) {
|
||||
res := b.Config.Experimental != nil && b.Config.Experimental.PythonWheelWrapper
|
||||
return res, nil
|
||||
},
|
||||
NewTrampoline(
|
||||
return transformWheelTask{}
|
||||
}
|
||||
|
||||
func (transformWheelTask) Apply(ctx context.Context, b *bundle.Bundle) diag.Diagnostics {
|
||||
isEnabled := b.Config.Experimental != nil && b.Config.Experimental.PythonWheelWrapper
|
||||
if !isEnabled {
|
||||
return nil
|
||||
}
|
||||
|
||||
return bundle.Apply(ctx, b, NewTrampoline(
|
||||
"python_wheel",
|
||||
&pythonTrampoline{},
|
||||
NOTEBOOK_TEMPLATE,
|
||||
),
|
||||
mutator.NoOp(),
|
||||
)
|
||||
))
|
||||
}
|
||||
|
||||
type pythonTrampoline struct{}
|
||||
|
|
|
|||
|
|
@ -69,14 +69,19 @@ func newDeployCommand() *cobra.Command {
|
|||
}
|
||||
}
|
||||
|
||||
diags = diags.Extend(
|
||||
bundle.Apply(ctx, b, bundle.Seq(
|
||||
phases.Initialize(),
|
||||
validate.FastValidate(),
|
||||
phases.Build(),
|
||||
phases.Deploy(outputHandler),
|
||||
)),
|
||||
)
|
||||
diags = diags.Extend(phases.Initialize(ctx, b))
|
||||
|
||||
if !diags.HasError() {
|
||||
diags = diags.Extend(bundle.Apply(ctx, b, validate.FastValidate()))
|
||||
}
|
||||
|
||||
if !diags.HasError() {
|
||||
diags = diags.Extend(phases.Build(ctx, b))
|
||||
}
|
||||
|
||||
if !diags.HasError() {
|
||||
diags = diags.Extend(phases.Deploy(ctx, b, outputHandler))
|
||||
}
|
||||
}
|
||||
|
||||
renderOpts := render.RenderOptions{RenderSummaryTable: false}
|
||||
|
|
|
|||
|
|
@ -53,15 +53,15 @@ func newBindCommand() *cobra.Command {
|
|||
return nil
|
||||
})
|
||||
|
||||
diags = bundle.Apply(ctx, b, bundle.Seq(
|
||||
phases.Initialize(),
|
||||
phases.Bind(&terraform.BindOptions{
|
||||
diags = phases.Initialize(ctx, b)
|
||||
if !diags.HasError() {
|
||||
diags = diags.Extend(phases.Bind(ctx, b, &terraform.BindOptions{
|
||||
AutoApprove: autoApprove,
|
||||
ResourceType: resource.TerraformResourceName(),
|
||||
ResourceKey: args[0],
|
||||
ResourceId: args[1],
|
||||
}),
|
||||
))
|
||||
}))
|
||||
}
|
||||
if err := diags.Error(); err != nil {
|
||||
return fmt.Errorf("failed to bind the resource, err: %w", err)
|
||||
}
|
||||
|
|
|
|||
|
|
@ -38,10 +38,10 @@ func newUnbindCommand() *cobra.Command {
|
|||
return nil
|
||||
})
|
||||
|
||||
diags = bundle.Apply(cmd.Context(), b, bundle.Seq(
|
||||
phases.Initialize(),
|
||||
phases.Unbind(resource.TerraformResourceName(), args[0]),
|
||||
))
|
||||
diags = phases.Initialize(ctx, b)
|
||||
if !diags.HasError() {
|
||||
diags = diags.Extend(phases.Unbind(ctx, b, resource.TerraformResourceName(), args[0]))
|
||||
}
|
||||
if err := diags.Error(); err != nil {
|
||||
return err
|
||||
}
|
||||
|
|
|
|||
|
|
@ -61,20 +61,25 @@ func newDestroyCommand() *cobra.Command {
|
|||
return errors.New("please specify --auto-approve since selected logging format is json")
|
||||
}
|
||||
|
||||
diags = bundle.Apply(ctx, b, bundle.Seq(
|
||||
phases.Initialize(),
|
||||
// We need to resolve artifact variable (how we do it in build phase)
|
||||
// because some of the to-be-destroyed resource might use this variable.
|
||||
// Not resolving might lead to terraform "Reference to undeclared resource" error
|
||||
mutator.ResolveVariableReferences(
|
||||
"artifacts",
|
||||
),
|
||||
phases.Destroy(),
|
||||
))
|
||||
diags = phases.Initialize(ctx, b)
|
||||
if err := diags.Error(); err != nil {
|
||||
return err
|
||||
}
|
||||
return nil
|
||||
|
||||
diags = diags.Extend(
|
||||
// We need to resolve artifact variable (how we do it in build phase)
|
||||
// because some of the to-be-destroyed resource might use this variable.
|
||||
// Not resolving might lead to terraform "Reference to undeclared resource" error
|
||||
bundle.Apply(ctx, b, mutator.ResolveVariableReferences("artifacts")),
|
||||
)
|
||||
|
||||
if err := diags.Error(); err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
diags = diags.Extend(phases.Destroy(ctx, b))
|
||||
// QQQ we're not reporting warnings there. This would be addressed by switching to streaming warnings/errors instead of accumulating.
|
||||
return diags.Error()
|
||||
}
|
||||
|
||||
return cmd
|
||||
|
|
|
|||
|
|
@ -345,8 +345,12 @@ func (d *dashboard) initialize(b *bundle.Bundle) diag.Diagnostics {
|
|||
}
|
||||
|
||||
func (d *dashboard) runForResource(ctx context.Context, b *bundle.Bundle) diag.Diagnostics {
|
||||
diags := bundle.Apply(ctx, b, bundle.Seq(
|
||||
phases.Initialize(),
|
||||
diags := phases.Initialize(ctx, b)
|
||||
if diags.HasError() {
|
||||
return diags
|
||||
}
|
||||
|
||||
diags = diags.Extend(bundle.ApplySeq(ctx, b,
|
||||
terraform.Interpolate(),
|
||||
terraform.Write(),
|
||||
terraform.StatePull(),
|
||||
|
|
|
|||
|
|
@ -67,7 +67,7 @@ func newOpenCommand() *cobra.Command {
|
|||
return diags.Error()
|
||||
}
|
||||
|
||||
diags = bundle.Apply(ctx, b, phases.Initialize())
|
||||
diags = phases.Initialize(ctx, b)
|
||||
if err := diags.Error(); err != nil {
|
||||
return err
|
||||
}
|
||||
|
|
@ -86,20 +86,20 @@ func newOpenCommand() *cobra.Command {
|
|||
noCache := errors.Is(stateFileErr, os.ErrNotExist) || errors.Is(configFileErr, os.ErrNotExist)
|
||||
|
||||
if forcePull || noCache {
|
||||
diags = bundle.Apply(ctx, b, bundle.Seq(
|
||||
diags = bundle.ApplySeq(ctx, b,
|
||||
terraform.StatePull(),
|
||||
terraform.Interpolate(),
|
||||
terraform.Write(),
|
||||
))
|
||||
)
|
||||
if err := diags.Error(); err != nil {
|
||||
return err
|
||||
}
|
||||
}
|
||||
|
||||
diags = bundle.Apply(ctx, b, bundle.Seq(
|
||||
diags = bundle.ApplySeq(ctx, b,
|
||||
terraform.Load(),
|
||||
mutator.InitializeURLs(),
|
||||
))
|
||||
)
|
||||
if err := diags.Error(); err != nil {
|
||||
return err
|
||||
}
|
||||
|
|
|
|||
|
|
@ -111,7 +111,7 @@ task or a Python wheel task, the second example applies.
|
|||
return diags.Error()
|
||||
}
|
||||
|
||||
diags = bundle.Apply(ctx, b, phases.Initialize())
|
||||
diags = phases.Initialize(ctx, b)
|
||||
if err := diags.Error(); err != nil {
|
||||
return err
|
||||
}
|
||||
|
|
@ -121,12 +121,12 @@ task or a Python wheel task, the second example applies.
|
|||
return err
|
||||
}
|
||||
|
||||
diags = bundle.Apply(ctx, b, bundle.Seq(
|
||||
diags = bundle.ApplySeq(ctx, b,
|
||||
terraform.Interpolate(),
|
||||
terraform.Write(),
|
||||
terraform.StatePull(),
|
||||
terraform.Load(terraform.ErrorOnEmptyState),
|
||||
))
|
||||
)
|
||||
if err := diags.Error(); err != nil {
|
||||
return err
|
||||
}
|
||||
|
|
|
|||
|
|
@ -35,7 +35,7 @@ func newSummaryCommand() *cobra.Command {
|
|||
return diags.Error()
|
||||
}
|
||||
|
||||
diags = bundle.Apply(ctx, b, phases.Initialize())
|
||||
diags = phases.Initialize(ctx, b)
|
||||
if err := diags.Error(); err != nil {
|
||||
return err
|
||||
}
|
||||
|
|
@ -49,18 +49,20 @@ func newSummaryCommand() *cobra.Command {
|
|||
noCache := errors.Is(stateFileErr, os.ErrNotExist) || errors.Is(configFileErr, os.ErrNotExist)
|
||||
|
||||
if forcePull || noCache {
|
||||
diags = bundle.Apply(ctx, b, bundle.Seq(
|
||||
diags = bundle.ApplySeq(ctx, b,
|
||||
terraform.StatePull(),
|
||||
terraform.Interpolate(),
|
||||
terraform.Write(),
|
||||
))
|
||||
)
|
||||
if err := diags.Error(); err != nil {
|
||||
return err
|
||||
}
|
||||
}
|
||||
|
||||
diags = bundle.Apply(ctx, b,
|
||||
bundle.Seq(terraform.Load(), mutator.InitializeURLs()))
|
||||
diags = bundle.ApplySeq(ctx, b,
|
||||
terraform.Load(),
|
||||
mutator.InitializeURLs(),
|
||||
)
|
||||
if err := diags.Error(); err != nil {
|
||||
return err
|
||||
}
|
||||
|
|
|
|||
|
|
@ -71,7 +71,7 @@ func newSyncCommand() *cobra.Command {
|
|||
}
|
||||
|
||||
// Run initialize phase to make sure paths are set.
|
||||
diags = bundle.Apply(ctx, b, phases.Initialize())
|
||||
diags = phases.Initialize(ctx, b)
|
||||
if err := diags.Error(); err != nil {
|
||||
return err
|
||||
}
|
||||
|
|
|
|||
|
|
@ -46,7 +46,7 @@ func newValidateCommand() *cobra.Command {
|
|||
}
|
||||
|
||||
if !diags.HasError() {
|
||||
diags = diags.Extend(bundle.Apply(ctx, b, phases.Initialize()))
|
||||
diags = diags.Extend(phases.Initialize(ctx, b))
|
||||
}
|
||||
|
||||
if !diags.HasError() {
|
||||
|
|
|
|||
|
|
@ -74,16 +74,15 @@ func configureProfile(cmd *cobra.Command, b *bundle.Bundle) diag.Diagnostics {
|
|||
|
||||
// configureBundle loads the bundle configuration and configures flag values, if any.
|
||||
func configureBundle(cmd *cobra.Command, b *bundle.Bundle) (*bundle.Bundle, diag.Diagnostics) {
|
||||
var m bundle.Mutator
|
||||
if target := getTarget(cmd); target == "" {
|
||||
m = phases.LoadDefaultTarget()
|
||||
} else {
|
||||
m = phases.LoadNamedTarget(target)
|
||||
}
|
||||
|
||||
// Load bundle and select target.
|
||||
ctx := cmd.Context()
|
||||
diags := bundle.Apply(ctx, b, m)
|
||||
var diags diag.Diagnostics
|
||||
if target := getTarget(cmd); target == "" {
|
||||
diags = phases.LoadDefaultTarget(ctx, b)
|
||||
} else {
|
||||
diags = phases.LoadNamedTarget(ctx, b, target)
|
||||
}
|
||||
|
||||
if diags.HasError() {
|
||||
return b, diags
|
||||
}
|
||||
|
|
@ -159,7 +158,7 @@ func targetCompletion(cmd *cobra.Command, args []string, toComplete string) ([]s
|
|||
}
|
||||
|
||||
// Load bundle but don't select a target (we're completing those).
|
||||
diags := bundle.Apply(ctx, b, phases.Load())
|
||||
diags := phases.Load(ctx, b)
|
||||
if err := diags.Error(); err != nil {
|
||||
cobra.CompErrorln(err.Error())
|
||||
return nil, cobra.ShellCompDirectiveError
|
||||
|
|
|
|||
|
|
@ -80,7 +80,7 @@ func TestUploadArtifactFileToCorrectRemotePath(t *testing.T) {
|
|||
},
|
||||
}
|
||||
|
||||
diags := bundle.Apply(ctx, b, bundle.Seq(libraries.ExpandGlobReferences(), libraries.Upload()))
|
||||
diags := bundle.ApplySeq(ctx, b, libraries.ExpandGlobReferences(), libraries.Upload())
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
// The remote path attribute on the artifact file should have been set.
|
||||
|
|
@ -144,7 +144,7 @@ func TestUploadArtifactFileToCorrectRemotePathWithEnvironments(t *testing.T) {
|
|||
},
|
||||
}
|
||||
|
||||
diags := bundle.Apply(ctx, b, bundle.Seq(libraries.ExpandGlobReferences(), libraries.Upload()))
|
||||
diags := bundle.ApplySeq(ctx, b, libraries.ExpandGlobReferences(), libraries.Upload())
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
// The remote path attribute on the artifact file should have been set.
|
||||
|
|
@ -213,7 +213,7 @@ func TestUploadArtifactFileToCorrectRemotePathForVolumes(t *testing.T) {
|
|||
},
|
||||
}
|
||||
|
||||
diags := bundle.Apply(ctx, b, bundle.Seq(libraries.ExpandGlobReferences(), libraries.Upload()))
|
||||
diags := bundle.ApplySeq(ctx, b, libraries.ExpandGlobReferences(), libraries.Upload())
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
// The remote path attribute on the artifact file should have been set.
|
||||
|
|
|
|||
|
|
@ -78,7 +78,7 @@ func assertBuiltinTemplateValid(t *testing.T, template string, settings map[stri
|
|||
|
||||
b, err := bundle.Load(ctx, filepath.Join(tempDir, "my_project"))
|
||||
require.NoError(t, err)
|
||||
diags := bundle.Apply(ctx, b, phases.LoadNamedTarget(target))
|
||||
diags := phases.LoadNamedTarget(ctx, b, target)
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
// Apply initialize / validation mutators
|
||||
|
|
@ -93,14 +93,12 @@ func assertBuiltinTemplateValid(t *testing.T, template string, settings map[stri
|
|||
b.Tagging = tags.ForCloud(w.Config)
|
||||
b.WorkspaceClient()
|
||||
|
||||
diags = bundle.Apply(ctx, b, bundle.Seq(
|
||||
phases.Initialize(),
|
||||
))
|
||||
diags = phases.Initialize(ctx, b)
|
||||
require.NoError(t, diags.Error())
|
||||
|
||||
// Apply build mutator
|
||||
if build {
|
||||
diags = bundle.Apply(ctx, b, phases.Build())
|
||||
diags = phases.Build(ctx, b)
|
||||
require.NoError(t, diags.Error())
|
||||
}
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in New Issue