From ea4153e3237e8ba308fa0f722198a7a1d7b1e5e9 Mon Sep 17 00:00:00 2001 From: Andrew Nester Date: Fri, 10 Nov 2023 15:09:02 +0100 Subject: [PATCH] Fixed flaky TestBackgroundCombinedOutputFailure (#978) ## Changes `TestBackgroundCombinedOutputFailure` was occasionally failing because combined output could have been in different order, see https://github.com/databricks/cli/actions/runs/6823883271/job/18558675165?pr=928 --- libs/process/background_test.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libs/process/background_test.go b/libs/process/background_test.go index 94f7e881e..5bf2400bc 100644 --- a/libs/process/background_test.go +++ b/libs/process/background_test.go @@ -66,7 +66,10 @@ func TestBackgroundCombinedOutputFailure(t *testing.T) { assert.Equal(t, "2", strings.TrimSpace(processErr.Stdout)) } assert.Equal(t, "2", strings.TrimSpace(res)) - assert.Equal(t, "1\n2\n", strings.ReplaceAll(buf.String(), "\r", "")) + + out := strings.ReplaceAll(buf.String(), "\r", "") + assert.Contains(t, out, "1\n") + assert.Contains(t, out, "2\n") } func TestBackgroundNoStdin(t *testing.T) {