From eab29603fcda86ab61a6990b0765bbbb85d767c9 Mon Sep 17 00:00:00 2001 From: Shreyas Goenka Date: Sat, 15 Apr 2023 15:19:32 +0200 Subject: [PATCH] Revert "Log job errors using progress logger" This reverts commit a2e20f5206dfcf37131abe15fc50abae7eb4c152. --- bundle/run/job.go | 3 --- bundle/run/progress/job_events.go | 28 ---------------------------- 2 files changed, 31 deletions(-) delete mode 100644 bundle/run/progress/job_events.go diff --git a/bundle/run/job.go b/bundle/run/job.go index 881411b1e..56004c9cb 100644 --- a/bundle/run/job.go +++ b/bundle/run/job.go @@ -133,9 +133,6 @@ func (r *jobRunner) logFailedTasks(ctx context.Context, runId int64) { log.Errorf(ctx, "task %s failed. Unable to fetch error trace: %s", red(task.TaskKey), err) continue } - if progressLogger, ok := cmdio.FromContext(ctx); ok { - progressLogger.Log(progress.NewTaskErrorEvent(task.TaskKey, taskInfo.Error, taskInfo.ErrorTrace)) - } log.Errorf(ctx, "Task %s failed!\nError:\n%s\nTrace:\n%s", red(task.TaskKey), taskInfo.Error, taskInfo.ErrorTrace) } else { diff --git a/bundle/run/progress/job_events.go b/bundle/run/progress/job_events.go deleted file mode 100644 index 18c621ea1..000000000 --- a/bundle/run/progress/job_events.go +++ /dev/null @@ -1,28 +0,0 @@ -package progress - -import ( - "fmt" - "strings" -) - -type TaskErrorEvent struct { - TaskKey string `json:"task_key"` - Error string `json:"error"` - ErrorTrace string `json:"error_trace"` -} - -func NewTaskErrorEvent(taskKey, errorMessage, errorTrace string) *TaskErrorEvent { - return &TaskErrorEvent{ - TaskKey: taskKey, - Error: errorMessage, - ErrorTrace: errorTrace, - } -} - -func (event *TaskErrorEvent) String() string { - result := strings.Builder{} - result.WriteString(fmt.Sprintf("Task %s FAILED:\n", event.TaskKey)) - result.WriteString(event.Error + "\n") - result.WriteString(event.ErrorTrace + "\n") - return result.String() -}